Bug 615636: Labels are badly aligned when editing versions and milestones in admin pages

r/a=LpSolit

4 files changed, 14 insertions, 13 deletions

diff --git a/template/en/default/admin/components/edit-common.html.tmpl b/template/en/default/admin/components/edit-common.html.tmpl
index 6f65095af..9a65737db 100644
--- a/template/en/default/admin/components/edit-common.html.tmpl
+++ b/template/en/default/admin/components/edit-common.html.tmpl
@@ -27,15 +27,16 @@
 [% DEFAULT desc_name = "description" %]
 
 <tr>
-  <th align="right">Component:</th>
-  <td><input size="64" maxlength="64" name="component"
+  <th class="field_label"><label for="component">Component:</label></th>
+  <td><input size="64" maxlength="64" name="component" id="component"
              value="[%- comp.name FILTER html %]"></td>
 </tr>
 <tr>
-  <th align="right">Component Description:</th>
+  <th class="field_label"><label for="[% desc_name FILTER html %]">Component Description:</label></th>
   <td>
     [% INCLUDE global/textarea.html.tmpl
       name           = desc_name
+      id             = desc_name
       minrows        = 4
       cols           = 64
       wrap           = 'virtual'
@@ -44,7 +45,7 @@
   </td>
 </tr>
 <tr>
-  <th align="right"><label for="initialowner">Default Assignee:</label></th>
+  <th class="field_label"><label for="initialowner">Default Assignee:</label></th>
   <td>
     [% INCLUDE global/userselect.html.tmpl
        name => "initialowner"
@@ -56,7 +57,7 @@
 </tr>
 [% IF Param('useqacontact') %]
   <tr>
-    <th align="right"><label for="initialqacontact">Default QA contact:</label></th>
+    <th class="field_label"><label for="initialqacontact">Default QA contact:</label></th>
     <td>
       [% INCLUDE global/userselect.html.tmpl
          name => "initialqacontact"
@@ -69,7 +70,7 @@
   </tr>
 [% END %]
 <tr>
-  <th align="right"><label for="initialcc">Default CC List:</label></th>
+  <th class="field_label"><label for="initialcc">Default CC List:</label></th>
   <td>
     [% INCLUDE global/userselect.html.tmpl
        name     => "initialcc"
diff --git a/template/en/default/admin/components/edit.html.tmpl b/template/en/default/admin/components/edit.html.tmpl
index b5fc3c321..5236186cc 100644
--- a/template/en/default/admin/components/edit.html.tmpl
+++ b/template/en/default/admin/components/edit.html.tmpl
@@ -43,12 +43,12 @@
     [% PROCESS "admin/components/edit-common.html.tmpl" %]
 
     <tr>
-      <td><label for="isactive">Enabled For [% terms.Bugs %]:</label></td>
+      <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
       <td><input id="isactive" name="isactive" type="checkbox" value="1" 
                  [% 'checked="checked"' IF comp.isactive %]></td>
     </tr>
     <tr>
-      <td>[% terms.Bugs %]:</td>
+      <th class="field_label">[% terms.Bugs %]:</th>
       <td>
 [% IF comp.bug_count > 0 %]
         <a title="[% terms.Bugs %] in component '[% comp.name FILTER html %]'"
diff --git a/template/en/default/admin/milestones/edit.html.tmpl b/template/en/default/admin/milestones/edit.html.tmpl
index 6a2be869e..ef4b7fcc4 100644
--- a/template/en/default/admin/milestones/edit.html.tmpl
+++ b/template/en/default/admin/milestones/edit.html.tmpl
@@ -38,17 +38,17 @@
   <table border="0" cellpadding="4" cellspacing="0">
 
     <tr>
-      <th valign="top"><label for="milestone">Milestone:</label></th>
+      <th class="field_label"><label for="milestone">Milestone:</label></th>
       <td><input id="milestone" size="20" maxlength="20" name="milestone" value="
       [%- milestone.name FILTER html %]"></td>
     </tr>
     <tr>
-      <th align="right"><label for="sortkey">Sortkey:</label></th>
+      <th class="field_label"><label for="sortkey">Sortkey:</label></th>
       <td><input id="sortkey" size="20" maxlength="20" name="sortkey" value="
       [%- milestone.sortkey FILTER html %]"></td>
     </tr>
     <tr>
-      <th><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
+      <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
       <td><input id="isactive" name="isactive" type="checkbox" value="1"
                  [% 'checked="checked"' IF milestone.isactive %]></td>
     </tr>
diff --git a/template/en/default/admin/versions/edit.html.tmpl b/template/en/default/admin/versions/edit.html.tmpl
index 1de233567..497d67e2e 100644
--- a/template/en/default/admin/versions/edit.html.tmpl
+++ b/template/en/default/admin/versions/edit.html.tmpl
@@ -37,12 +37,12 @@
   <table border="0" cellpadding="4" cellspacing="0">
 
     <tr>
-      <th valign="top"><label for="version">Version:</label></th>
+      <th class="field_label"><label for="version">Version:</label></th>
       <td><input id="version" size="64" maxlength="64" name="version" value="
       [%- version.name FILTER html %]"></td>
     </tr>
     <tr>
-      <th><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
+      <th class="field_label"><label for="isactive">Enabled For [% terms.Bugs %]:</label></th>
       <td><input id="isactive" name="isactive" type="checkbox" value="1"
                  [% 'checked="checked"' IF version.isactive %]></td>
     </tr>