aboutsummaryrefslogtreecommitdiffstats
path: root/editproducts.cgi
diff options
context:
space:
mode:
authorcyeh%bluemartini.com <>2000-09-01 05:56:21 +0000
committercyeh%bluemartini.com <>2000-09-01 05:56:21 +0000
commit323763170be72166fd3b0e97f302d0966f9a7b8f (patch)
tree7e8bfa65cf6dde2429037006b923f647385eca18 /editproducts.cgi
parentf472f34b29502cb27e82172d7e2181703e0708f1 (diff)
downloadbugs-323763170be72166fd3b0e97f302d0966f9a7b8f.tar
bugs-323763170be72166fd3b0e97f302d0966f9a7b8f.tar.gz
bugs-323763170be72166fd3b0e97f302d0966f9a7b8f.tar.bz2
bugs-323763170be72166fd3b0e97f302d0966f9a7b8f.tar.xz
bugs-323763170be72166fd3b0e97f302d0966f9a7b8f.zip
fix for 45583: all users get added to a group if userregexp is null in editproducts.cgi
patch by jmrobins@tgix.com
Diffstat (limited to 'editproducts.cgi')
-rwxr-xr-xeditproducts.cgi24
1 files changed, 12 insertions, 12 deletions
diff --git a/editproducts.cgi b/editproducts.cgi
index bb42c89f9..f5486f37b 100755
--- a/editproducts.cgi
+++ b/editproducts.cgi
@@ -378,18 +378,18 @@ if ($action eq 'new') {
# one by one if they match. Furthermore, I need to do it with two
# separate loops, since opening a new SQL statement to do the update
# seems to clobber the previous one.
- SendSQL("SELECT login_name FROM profiles");
- my @login_list = ();
- my $this_login;
- while($this_login = FetchOneColumn()) {
- push @login_list, $this_login;
- }
- foreach $this_login (@login_list) {
- if($this_login =~ /$userregexp/i) {
- SendSQL("UPDATE profiles " .
- "SET groupset = groupset | " . $bit . " " .
- "WHERE login_name = " . SqlQuote($this_login));
- }
+
+ # Modified, 7/17/00, Joe Robins
+ # If the userregexp is left empty, then no users should be added to
+ # the bug group. As is, it was adding all users, since they all
+ # matched the empty pattern.
+ # In addition, I've replaced the rigamarole I was going through to
+ # find matching users with a much simpler statement that lets the
+ # mySQL database do the work.
+ unless($userregexp eq "") {
+ SendSQL("UPDATE profiles ".
+ "SET groupset = groupset | " . $bit . " " .
+ "WHERE LOWER(login_name) REGEXP LOWER(" . SqlQuote($userregexp) . ")");
}
}