Bug 380928 – Bugzilla::Auth::Verify::create_or_update_user can return stale Bugzilla::User object

patch by vrb@novell.com r=mkanat a=mkanat

1 files changed, 3 insertions, 4 deletions

diff --git a/Bugzilla/Auth/Verify.pm b/Bugzilla/Auth/Verify.pm
index deb5f4e95..b293e2583 100644
--- a/Bugzilla/Auth/Verify.pm
+++ b/Bugzilla/Auth/Verify.pm
@@ -116,16 +116,15 @@ sub create_or_update_user {
         validate_email_syntax($username)
           || return { failure => AUTH_ERROR, error => 'auth_invalid_email',
                       details => {addr => $username} };
-        $dbh->do('UPDATE profiles SET login_name = ? WHERE userid = ?',
-                 undef, $username, $user->id);
+        $user->set_login($username);
     }
     if ($real_name && $user->name ne $real_name) {
         # $real_name is more than likely tainted, but we only use it
         # in a placeholder and we never use it after this.
         trick_taint($real_name);
-        $dbh->do('UPDATE profiles SET realname = ? WHERE userid = ?',
-                 undef, $real_name, $user->id);
+        $user->set_name($real_name);
     }
+    $user->update();
 
     return { user => $user };
 }