1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
|
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<TITLE> [Mageia-dev] Minimal patching vs. fixing the whole Universe
</TITLE>
<LINK REL="Index" HREF="index.html" >
<LINK REL="made" HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Minimal%20patching%20vs.%20fixing%20the%20whole%20Universe&In-Reply-To=%3CBANLkTinH7Sh170Y--_-ndi2TtLgae%2BacVw%40mail.gmail.com%3E">
<META NAME="robots" CONTENT="index,nofollow">
<META http-equiv="Content-Type" content="text/html; charset=us-ascii">
<LINK REL="Previous" HREF="005934.html">
<LINK REL="Next" HREF="005938.html">
</HEAD>
<BODY BGCOLOR="#ffffff">
<H1>[Mageia-dev] Minimal patching vs. fixing the whole Universe</H1>
<B>Ahmad Samir</B>
<A HREF="mailto:mageia-dev%40mageia.org?Subject=Re%3A%20%5BMageia-dev%5D%20Minimal%20patching%20vs.%20fixing%20the%20whole%20Universe&In-Reply-To=%3CBANLkTinH7Sh170Y--_-ndi2TtLgae%2BacVw%40mail.gmail.com%3E"
TITLE="[Mageia-dev] Minimal patching vs. fixing the whole Universe">ahmadsamir3891 at gmail.com
</A><BR>
<I>Wed Jun 22 23:18:18 CEST 2011</I>
<P><UL>
<LI>Previous message: <A HREF="005934.html">[Mageia-dev] Minimal patching vs. fixing the whole Universe
</A></li>
<LI>Next message: <A HREF="005938.html">[Mageia-dev] Minimal patching vs. fixing the whole Universe
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5935">[ date ]</a>
<a href="thread.html#5935">[ thread ]</a>
<a href="subject.html#5935">[ subject ]</a>
<a href="author.html#5935">[ author ]</a>
</LI>
</UL>
<HR>
<!--beginarticle-->
<PRE>On 22 June 2011 23:14, Ahmad Samir <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">ahmadsamir3891 at gmail.com</A>> wrote:
><i> On 22 June 2011 22:47, Radu-Cristian FOTESCU <<A HREF="https://www.mageia.org/mailman/listinfo/mageia-dev">beranger5ca at yahoo.ca</A>> wrote:
</I>>><i> I'm known to be grumpy and difficult, but I also believe in simplicity as a policy, therefore I'd like to ask you something.
</I>>><i>
</I>>><i> By no means I want to question Ahmad's judgment, however I strongly disagree with him on one point. As a _principle_. Otherwise, it's a tiny punctual question, but I'd like to know Mageia's patching _policy_.
</I>>><i>
</I>>><i> See comments 50 and downwards:
</I>>><i>
</I>>><i> <A HREF="https://bugs.mageia.org/show_bug.cgi?id=1659#c50">https://bugs.mageia.org/show_bug.cgi?id=1659#c50</A>
</I>>><i>
</I>>><i> calibre-python2-env-fix.patch replaces
</I>>><i> '/usr/bin/env python2'
</I>>><i> with
</I>>><i> '/usr/bin/env python'
</I>>><i>
</I>>><i> The calibre developer has used '/usr/bin/env python' for ages, but relatively recently he has decided to switch to '/usr/bin/env python2' for fear that some distros would use Python 3 by default.
</I>>><i>
</I>>><i> Ahmad insists that '/usr/bin/python' should be used in Mageia.
</I>>><i>
</I>><i>
</I>><i> Actually, I said that the shebang should be removed altogether. Which
</I>><i> is what was being done all those years calibre existed in the Mandriva
</I>><i> repos (the same for Fedora, since they do remove the shebang, as the
</I>><i> calibre spec was originally imported from Fedora, which I said in the
</I>><i> report too).
</I>
Of course, or just /usr/bin/python. The /usr/bin/env way may be useful
for upstream when creating binary tarballs; but not for us we build
the package, and we know which version of python exists in the release
we're pushing it to.
Also, /usr/bin/python2 doesn't exist to begin with, as mikala pointed out.
><i>
</I>>><i> As long as '/usr/bin/env python' _works_, I see no point in trying to rewrite other people's work.
</I>>><i>
</I>>><i> I would say that the general principle should be to apply a _minimal_ patching, not to try to rewrite the work of the developers of hundreds of packages!
</I>>><i>
</I>>><i> A distro's job is not to judge the work of the _upstream_ developers as long as this is not a real bug.
</I>>><i>
</I>>><i> "Should" Mageia try to "fix" something that is not actually broken? There might be hundreds of packages with thousands and thousands of questionable decisions taken by the upstream developers -- however, why fixing something that works?
</I>>><i>
</I>>><i> You see, I hate conflicts (although I seem to be a maestro in generating them), but I also need simplicity and clear policies. Also, policies that can be applied. "Perfect" policies that would require the revision of hundreds of packages that actually work are not my cup of tea.
</I>>><i>
</I>>><i> Of course, I am _not_ a Mageia packager and this is not "my" package, but I'd like to know Mageia's policy wrt building packages. Normally, patches are not meant to optimize but to fix breakages. If the packagers are compelled to "improve" upstream's work, this can prove to be catastrophic in complex cases.
</I>>><i>
</I>>><i>
</I>>><i> Thank you,
</I>>><i> R-C aka beranger
</I>>><i>
</I>><i>
</I>><i>
</I>><i>
</I>><i> --
</I>><i> Ahmad Samir
</I>><i>
</I>
--
Ahmad Samir
</PRE>
<!--endarticle-->
<HR>
<P><UL>
<!--threads-->
<LI>Previous message: <A HREF="005934.html">[Mageia-dev] Minimal patching vs. fixing the whole Universe
</A></li>
<LI>Next message: <A HREF="005938.html">[Mageia-dev] Minimal patching vs. fixing the whole Universe
</A></li>
<LI> <B>Messages sorted by:</B>
<a href="date.html#5935">[ date ]</a>
<a href="thread.html#5935">[ thread ]</a>
<a href="subject.html#5935">[ subject ]</a>
<a href="author.html#5935">[ author ]</a>
</LI>
</UL>
<hr>
<a href="https://www.mageia.org/mailman/listinfo/mageia-dev">More information about the Mageia-dev
mailing list</a><br>
</body></html>
|
