summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Vignaud <tv@mageia.org>2012-08-26 23:05:43 +0000
committerThierry Vignaud <tv@mageia.org>2012-08-26 23:05:43 +0000
commitdf970846d15afad574014d9bb00212035d1cc4f7 (patch)
tree661745565d616e44a561f264458dad16faaaf53f
parent79cfa728dea726c404876d6430c0348f1dad767a (diff)
downloadurpmi-df970846d15afad574014d9bb00212035d1cc4f7.tar
urpmi-df970846d15afad574014d9bb00212035d1cc4f7.tar.gz
urpmi-df970846d15afad574014d9bb00212035d1cc4f7.tar.bz2
urpmi-df970846d15afad574014d9bb00212035d1cc4f7.tar.xz
urpmi-df970846d15afad574014d9bb00212035d1cc4f7.zip
(_installed_req_and_unreq_and_update_unrequested_list) only write
the unrequested package list file if the list actually changed (mga#7167)
-rw-r--r--NEWS1
-rw-r--r--urpm/orphans.pm5
2 files changed, 5 insertions, 1 deletions
diff --git a/NEWS b/NEWS
index f351f945..58c01d07 100644
--- a/NEWS
+++ b/NEWS
@@ -1,6 +1,7 @@
- unrequested package list management (for orphans) (mga#7167):
o do not wrongly tell we updated the unrequested package list when we didn't
(eg: when not having the proper rights such as running urpmq as !root)
+ o only write the unrequested package list file if the list actually changed
Version 7.4 - 24 August 2012
diff --git a/urpm/orphans.pm b/urpm/orphans.pm
index 9399f9e4..8f2553a6 100644
--- a/urpm/orphans.pm
+++ b/urpm/orphans.pm
@@ -100,8 +100,11 @@ sub _installed_req_and_unreq_and_update_unrequested_list {
my ($unreq, $req) = partition { $unrequested->{$_->name} } @$pkgs;
# update the list (to filter dups and now-removed-pkgs)
+ my @old = keys %$unrequested;
my @new = map { $_->name } @$unreq;
- _write_unrequested_list__file($urpm, \@new);
+ if (@new != @old) {
+ _write_unrequested_list__file($urpm, \@new);
+ }
($req, $unreq, $unrequested);
}