aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorChristophe Fergeau <cfergeau@mandriva.com>2009-03-23 10:03:37 +0000
committerChristophe Fergeau <cfergeau@mandriva.com>2009-03-23 10:03:37 +0000
commit6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e (patch)
tree44989b2271a3ddb274d4d763769af8a4ea7333e3
parent5cb38c21422b6b5ab63195e8dcba126bbc2a3b5c (diff)
downloadperl-URPM-6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e.tar
perl-URPM-6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e.tar.gz
perl-URPM-6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e.tar.bz2
perl-URPM-6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e.tar.xz
perl-URPM-6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e.zip
Don't silently install Suggests:, fixes bug #47934
When installing a package which suggests an uninstalled package, urpmi currently installs both packages without asking the user while it asks when installing a package which requires an uninstalled package. This is because we call resolve_requested__no_suggests to find which suggested package to install, but this mark the package as requested as well (and we don't ask for confirmation before installing a requested package). This patch calls resolve_requested__no_suggests_ (with a trailing '_') instead which is the same as resolve_requested__no_suggests but does not mark the packages as requested.
-rw-r--r--URPM/Resolve.pm2
1 files changed, 1 insertions, 1 deletions
diff --git a/URPM/Resolve.pm b/URPM/Resolve.pm
index 182f224..acea496 100644
--- a/URPM/Resolve.pm
+++ b/URPM/Resolve.pm
@@ -873,7 +873,7 @@ sub resolve_requested {
$urpm->{debug_URPM}("requested " . join(', ', keys %suggests) . " suggested by " . $pkg->fullname) if $urpm->{debug_URPM};
my %new_requested = map { $_ => undef } keys %suggests;
- my @new_selected = resolve_requested__no_suggests($urpm, $db, $state, \%new_requested, %options);
+ my @new_selected = resolve_requested__no_suggests_($urpm, $db, $state, \%new_requested, %options);
$state->{selected}{$_->id}{suggested} = 1 foreach @new_selected;
push @selected, @new_selected;
push @todo, @new_selected;