From 6d90b43320cecf65dcc100bfbe7c5a5ce23e8b2e Mon Sep 17 00:00:00 2001 From: Christophe Fergeau Date: Mon, 23 Mar 2009 10:03:37 +0000 Subject: Don't silently install Suggests:, fixes bug #47934 When installing a package which suggests an uninstalled package, urpmi currently installs both packages without asking the user while it asks when installing a package which requires an uninstalled package. This is because we call resolve_requested__no_suggests to find which suggested package to install, but this mark the package as requested as well (and we don't ask for confirmation before installing a requested package). This patch calls resolve_requested__no_suggests_ (with a trailing '_') instead which is the same as resolve_requested__no_suggests but does not mark the packages as requested. --- URPM/Resolve.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/URPM/Resolve.pm b/URPM/Resolve.pm index 182f224..acea496 100644 --- a/URPM/Resolve.pm +++ b/URPM/Resolve.pm @@ -873,7 +873,7 @@ sub resolve_requested { $urpm->{debug_URPM}("requested " . join(', ', keys %suggests) . " suggested by " . $pkg->fullname) if $urpm->{debug_URPM}; my %new_requested = map { $_ => undef } keys %suggests; - my @new_selected = resolve_requested__no_suggests($urpm, $db, $state, \%new_requested, %options); + my @new_selected = resolve_requested__no_suggests_($urpm, $db, $state, \%new_requested, %options); $state->{selected}{$_->id}{suggested} = 1 foreach @new_selected; push @selected, @new_selected; push @todo, @new_selected; -- cgit v1.2.1