summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorPascal Rigaux <pixel@mandriva.com>2001-08-09 17:11:08 +0000
committerPascal Rigaux <pixel@mandriva.com>2001-08-09 17:11:08 +0000
commite8584c676c588ee90ac28be9b163a1b99a41f8b3 (patch)
treebeab59c23402b42b0f0e078e715c7f0c8b0d4861
parent0f3e033a473b77939116ec49fdbb4d2b4201e3d3 (diff)
downloadperl_checker-e8584c676c588ee90ac28be9b163a1b99a41f8b3.tar
perl_checker-e8584c676c588ee90ac28be9b163a1b99a41f8b3.tar.gz
perl_checker-e8584c676c588ee90ac28be9b163a1b99a41f8b3.tar.bz2
perl_checker-e8584c676c588ee90ac28be9b163a1b99a41f8b3.tar.xz
perl_checker-e8584c676c588ee90ac28be9b163a1b99a41f8b3.zip
new check: never use ``length @l'', it returns the length of the string int(@l)
-rwxr-xr-xperl_checker4
1 files changed, 4 insertions, 0 deletions
diff --git a/perl_checker b/perl_checker
index 7dca3ba..d1cd082 100755
--- a/perl_checker
+++ b/perl_checker
@@ -55,6 +55,10 @@ s{([!=]~|\bif\b)\s*/.*?/}{}g;
s/#.*//;
+if (/\blength(\s*|\()\@/) {
+ err(q(never use ``length @l'', it returns the length of the string int(@l)), info());
+}
+
if (/\blocal\b.*\|\|=/) {
err(q(never use ``local $var ||= <val>'', write ``local $var = $var || <val>''), info());
}