diff options
author | Thierry Vignaud <tvignaud@mandriva.org> | 2003-02-26 11:13:12 +0000 |
---|---|---|
committer | Thierry Vignaud <tvignaud@mandriva.org> | 2003-02-26 11:13:12 +0000 |
commit | 305d63482ff4bcc26fa6e621103fb1626abee63f (patch) | |
tree | 1bfa15812a073f352d357d8572cdb01835d95afe /perl-install | |
parent | 2d5854c65795062a91709aa77fd20b5599859c50 (diff) | |
download | drakx-305d63482ff4bcc26fa6e621103fb1626abee63f.tar drakx-305d63482ff4bcc26fa6e621103fb1626abee63f.tar.gz drakx-305d63482ff4bcc26fa6e621103fb1626abee63f.tar.bz2 drakx-305d63482ff4bcc26fa6e621103fb1626abee63f.tar.xz drakx-305d63482ff4bcc26fa6e621103fb1626abee63f.zip |
- remove unused variable (hey perl_checker, why didn't you see it ?)
- (rename_field) better use the parameter we passed than relying on $_
be set to the right value in that context even if it was correct
Diffstat (limited to 'perl-install')
-rwxr-xr-x | perl-install/standalone/harddrake2 | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/perl-install/standalone/harddrake2 b/perl-install/standalone/harddrake2 index c826509de..902a2c4ef 100755 --- a/perl-install/standalone/harddrake2 +++ b/perl-install/standalone/harddrake2 @@ -179,7 +179,7 @@ my (%data, %configurators); $tree->append_column(my $pixcolumn = Gtk2::TreeViewColumn->new_with_attributes(undef, Gtk2::CellRendererPixbuf->new, 'pixbuf' => 0)); $tree->append_column(my $textcolumn = Gtk2::TreeViewColumn->new_with_attributes(undef, Gtk2::CellRendererText->new, 'text' => 1)); $tree->set_headers_visible(0); -my $selection = gtksignal_connect($tree->get_selection(), 'changed' => sub { +$tree->get_selection()->signal_connect('changed' => sub { my ($select) = @_; my ($model, $iter) = $select->get_selected(); if ($model) { @@ -324,12 +324,12 @@ sub strip_first_underscore { sub rename_field { my ($dev, $field, $new_field) = @_; - if ($_->{$field}) { - if ($_->{$new_field}) { - $_->{$new_field} .= " ($_->{$field})"; + if ($dev->{$field}) { + if ($dev->{$new_field}) { + $dev->{$new_field} .= " ($_->{$field})"; } else { - $_->{$new_field} = $_->{$field}; + $dev->{$new_field} = $_->{$field}; } - delete $_->{$field}; + delete $dev->{$field}; } } |