summaryrefslogtreecommitdiffstats
path: root/perl-install/printerdrake.pm
diff options
context:
space:
mode:
authorPascal Rigaux <pixel@mandriva.com>2002-11-06 16:47:00 +0000
committerPascal Rigaux <pixel@mandriva.com>2002-11-06 16:47:00 +0000
commit3021e910718c4702abe831c7aa53e8a7bf8b135f (patch)
treee342014ee05783e78a37b18970bd6168610c30f8 /perl-install/printerdrake.pm
parent371749c6a25c7aec0874e21d68ec212b2bf2dab7 (diff)
downloaddrakx-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar
drakx-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.gz
drakx-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.bz2
drakx-3021e910718c4702abe831c7aa53e8a7bf8b135f.tar.xz
drakx-3021e910718c4702abe831c7aa53e8a7bf8b135f.zip
please perl_checker:
- local'ize $_ before doing while (<...>) - use "foreach" instead of "for" - remove unneeded parentheses on the right side of infix if/foreach/unless
Diffstat (limited to 'perl-install/printerdrake.pm')
-rw-r--r--perl-install/printerdrake.pm6
1 files changed, 3 insertions, 3 deletions
diff --git a/perl-install/printerdrake.pm b/perl-install/printerdrake.pm
index b5c674702..32edbb867 100644
--- a/perl-install/printerdrake.pm
+++ b/perl-install/printerdrake.pm
@@ -177,7 +177,7 @@ sub detect {
sub first_time_dialog {
my ($printer, $in, $upNetwork) = @_;
- return 1 if (printer::get_default_spooler () or $::isInstall);
+ return 1 if printer::get_default_spooler () or $::isInstall;
# Wait message
my $w = $in->wait_message(N("Printerdrake"),
@@ -2452,7 +2452,7 @@ sub copy_queues_from {
@oldqueues = sort(@oldqueues);
$newspoolerstr = $printer::shortspooler_inv{$newspooler};
$oldspoolerstr = $printer::shortspooler_inv{$oldspooler};
- for (@oldqueues) {
+ foreach (@oldqueues) {
push (@queuesselected, 1);
push (@queueentries, { text => $_, type => 'bool',
val => \$queuesselected[$#queuesselected] });
@@ -2488,7 +2488,7 @@ Mark the printers which you want to transfer and click
\@queueentries
)) {
my $queuecopied = 0;
- for (@oldqueues) {
+ foreach (@oldqueues) {
if (shift(@queuesselected)) {
my $oldqueue = $_;
my $newqueue = $_;