summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Vignaud <tv@mageia.org>2013-03-05 18:32:53 +0000
committerThierry Vignaud <tv@mageia.org>2013-03-05 18:32:53 +0000
commitd74b382be74ecebdaa914b146e7b893d36d62d56 (patch)
treeeb7e86f35b517a58533e6d340d509b8e818d5a5c
parent2dc0a15c2041076cd8571d5c297da7ca8f560791 (diff)
downloaddrakx-d74b382be74ecebdaa914b146e7b893d36d62d56.tar
drakx-d74b382be74ecebdaa914b146e7b893d36d62d56.tar.gz
drakx-d74b382be74ecebdaa914b146e7b893d36d62d56.tar.bz2
drakx-d74b382be74ecebdaa914b146e7b893d36d62d56.tar.xz
drakx-d74b382be74ecebdaa914b146e7b893d36d62d56.zip
show all errors at once at end of installation
-rw-r--r--perl-install/install/NEWS1
-rw-r--r--perl-install/install/pkgs.pm7
2 files changed, 8 insertions, 0 deletions
diff --git a/perl-install/install/NEWS b/perl-install/install/NEWS
index de3679e51..26e591b1d 100644
--- a/perl-install/install/NEWS
+++ b/perl-install/install/NEWS
@@ -1,4 +1,5 @@
- include display_installer_help
+- show all errors at once at end of installation
Version 15.25 - 5 March 2013
diff --git a/perl-install/install/pkgs.pm b/perl-install/install/pkgs.pm
index c78234f34..d9d22dc05 100644
--- a/perl-install/install/pkgs.pm
+++ b/perl-install/install/pkgs.pm
@@ -856,6 +856,8 @@ sub _install_raw {
# bug present in 2009.0, 2008.1, 2008.0, ... (probably since r11141 aka when switching to rpm-4.2 in URPM-0.83)
local $packages->{options}{script_fd} = fileno $LOG;
+ start_pushing_error();
+
log::l("rpm transactions start");
my $exit_code = urpm::main_loop::run($packages, $packages->{state}, undef, undef, {
@@ -909,6 +911,11 @@ sub _install_raw {
N("Installation of packages failed:") . "\n\n" . join("\n", @$errors));
}
},
+ completed => sub {
+ if (!$packages->{options}{auto}) {
+ popup_errors();
+ }
+ },
message => sub {
my ($title, $message) = @_;
log::l($message);