summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThierry Vignaud <thierry.vignaud@gmail.com>2015-04-30 10:23:53 -0400
committerThierry Vignaud <thierry.vignaud@gmail.com>2016-01-02 14:52:17 +0100
commit70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a (patch)
treec0dccc93cb075f73af71f233fc905686449f0857
parentbed7645082c53a67ec5c6107fdb2c36e3a4483a6 (diff)
downloaddrakx-70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a.tar
drakx-70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a.tar.gz
drakx-70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a.tar.bz2
drakx-70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a.tar.xz
drakx-70e92f4e81a2f48c875a7d5ffa1e374ab10ac41a.zip
do not run shells uselessly
also prevent arguments to be split on spaces & the like
-rw-r--r--rescue/NEWS2
-rwxr-xr-xrescue/bin/guessmounts4
2 files changed, 4 insertions, 2 deletions
diff --git a/rescue/NEWS b/rescue/NEWS
index 9a15c388d..99beaff86 100644
--- a/rescue/NEWS
+++ b/rescue/NEWS
@@ -1,3 +1,5 @@
+- do not run shells uselessly
+
Version 1.53 - 28 September 2015 by Thierry Vignaud
- fix build with libified perl
diff --git a/rescue/bin/guessmounts b/rescue/bin/guessmounts
index 13ec2802e..07cd62ba3 100755
--- a/rescue/bin/guessmounts
+++ b/rescue/bin/guessmounts
@@ -135,9 +135,9 @@ if ($root) {
my $dev = fs::wild_device::from_part('', $_);
mkdir_p($where);
print STDERR "\t$dev on $where type $_->{fs_type} options $_->{options}\n";
- system("mount -t $_->{fs_type} $dev $where -o $_->{options}");
+ system('mount', '-t', $_->{fs_type}, $dev, $where, '-o', $_->{options});
}
- system("mount -t proc proc $target/proc");
+ system(qw(mount -t proc proc), "$target/proc");
foreach (qw(/dev /run /sys)) {
system('mount', '--bind', $_, "$target/$_");
}