diff options
| author | Pascal Rigaux <pixel@mandriva.com> | 2004-01-07 22:40:44 +0000 |
|---|---|---|
| committer | Pascal Rigaux <pixel@mandriva.com> | 2004-01-07 22:40:44 +0000 |
| commit | a4b490c073a71bfdcc1d8df8efae320899d3551d (patch) | |
| tree | b0f414db9926be93a3099e481e555a6ab8ea4ff7 | |
| parent | 246b7e545d74ec577209f4e9d5ce8f0f5acfb7c2 (diff) | |
| download | drakx-a4b490c073a71bfdcc1d8df8efae320899d3551d.tar drakx-a4b490c073a71bfdcc1d8df8efae320899d3551d.tar.gz drakx-a4b490c073a71bfdcc1d8df8efae320899d3551d.tar.bz2 drakx-a4b490c073a71bfdcc1d8df8efae320899d3551d.tar.xz drakx-a4b490c073a71bfdcc1d8df8efae320899d3551d.zip | |
logging when __DIE__ing is dangerous:
- in diskdrake, logging the error via c::syslog caused $@ to be undefined, causing the error to be dropped! (esp "you need to reboot")
- during install, no known error, but it's better to remove it anyway
(bye bye the "warning: ..." in ddebug.log, sniff)
| -rw-r--r-- | perl-install/install2.pm | 1 | ||||
| -rwxr-xr-x | perl-install/standalone/diskdrake | 2 |
2 files changed, 0 insertions, 3 deletions
diff --git a/perl-install/install2.pm b/perl-install/install2.pm index 05ff0e46f..0525ee8a2 100644 --- a/perl-install/install2.pm +++ b/perl-install/install2.pm @@ -321,7 +321,6 @@ sub start_i810fb() { #- MAIN #-###################################################################################### sub main { - $SIG{__DIE__} = sub { chomp(my $err = $_[0]); log::l("warning: ", ref($err) eq 'SCALAR' ? $$err : $err) if $err !~ /^find_index failed/ }; $SIG{SEGV} = sub { my $msg = "segmentation fault: seems like memory is missing as the install crashes"; print "$msg\n"; log::l($msg); $o->ask_warn('', $msg); diff --git a/perl-install/standalone/diskdrake b/perl-install/standalone/diskdrake index eaaf06dde..3ad23b5ef 100755 --- a/perl-install/standalone/diskdrake +++ b/perl-install/standalone/diskdrake @@ -71,8 +71,6 @@ if ($type eq 'fileshare') { my $all_hds = fsedit::get_hds({}, $in); -$SIG{__DIE__} = sub { my $m = formatError($_[0]); log::l("ERROR: $m") }; - fs::get_raw_hds('', $all_hds); fs::get_info_from_fstab($all_hds, ''); |