aboutsummaryrefslogtreecommitdiffstats
path: root/lib/Youri/Submit/Check/Rpmlint.pm
blob: 293f18eef9d977ed09f2890e948516c156c8e305 (plain)
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
# $Id: Rpmlint.pm 234384 2008-02-12 09:42:32Z blino $
package Youri::Submit::Check::Rpmlint;

=head1 NAME

Youri::Submit::Check::Rpmlint - Rpmlint-based check

=head1 DESCRIPTION

This check plugin wraps rpmlint, and reject packages triggering results
declared as fatal.

=cut

use warnings;
use strict;
use Carp;
use base qw/Youri::Submit::Check/;

=head2 new(%args)

Creates and returns a new Youri::Submit::Check::Rpmlint object.

Specific parameters:

=over

=item results $results

List of rpmlint result id considered as fatal.

=item path $path

Path to the rpmlint executable (default: /usr/bin/rpmlint)

=item config $config

Specific rpmlint configuration.

=back

=cut


sub _init {
    my $self   = shift;
    my %options = (
        results  => undef,
        path   => '/usr/bin/rpmlint',
        config => '',
        @_
    );


    $self->{opt} = sub {
	    my ($name, $target) = @_;
	    (exists $options{$target}->{$name}) ? $options{$target}->{$name} : $options{$name};
    };
}

sub run {
    my ($self, $package, $_repository, $_target, $_define) = @_;
    croak "Not a class method" unless ref $self;

    my @errors;

    my $results = $self->{opt}->('results', $_target);
    croak "rpmlint check: no results to check" unless $results;
    croak "rpmlint check: fatal should be an arrayref" unless ref $results eq 'ARRAY';
    $self->{_config} = $self->{opt}->('config', $_target);
    $self->{_path} = $self->{opt}->('path', $_target);
    $self->{_pattern} = '^(?:' . join('|', @$results) . ')$';
    my $command = "$self->{_path} -f $self->{_config} " . $package->as_file;
    open(my $RPMLINT, "$command |") or die "Can't run $command: $!";
    while (my $line = <$RPMLINT>) {
	$line =~ /^[EW]: \S+ (\S+)(.*)$/ # old rpmlint format
	  || $line =~ /^\S+: [EW]: (\S+)(.*)$/ or next; # new rpmlint format
        my ($id, $value) = ($1, $2);
        if ($id =~ /$self->{_pattern}/o) {
            push(@errors, "$id$value");
        }
    }

    return @errors;
}
=head1 COPYRIGHT AND LICENSE

Copyright (C) 2002-2006, YOURI project

This program is free software; you can redistribute it and/or modify it under
the same terms as Perl itself.

=cut

1;