merging dev with upstream

1 files changed, 13 insertions, 8 deletions

diff --git a/lib/Youri/Submit/Check/History.pm b/lib/Youri/Submit/Check/History.pm
index 82a1b05..326f2f1 100644
--- a/lib/Youri/Submit/Check/History.pm
+++ b/lib/Youri/Submit/Check/History.pm
@@ -1,9 +1,9 @@
 # $Id$
-package Youri::Upload::Check::History;
+package Youri::Submit::Check::History;
 
 =head1 NAME
 
-Youri::Upload::Check::History - Non-linear history check
+Youri::Submit::Check::History - Non-linear history check
 
 =head1 DESCRIPTION
 
@@ -16,19 +16,22 @@ use warnings;
 use strict;
 use Carp;
 use Youri::Package;
-use base qw/Youri::Upload::Check/;
+use base qw/Youri::Submit::Check/;
 
 sub run {
     my ($self, $package, $repository, $target, $define) = @_;
     croak "Not a class method" unless ref $self;
 
+    my @errors;
+
     my $last_revision =
         $repository->get_last_older_revision($package, $target, $define);
     
     if ($last_revision) {
         # skip the test if last revision has been produced from another source package, as it occurs during package split/merges
-        return 1
-            if $last_revision->get_canonical_name() ne $package->get_canonical_name();
+        return 
+            if $last_revision->get_canonical_name()
+            ne $package->get_canonical_name();
     
         my ($last_revision_number) = $last_revision->get_last_change()->[Youri::Package::CHANGE_AUTHOR] =~ /(\S+)\s*$/;
         my %entries =
@@ -37,12 +40,14 @@ sub run {
             map { $_->[Youri::Package::CHANGE_AUTHOR] }
             $package->get_changes();
         unless ($entries{$last_revision_number}) {
-            $self->{_error} = "Last changelog entry $last_revision_number from last revision " . $last_revision->get_full_name() . "  missing from current changelog";
-            return 0;
+            push(
+                @errors,
+                "Last changelog entry $last_revision_number from last revision " . $last_revision->get_full_name() . "  missing from current changelog"
+            );
         }
     }
 
-    return 1;
+    return @errors;
 }
 
 =head1 COPYRIGHT AND LICENSE