From c37220777b02f52592b16b81ccd43df1ab420c05 Mon Sep 17 00:00:00 2001
From: Dan Fandrich <dan@coneharvesters.com>
Date: Thu, 26 Mar 2020 23:32:09 +0100
Subject: Add more dependency icons and high error attributes separately.

---
 autobuild/results.php | 15 ++++++++++-----
 1 file changed, 10 insertions(+), 5 deletions(-)

(limited to 'autobuild/results.php')

diff --git a/autobuild/results.php b/autobuild/results.php
index 9a81622..7614237 100644
--- a/autobuild/results.php
+++ b/autobuild/results.php
@@ -254,19 +254,24 @@ foreach ($failure as $rpm => $error) {
 	if (is_flaky($history)) {
 		$history_link = $history_link . " <img src='icons/warning-flaky.png' title='Flaky build' />";
 	}
-	$language_link = "";
+	$attr_link = "";
 	if (!$fixed[$rpm]) {
 		$attributes = get_package_attributes($packageid);
 		if ($attributes) {
-			# Attributes are space separated words of the form "lang_php"
+			# Attributes are space separated words of the form "TYPE_SPECIFIER", e.g., "lang_php"
+			# Types are currently build (use of a particular build system),
+			# lang (use of a programming language) or err (a common build error).
 			foreach (explode(" ", $attributes) as $attr) {
 				$attrname = ucfirst(explode("_", $attr)[1]);
 				$icon_fn = "icons/" . str_replace("_", "-", $attr) . ".png";
 				if (file_exists($icon_fn)) {
-					$language_link = $language_link . " <img src='$icon_fn' " .
+					$attr_link = $attr_link . " <img src='$icon_fn' " .
 						"title='$attrname dependency' />";
+				} else if (substr($attr, 0, 4) === "err_") {
+					# TODO: create link into wiki with information about these errors
+					$attr_link = $attr_link . " [$attrname err]";
 				} else {
-					$language_link = $language_link . " [$attrname dep]";
+					$attr_link = $attr_link . " [$attrname dep]";
 				}
 			}
 		}
@@ -276,7 +281,7 @@ foreach ($failure as $rpm => $error) {
 	} else {
 		echo "<li>$error_html $rpm";
 	}
-	echo " $status_html $history_link$language_link</li>\n";
+	echo " $status_html $history_link$attr_link</li>\n";
 }
 $db->close();
 ?>
-- 
cgit v1.2.1