From 5e1db72532aa58991a9c1d7ddba6bc5dd45ae93c Mon Sep 17 00:00:00 2001 From: Cesar G Date: Mon, 3 Feb 2014 12:29:40 -0800 Subject: [ticket/12158] Add test data for 0 items to validate_start() test. PHPBB3-12158 --- tests/pagination/pagination_test.php | 19 +++++++++++++++++-- 1 file changed, 17 insertions(+), 2 deletions(-) (limited to 'tests') diff --git a/tests/pagination/pagination_test.php b/tests/pagination/pagination_test.php index 4e8083b47f..a96466347c 100644 --- a/tests/pagination/pagination_test.php +++ b/tests/pagination/pagination_test.php @@ -155,24 +155,39 @@ class phpbb_pagination_pagination_test extends phpbb_template_template_test_case public function validate_start_data() { return array( + array( + 0, + 0, + 0, + ), array( -1, + 20, + 0, + ), + array( + 20, + -30, 0, ), array( 0, + 20, 0, ), array( 10, + 20, 10, ), array( + 20, 20, 10, ), array( 30, + 20, 10, ), ); @@ -181,9 +196,9 @@ class phpbb_pagination_pagination_test extends phpbb_template_template_test_case /** * @dataProvider validate_start_data */ - public function test_validate_start($start, $expect) + public function test_validate_start($start, $num_items, $expect) { - $this->assertEquals($expect, $this->pagination->validate_start($start, 10, 20)); + $this->assertEquals($expect, $this->pagination->validate_start($start, 10, $num_items)); } public function reverse_start_data() -- cgit v1.2.1