From bca1b96b2e9235bbb4a3e7a104dd79e7f3761679 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 11 Apr 2015 16:41:20 +0200 Subject: [ticket/security-180] Make sure that redirect goes to full URL plus slash SECURITY-180 --- tests/security/redirect_test.php | 3 +++ 1 file changed, 3 insertions(+) (limited to 'tests/security') diff --git a/tests/security/redirect_test.php b/tests/security/redirect_test.php index 872a331dc7..46ec5c8edb 100644 --- a/tests/security/redirect_test.php +++ b/tests/security/redirect_test.php @@ -24,6 +24,9 @@ class phpbb_security_redirect_test extends phpbb_security_test_base array("http://localhost/phpBB/memberlist.php\n\rConnection: close", 'Tried to redirect to potentially insecure url.', false), array('javascript:test', false, 'http://localhost/phpBB/../javascript:test'), array('http://localhost/phpBB/index.php;url=', 'Tried to redirect to potentially insecure url.', false), + array('https://foobar.com\@http://localhost/phpBB', false, 'http://localhost/phpBB'), + array('https://foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), + array('http://localhost.foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), ); } -- cgit v1.2.1 From ee658bfe7bd284573d199c3c2a76007c5509695d Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Sat, 11 Apr 2015 17:08:28 +0200 Subject: [ticket/security-180] Always fail when redirecting to an insecure URL SECURITY-180 --- tests/security/redirect_test.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'tests/security') diff --git a/tests/security/redirect_test.php b/tests/security/redirect_test.php index 46ec5c8edb..9161bcbfe8 100644 --- a/tests/security/redirect_test.php +++ b/tests/security/redirect_test.php @@ -18,13 +18,13 @@ class phpbb_security_redirect_test extends phpbb_security_test_base { // array(Input -> redirect(), expected triggered error (else false), expected returned result url (else false)) return array( - array('data://x', false, 'http://localhost/phpBB'), + array('data://x', 'Tried to redirect to potentially insecure url.', false), array('bad://localhost/phpBB/index.php', 'Tried to redirect to potentially insecure url.', false), - array('http://www.otherdomain.com/somescript.php', false, 'http://localhost/phpBB'), + array('http://www.otherdomain.com/somescript.php', 'Tried to redirect to potentially insecure url.', false), array("http://localhost/phpBB/memberlist.php\n\rConnection: close", 'Tried to redirect to potentially insecure url.', false), array('javascript:test', false, 'http://localhost/phpBB/../javascript:test'), array('http://localhost/phpBB/index.php;url=', 'Tried to redirect to potentially insecure url.', false), - array('https://foobar.com\@http://localhost/phpBB', false, 'http://localhost/phpBB'), + array('https://foobar.com\@http://localhost/phpBB', 'Tried to redirect to potentially insecure url.', false), array('https://foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), array('http://localhost.foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), ); -- cgit v1.2.1 From 18fc621d73757ef793fba08f7da4e048b293a059 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Thu, 23 Apr 2015 15:27:30 +0200 Subject: [ticket/security-180] Add tests for redirecting to main URL SECURITY-180 --- tests/security/redirect_test.php | 2 ++ 1 file changed, 2 insertions(+) (limited to 'tests/security') diff --git a/tests/security/redirect_test.php b/tests/security/redirect_test.php index 9161bcbfe8..9a24ba5d65 100644 --- a/tests/security/redirect_test.php +++ b/tests/security/redirect_test.php @@ -27,6 +27,8 @@ class phpbb_security_redirect_test extends phpbb_security_test_base array('https://foobar.com\@http://localhost/phpBB', 'Tried to redirect to potentially insecure url.', false), array('https://foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), array('http://localhost.foobar.com\@localhost/troll/http://localhost/', 'Tried to redirect to potentially insecure url.', false), + array('http://localhost/phpBB', false, 'http://localhost/phpBB'), + array('http://localhost/phpBB/', false, 'http://localhost/phpBB/'), ); } -- cgit v1.2.1