From db5bff87157818e424e1717e3047606f53ca3807 Mon Sep 17 00:00:00 2001
From: Dhruv <dhruv.goel92@gmail.com>
Date: Wed, 5 Jun 2013 02:22:51 +0530
Subject: [ticket/10820] Add test cases More test cases to check against
 different versions

PHPBB3-10820
---
 tests/download/http_user_agent_test.php | 41 +++++++++++++++++++++++++++++----
 1 file changed, 37 insertions(+), 4 deletions(-)

(limited to 'tests/download/http_user_agent_test.php')

diff --git a/tests/download/http_user_agent_test.php b/tests/download/http_user_agent_test.php
index 179477f36a..166a186913 100644
--- a/tests/download/http_user_agent_test.php
+++ b/tests/download/http_user_agent_test.php
@@ -11,87 +11,120 @@ require_once dirname(__FILE__) . '/../../phpBB/includes/functions_download.php';
 
 class phpbb_download_http_user_agent_test extends phpbb_test_case
 {
-	public function user_agents_check_greater_ie7()
+	public function user_agents_check_greater_ie_version()
 	{
 		return array(
 			// user agent
+			// IE version
 			// expected
 			array(
 				'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)',
+				7,
 				true,
 			),
 			array(
 				'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)',
+				7,
 				true,
 			),
 			array(
 				'Mozilla/5.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB7.4; InfoPath.2; SV1; .NET CLR 3.3.69573; WOW64; en-US)',
+				7,
 				true,
 			),
 			array(
 				'Mozilla/5.0 (Windows; U; MSIE 7.0; Windows NT 6.0; en-US)',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/4.0 (compatible; MSIE 6.1; Windows XP; .NET CLR 1.1.4322; .NET CLR 2.0.50727)',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/4.0 (compatible; MSIE 6.01; Windows NT 6.0)',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/5.0 (Windows; U; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 2.0.50727)',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/5.0 (Windows NT 6.2; Win64; x64;) Gecko/20100101 Firefox/20.0',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/5.0 (Windows NT 6.2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/28.0.1464.0 Safari/537.36',
+				7,
 				false,
 			),
 			array(
 				'Googlebot-Image/1.0',
+				7,
 				false,
 			),
 			array(
 				'Googlebot/2.1 ( http://www.google.com/bot.html)',
+				7,
 				false,
 			),
 			array(
 				'Lynx/2.8.3dev.9 libwww-FM/2.14 SSL-MM/1.4.1 OpenSSL/0.9.6',
+				7,
 				false,
 			),
 			array(
 				'Links (0.9x; Linux 2.4.7-10 i686)',
+				7,
 				false,
 			),
 			array(
 				'Opera/9.60 (Windows NT 5.1; U; de) Presto/2.1.1',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/4.0 (compatible; MSIE 5.0; Windows NT;)',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/4.0 (compatible; MSIE 5.0; Windows NT 4.0) Opera 6.01 [en]',
+				7,
 				false,
 			),
 			array(
 				'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; en) Opera 9.24',
+				7,
+				false,
+			),
+			array(
+				'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)',
+				8,
+				true,
+			),
+			array(
+				'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)',
+				9,
+				true,
+			),
+			array(
+				'Mozilla/5.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB7.4; InfoPath.2; SV1; .NET CLR 3.3.69573; WOW64; en-US)',
+				10,
 				false,
 			),
 		);
 	}
 
 	/**
-	* @dataProvider user_agents_check_greater_ie7
+	* @dataProvider user_agents_check_greater_ie_version
 	*/
-	public function test_is_greater_ie7($user_agent, $expected)
+	public function test_is_greater_ie_version($user_agent, $version, $expected)
 	{
-		$this->assertEquals($expected, phpbb_is_greater_ie_version($user_agent, 7));
+		$this->assertEquals($expected, phpbb_is_greater_ie_version($user_agent, $version));
 	}
 }
-- 
cgit v1.2.1