From 6291bfaca94d104f1c85a0b139cab908e0793b3a Mon Sep 17 00:00:00 2001 From: Matt Friedman Date: Sat, 26 Mar 2016 12:59:23 -0700 Subject: [ticket/14561] Refactor tests PHPBB3-14561 --- tests/console/user/delete_test.php | 107 ++++++------------------------------- 1 file changed, 15 insertions(+), 92 deletions(-) (limited to 'tests/console/user/delete_test.php') diff --git a/tests/console/user/delete_test.php b/tests/console/user/delete_test.php index 5162358713..dc4c07e8b8 100644 --- a/tests/console/user/delete_test.php +++ b/tests/console/user/delete_test.php @@ -15,64 +15,27 @@ use Symfony\Component\Console\Application; use Symfony\Component\Console\Tester\CommandTester; use phpbb\console\command\user\delete; -class phpbb_console_command_user_delete_test extends phpbb_database_test_case -{ - protected $db; - protected $user; - protected $language; - protected $log; - protected $command_name; - protected $question; - protected $phpbb_root_path; - protected $php_ext; - - public function getDataSet() - { - return $this->createXMLDataSet(dirname(__FILE__) . '/fixtures/config.xml'); - } +require_once dirname(__FILE__) . '/base.php'; - public function setUp() +class phpbb_console_user_delete_test extends phpbb_console_user_base +{ + public function get_command_tester() { - global $db, $cache, $config, $user, $phpbb_dispatcher, $phpbb_container, $phpbb_root_path, $phpEx; - - $phpbb_dispatcher = new phpbb_mock_event_dispatcher(); - $phpbb_container = new phpbb_mock_container_builder(); - $phpbb_container->set('cache.driver', new phpbb_mock_cache()); - $phpbb_container->set('notification_manager', new phpbb_mock_notification_manager()); - - $cache = $phpbb_container->get('cache.driver'); - - $config = new \phpbb\config\config(array()); - - $db = $this->db = $this->new_dbal(); - - $this->language = $this->getMockBuilder('\phpbb\language\language') - ->disableOriginalConstructor() - ->getMock(); - $this->language->expects($this->any()) - ->method('lang') - ->will($this->returnArgument(0)); - $user = $this->user = $this->getMock('\phpbb\user', array(), array( + $application = new Application(); + $application->add(new delete( + $this->user, + $this->db, $this->language, - '\phpbb\datetime' + $this->log, + $this->phpbb_root_path, + $this->php_ext )); - $this->log = $this->getMockBuilder('\phpbb\log\log') - ->disableOriginalConstructor() - ->getMock(); - - $phpbb_container->set('auth.provider.db', new phpbb_mock_auth_provider()); - $provider_collection = new \phpbb\auth\provider_collection($phpbb_container, $config); - $provider_collection->add('auth.provider.db'); - $phpbb_container->set( - 'auth.provider_collection', - $provider_collection - ); - - $this->phpbb_root_path = $phpbb_root_path; - $this->php_ext = $phpEx; + $command = $application->find('user:delete'); + $this->command_name = $command->getName(); + $this->question = $command->getHelper('question'); - parent::setUp(); + return new CommandTester($command); } public function test_delete() @@ -126,44 +89,4 @@ class phpbb_console_command_user_delete_test extends phpbb_database_test_case $this->assertNotNull($this->get_user_id('Test')); } - - public function get_command_tester() - { - $application = new Application(); - $application->add(new delete( - $this->user, - $this->db, - $this->language, - $this->log, - $this->phpbb_root_path, - $this->php_ext - )); - - $command = $application->find('user:delete'); - $this->command_name = $command->getName(); - $this->question = $command->getHelper('question'); - - return new CommandTester($command); - } - - public function get_user_id($username) - { - $sql = 'SELECT user_id - FROM ' . USERS_TABLE . ' - WHERE ' . 'username = ' . "'" . $username . "'"; - $result = $this->db->sql_query($sql); - $row = $this->db->sql_fetchrow($result); - $this->db->sql_freeresult($result); - - return $row['user_id']; - } - - public function getInputStream($input) - { - $stream = fopen('php://memory', 'r+', false); - fputs($stream, $input); - rewind($stream); - - return $stream; - } } -- cgit v1.2.1