From aca19b4d0d77061f6502b3b48e239b10c927f785 Mon Sep 17 00:00:00 2001 From: "Paul S. Owen" Date: Sat, 23 Feb 2002 17:49:13 +0000 Subject: Fix SQL problem bug #520293 git-svn-id: file:///svn/phpbb/trunk@2202 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/privmsg.php | 26 ++++++++++++++++---------- 1 file changed, 16 insertions(+), 10 deletions(-) (limited to 'phpBB') diff --git a/phpBB/privmsg.php b/phpBB/privmsg.php index 422436047e..dda275ee4f 100644 --- a/phpBB/privmsg.php +++ b/phpBB/privmsg.php @@ -698,12 +698,15 @@ else if( ( $delete && $mark_list ) || $delete_all ) $update_pm_sql .= ( ( $update_pm_sql != "" ) ? ", " : "" ) . $row['privmsgs_to_userid']; } - $sql = "UPDATE " . USERS_TABLE . " - SET user_new_privmsg = user_new_privmsg - 1 - WHERE user_id IN ($update_pm_sql)"; - if ( !($result = $db->sql_query($sql)) ) + if ( $update_pm_sql != "" ) { - message_die(GENERAL_ERROR, "Couldn't update users new msg counters", "", __LINE__, __FILE__, $sql); + $sql = "UPDATE " . USERS_TABLE . " + SET user_new_privmsg = user_new_privmsg - 1 + WHERE user_id IN ($update_pm_sql)"; + if ( !($result = $db->sql_query($sql)) ) + { + message_die(GENERAL_ERROR, "Couldn't update users new msg counters", "", __LINE__, __FILE__, $sql); + } } $sql = "SELECT privmsgs_to_userid @@ -722,12 +725,15 @@ else if( ( $delete && $mark_list ) || $delete_all ) $update_pm_sql .= ( ( $update_pm_sql != "" ) ? ", " : "" ) . $row['privmsgs_to_userid']; } - $sql = "UPDATE " . USERS_TABLE . " - SET user_unread_privmsg = user_unread_privmsg - 1 - WHERE user_id IN ($update_pm_sql)"; - if ( !($result = $db->sql_query($sql)) ) + if ( $update_pm_sql != "" ) { - message_die(GENERAL_ERROR, "Couldn't update users new msg counters", "", __LINE__, __FILE__, $sql); + $sql = "UPDATE " . USERS_TABLE . " + SET user_unread_privmsg = user_unread_privmsg - 1 + WHERE user_id IN ($update_pm_sql)"; + if ( !($result = $db->sql_query($sql)) ) + { + message_die(GENERAL_ERROR, "Couldn't update users new msg counters", "", __LINE__, __FILE__, $sql); + } } } -- cgit v1.2.1