From 277e9a7a850165b002901926838d6cee1bec0f57 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Tue, 24 Jun 2014 18:49:31 +0200 Subject: [ticket/9801] Add viewonline_helper service to allow proper testing The viewonline_helper service can and will be extended in the future which will allow us to also test the viewonline page better. PHPBB3-9801 --- phpBB/phpbb/viewonline_helper.php | 37 +++++++++++++++++++++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 phpBB/phpbb/viewonline_helper.php (limited to 'phpBB/phpbb') diff --git a/phpBB/phpbb/viewonline_helper.php b/phpBB/phpbb/viewonline_helper.php new file mode 100644 index 0000000000..3aafbb2baf --- /dev/null +++ b/phpBB/phpbb/viewonline_helper.php @@ -0,0 +1,37 @@ + +* @license GNU General Public License, version 2 (GPL-2.0) +* +* For full copyright and license information, please see +* the docs/CREDITS.txt file. +* +*/ + +namespace phpbb; + +/** + * Class to handle viewonline related tasks + */ +class viewonline_helper +{ + /** + * Get user page + * + * @param string $session_page User's session page + * @return array Match array filled by preg_match() + */ + public function get_user_page($session_page) + { + preg_match('#^([./\\]*+[a-z0-9/_-]+)#i', $session_page, $on_page); + if (!sizeof($on_page)) + { + $on_page[1] = ''; + } + + return $on_page; + } +} -- cgit v1.2.1 From eb9321c3a1d2223ef2dc25671b6abbdd8b2df8ef Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Thu, 26 Jun 2014 12:29:54 +0200 Subject: [ticket/9801] Remove spaces before * in docblock PHPBB3-9801 --- phpBB/phpbb/viewonline_helper.php | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) (limited to 'phpBB/phpbb') diff --git a/phpBB/phpbb/viewonline_helper.php b/phpBB/phpbb/viewonline_helper.php index 3aafbb2baf..32b7e55f00 100644 --- a/phpBB/phpbb/viewonline_helper.php +++ b/phpBB/phpbb/viewonline_helper.php @@ -14,16 +14,16 @@ namespace phpbb; /** - * Class to handle viewonline related tasks - */ +* Class to handle viewonline related tasks +*/ class viewonline_helper { /** - * Get user page - * - * @param string $session_page User's session page - * @return array Match array filled by preg_match() - */ + * Get user page + * + * @param string $session_page User's session page + * @return array Match array filled by preg_match() + */ public function get_user_page($session_page) { preg_match('#^([./\\]*+[a-z0-9/_-]+)#i', $session_page, $on_page); -- cgit v1.2.1 From 330f21ab7605a4c327b68af630be5eaef5e2cd88 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Mon, 30 Jun 2014 21:36:11 +0200 Subject: [ticket/9801] Use empty instead of sizeof PHPBB3-9801 --- phpBB/phpbb/viewonline_helper.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/phpbb') diff --git a/phpBB/phpbb/viewonline_helper.php b/phpBB/phpbb/viewonline_helper.php index 32b7e55f00..3fc33119a3 100644 --- a/phpBB/phpbb/viewonline_helper.php +++ b/phpBB/phpbb/viewonline_helper.php @@ -27,7 +27,7 @@ class viewonline_helper public function get_user_page($session_page) { preg_match('#^([./\\]*+[a-z0-9/_-]+)#i', $session_page, $on_page); - if (!sizeof($on_page)) + if (empty($on_page)) { $on_page[1] = ''; } -- cgit v1.2.1