From 95a696c4daa7f481c71362f87d9b6c6cae34cbf4 Mon Sep 17 00:00:00 2001
From: mrgoldy <gijsmartens1@gmail.com>
Date: Sun, 5 May 2019 20:37:05 +0200
Subject: [ticket/16008] Properly order get_external_service_provider

PHPBB3-16008
---
 phpBB/phpbb/auth/provider/oauth/service/base.php             |  8 ++++----
 .../phpbb/auth/provider/oauth/service/service_interface.php  | 12 ++++++------
 2 files changed, 10 insertions(+), 10 deletions(-)

(limited to 'phpBB/phpbb')

diff --git a/phpBB/phpbb/auth/provider/oauth/service/base.php b/phpBB/phpbb/auth/provider/oauth/service/base.php
index 566b77202a..5ab426a0aa 100644
--- a/phpBB/phpbb/auth/provider/oauth/service/base.php
+++ b/phpBB/phpbb/auth/provider/oauth/service/base.php
@@ -44,16 +44,16 @@ abstract class base implements service_interface
 	/**
 	 * {@inheritdoc}
 	 */
-	public function set_external_service_provider(\OAuth\Common\Service\ServiceInterface $service_provider)
+	public function get_external_service_provider()
 	{
-		$this->service_provider = $service_provider;
+		return $this->service_provider;
 	}
 
 	/**
 	 * {@inheritdoc}
 	 */
-	public function get_external_service_provider()
+	public function set_external_service_provider(\OAuth\Common\Service\ServiceInterface $service_provider)
 	{
-		return $this->service_provider;
+		$this->service_provider = $service_provider;
 	}
 }
diff --git a/phpBB/phpbb/auth/provider/oauth/service/service_interface.php b/phpBB/phpbb/auth/provider/oauth/service/service_interface.php
index 8d92a3725e..ea9ef43788 100644
--- a/phpBB/phpbb/auth/provider/oauth/service/service_interface.php
+++ b/phpBB/phpbb/auth/provider/oauth/service/service_interface.php
@@ -72,16 +72,16 @@ interface service_interface
 	public function get_external_service_class();
 
 	/**
-	 * Sets the external library service provider
+	 * Returns the external library service provider once it has been set
 	 *
-	 * @param \OAuth\Common\Service\ServiceInterface	$service_provider
+	 * @param \OAuth\Common\Service\ServiceInterface|null
 	 */
-	public function set_external_service_provider(\OAuth\Common\Service\ServiceInterface $service_provider);
+	public function get_external_service_provider();
 
 	/**
-	 * Returns the external library service provider once it has been set
+	 * Sets the external library service provider
 	 *
-	 * @param \OAuth\Common\Service\ServiceInterface|null
+	 * @param \OAuth\Common\Service\ServiceInterface	$service_provider
 	 */
-	public function get_external_service_provider();
+	public function set_external_service_provider(\OAuth\Common\Service\ServiceInterface $service_provider);
 }
-- 
cgit v1.2.1