From 4ee05b1c17fa1be0c911c9d37e106f19b23ebac2 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Mon, 17 Nov 2014 00:33:51 +0100 Subject: [ticket/security-171] Add tests for retrieved remote data in version_helper SECURITY-171 --- phpBB/phpbb/version_helper.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'phpBB/phpbb') diff --git a/phpBB/phpbb/version_helper.php b/phpBB/phpbb/version_helper.php index 3c5f3efcf2..bcc67712e4 100644 --- a/phpBB/phpbb/version_helper.php +++ b/phpBB/phpbb/version_helper.php @@ -260,11 +260,14 @@ class version_helper $info = json_decode($info, true); // Sanitize any data we retrieve from a server - $json_sanitizer = function(&$value, $key) { - $type_cast_helper = new \phpbb\request\type_cast_helper(); - $type_cast_helper->set_var($value, $value, gettype($value), true); - }; - array_walk_recursive($info, $json_sanitizer); + if (!empty($info)) + { + $json_sanitizer = function (&$value, $key) { + $type_cast_helper = new \phpbb\request\type_cast_helper(); + $type_cast_helper->set_var($value, $value, gettype($value), true); + }; + array_walk_recursive($info, $json_sanitizer); + } if (empty($info['stable']) && empty($info['unstable'])) { -- cgit v1.2.1