From 73e6e5b77faadbb7676961bf38122d669de111db Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Thu, 3 Dec 2015 17:50:29 +0100 Subject: [ticket/13454] Remove unused variables This is the first part of the changes. More to come. PHPBB3-13454 --- phpBB/phpbb/textformatter/s9e/parser.php | 3 --- 1 file changed, 3 deletions(-) (limited to 'phpBB/phpbb/textformatter/s9e/parser.php') diff --git a/phpBB/phpbb/textformatter/s9e/parser.php b/phpBB/phpbb/textformatter/s9e/parser.php index ffaffbc63c..6470bb8245 100644 --- a/phpBB/phpbb/textformatter/s9e/parser.php +++ b/phpBB/phpbb/textformatter/s9e/parser.php @@ -50,7 +50,6 @@ class parser implements \phpbb\textformatter\parser_interface $this->dispatcher = $dispatcher; $this->parser = $parser; - $parser = $this; /** * Configure the parser service @@ -73,8 +72,6 @@ class parser implements \phpbb\textformatter\parser_interface */ public function parse($text) { - $parser = $this; - /** * Modify a text before it is parsed * -- cgit v1.2.1 From 38f36882177d25e58d5de41060d51f869a20f8d5 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Fri, 4 Dec 2015 14:03:43 +0100 Subject: [ticket/13454] Fix a few issues introduced by overdeleting stuff PHPBB3-13454 --- phpBB/phpbb/textformatter/s9e/parser.php | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'phpBB/phpbb/textformatter/s9e/parser.php') diff --git a/phpBB/phpbb/textformatter/s9e/parser.php b/phpBB/phpbb/textformatter/s9e/parser.php index 6470bb8245..39e91f037e 100644 --- a/phpBB/phpbb/textformatter/s9e/parser.php +++ b/phpBB/phpbb/textformatter/s9e/parser.php @@ -51,6 +51,8 @@ class parser implements \phpbb\textformatter\parser_interface $this->dispatcher = $dispatcher; $this->parser = $parser; + $parser = $this; + /** * Configure the parser service * @@ -72,6 +74,8 @@ class parser implements \phpbb\textformatter\parser_interface */ public function parse($text) { + $parser = $this; + /** * Modify a text before it is parsed * -- cgit v1.2.1 From 73900d1857a9a59eff82b224537a79110466ce7e Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 5 Dec 2015 16:07:14 +0100 Subject: [ticket/13454] Remove more unused variables This should be the last part. Off to checking if the changes were correct. PHPBB3-13454 --- phpBB/phpbb/textformatter/s9e/parser.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/phpbb/textformatter/s9e/parser.php') diff --git a/phpBB/phpbb/textformatter/s9e/parser.php b/phpBB/phpbb/textformatter/s9e/parser.php index 39e91f037e..e2653d60f0 100644 --- a/phpBB/phpbb/textformatter/s9e/parser.php +++ b/phpBB/phpbb/textformatter/s9e/parser.php @@ -196,7 +196,7 @@ class parser implements \phpbb\textformatter\parser_interface $errors = array(); foreach ($this->parser->getLogger()->get() as $entry) { - list($type, $msg, $context) = $entry; + list(, $msg, $context) = $entry; if ($msg === 'Tag limit exceeded') { -- cgit v1.2.1