From 5a320adc75faffe27d9d0b822e30106f1d27f2c2 Mon Sep 17 00:00:00 2001
From: Tristan Darricau <github@nicofuma.fr>
Date: Sun, 15 Jun 2014 22:03:39 +0200
Subject: [ticket/12724] Add Squiz.PHP.Eval in the legacy ruleset

PHPBB3-12724
---
 phpBB/install/index.php           |  4 ++++
 phpBB/install/install_convert.php | 14 ++++++++++++++
 2 files changed, 18 insertions(+)

(limited to 'phpBB/install')

diff --git a/phpBB/install/index.php b/phpBB/install/index.php
index 43970029cb..bff7b75b18 100644
--- a/phpBB/install/index.php
+++ b/phpBB/install/index.php
@@ -752,12 +752,16 @@ class module
 			break;
 
 			case 'select':
+				// @codingStandardsIgnoreStart
 				eval('$s_options = ' . str_replace('{VALUE}', $value, $options) . ';');
+				// @codingStandardsIgnoreEnd
 				$tpl = '<select id="' . $name . '" name="' . $name . '">' . $s_options . '</select>';
 			break;
 
 			case 'custom':
+				// @codingStandardsIgnoreStart
 				eval('$tpl = ' . str_replace('{VALUE}', $value, $options) . ';');
+				// @codingStandardsIgnoreEnd
 			break;
 
 			default:
diff --git a/phpBB/install/install_convert.php b/phpBB/install/install_convert.php
index 674a1f7dd3..4d6aff154c 100644
--- a/phpBB/install/install_convert.php
+++ b/phpBB/install/install_convert.php
@@ -1021,7 +1021,9 @@ class install_convert extends module
 			// Now process queries and execute functions that have to be executed prior to the conversion
 			if (!empty($convert->convertor['execute_first']))
 			{
+				// @codingStandardsIgnoreStart
 				eval($convert->convertor['execute_first']);
+				// @codingStandardsIgnoreEnd
 			}
 
 			if (!empty($convert->convertor['query_first']))
@@ -1091,7 +1093,9 @@ class install_convert extends module
 				// process execute_first and query_first for this table...
 				if (!empty($schema['execute_first']))
 				{
+					// @codingStandardsIgnoreStart
 					eval($schema['execute_first']);
+					// @codingStandardsIgnoreEnd
 				}
 
 				if (!empty($schema['query_first']))
@@ -1156,7 +1160,9 @@ class install_convert extends module
 			// it gets split because of time restrictions
 			if (!empty($schema['execute_always']))
 			{
+				// @codingStandardsIgnoreStart
 				eval($schema['execute_always']);
+				// @codingStandardsIgnoreEnd
 			}
 
 			//
@@ -1667,13 +1673,17 @@ class install_convert extends module
 			{
 				if (!is_array($convert->convertor['execute_last']))
 				{
+					// @codingStandardsIgnoreStart
 					eval($convert->convertor['execute_last']);
+					// @codingStandardsIgnoreEnd
 				}
 				else
 				{
 					while ($last_statement < sizeof($convert->convertor['execute_last']))
 					{
+						// @codingStandardsIgnoreStart
 						eval($convert->convertor['execute_last'][$last_statement]);
+						// @codingStandardsIgnoreEnd
 
 						$template->assign_block_vars('checks', array(
 							'TITLE'		=> $convert->convertor['execute_last'][$last_statement],
@@ -2035,7 +2045,9 @@ class install_convert extends module
 
 								$execution = str_replace('{RESULT}', '$value', $execution);
 								$execution = str_replace('{VALUE}', '$value', $execution);
+								// @codingStandardsIgnoreStart
 								eval($execution);
+								// @codingStandardsIgnoreEnd
 							}
 						}
 					}
@@ -2082,7 +2094,9 @@ class install_convert extends module
 
 								$execution = str_replace('{RESULT}', '$value', $execution);
 								$execution = str_replace('{VALUE}', '$value', $execution);
+								// @codingStandardsIgnoreStart
 								eval($execution);
+								// @codingStandardsIgnoreEnd
 							}
 						}
 					}
-- 
cgit v1.2.1