From 149f92896345b1fd873a814721b6e042a8681593 Mon Sep 17 00:00:00 2001
From: Meik Sievertsen <acydburn@phpbb.com>
Date: Tue, 28 Nov 2006 16:34:28 +0000
Subject: begin working on getting this thing a bit faster. I need to finish
 the other calls, this commit actually will break the diff engine and the
 updater. The speed increase noticed is from 89 seconds to 22 seconds as well
 as saving a lot of memory.

git-svn-id: file:///svn/phpbb/trunk@6692 89ea8834-ac86-4346-8a33-228a782c2dd0
---
 phpBB/install/install_update.php | 53 +++++++++++++++++++++++++++++++---------
 1 file changed, 42 insertions(+), 11 deletions(-)

(limited to 'phpBB/install/install_update.php')

diff --git a/phpBB/install/install_update.php b/phpBB/install/install_update.php
index 8bd94f036e..4a829f68dc 100644
--- a/phpBB/install/install_update.php
+++ b/phpBB/install/install_update.php
@@ -862,11 +862,19 @@ class install_update extends module
 		// Check for this circumstance, the new file need to be up-to-date with the current file then...
 		if (!file_exists($this->old_location . $original_file) && file_exists($this->new_location . $original_file) && file_exists($phpbb_root_path . $file))
 		{
+			$tmp = array(
+				'file1'		=> file_get_contents($this->new_location . $original_file),
+				'file2'		=> file_get_contents($phpbb_root_path . $file),
+			);
+
 			// We need to diff the contents here to make sure the file is really the one we expect
-			$diff = &new diff(file($this->new_location . $original_file), file($phpbb_root_path . $file));
+			$diff = &new diff($tmp['file1'], $tmp['file2']);
+			$empty = $diff->is_empty();
+
+			unset($tmp, $diff);
 
 			// if there are no differences we have an up-to-date file...
-			if ($diff->is_empty())
+			if ($empty)
 			{
 				$update_list['up_to_date'][] = $update_ary;
 				return;
@@ -883,16 +891,34 @@ class install_update extends module
 			trigger_error($user->lang['INCOMPLETE_UPDATE_FILES'], E_USER_ERROR);
 		}
 
-		$diff = &new diff(file($this->old_location . $original_file), file($phpbb_root_path . $file));
+		$tmp = array(
+			'file1'		=> file_get_contents($this->old_location . $original_file),
+			'file2'		=> file_get_contents($phpbb_root_path . $file),
+		);
+
+		// We need to diff the contents here to make sure the file is really the one we expect
+		$diff = &new diff($tmp['file1'], $tmp['file2']);
+		$empty_1 = $diff->is_empty();
+
+		unset($tmp, $diff);
+
+		$tmp = array(
+			'file1'		=> file_get_contents($this->new_location . $original_file),
+			'file2'		=> file_get_contents($phpbb_root_path . $file),
+		);
+
+		// We need to diff the contents here to make sure the file is really the one we expect
+		$diff = &new diff($tmp['file1'], $tmp['file2']);
+		$empty_2 = $diff->is_empty();
+
+		unset($tmp, $diff);
 
 		// If the file is not modified we are finished here...
-		if ($diff->is_empty())
+		if ($empty_1)
 		{
 			// Further check if it is already up to date - it could happen that non-modified files
 			// slip through
-			$diff = &new diff(file($this->new_location . $original_file), file($phpbb_root_path . $file));
-
-			if ($diff->is_empty())
+			if ($empty_2)
 			{
 				$update_list['up_to_date'][] = $update_ary;
 				return;
@@ -903,10 +929,9 @@ class install_update extends module
 		}
 
 		// If the file had been modified then we need to check if it is already up to date
-		$diff = &new diff(file($this->new_location . $original_file), file($phpbb_root_path . $file));
 
 		// if there are no differences we have an up-to-date file...
-		if ($diff->is_empty())
+		if ($empty_2)
 		{
 			$update_list['up_to_date'][] = $update_ary;
 			return;
@@ -922,10 +947,16 @@ class install_update extends module
 			return;
 		}
 
+		$tmp = array(
+			'file1'		=> file_get_contents($phpbb_root_path . $file),
+			'file2'		=> implode("\n", $diff->merged_output()),
+		);
+
 		// now compare the merged output with the original file to see if the modified file is up to date
-		$diff = &new diff(file($phpbb_root_path . $file), $diff->merged_output());
+		$diff = &new diff($tmp['file1'], $tmp['file2']);
+		$empty = $diff->is_empty();
 
-		if ($diff->is_empty())
+		if ($empty)
 		{
 			$update_list['up_to_date'][] = $update_ary;
 			return;
-- 
cgit v1.2.1