From 6872104aa95a9f2aad565189e25bbf54abc3ca2c Mon Sep 17 00:00:00 2001
From: Oleg Pudeyev <oleg@bsdpower.com>
Date: Wed, 5 Dec 2012 00:07:01 -0500
Subject: [ticket/11162] Account for notify_status.

PHPBB3-11162
---
 phpBB/includes/functions_tricky_update.php | 111 ++++++++++++++++++++++++++++-
 1 file changed, 108 insertions(+), 3 deletions(-)

(limited to 'phpBB/includes')

diff --git a/phpBB/includes/functions_tricky_update.php b/phpBB/includes/functions_tricky_update.php
index a5b9fdacd0..cf922d7014 100644
--- a/phpBB/includes/functions_tricky_update.php
+++ b/phpBB/includes/functions_tricky_update.php
@@ -20,7 +20,7 @@ if (!defined('IN_PHPBB'))
 * If this results in rows violating uniqueness constraints, the duplicate
 * rows are eliminated.
 *
-* The only supported tables are bookmarks and topics_watch.
+* The only supported table is bookmarks.
 *
 * @param dbal $db Database object
 * @param string $table Table on which to perform the update
@@ -67,7 +67,7 @@ function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_value
 		if (empty($new_user_ids))
 		{
 			$sql = "UPDATE $table
-				SET $column = " . (int) $to_value. "
+				SET $column = " . (int) $to_value . "
 				WHERE $column = '" . $db->sql_escape($from_value) . "'";
 			$queries[] = $sql;
 		}
@@ -77,7 +77,7 @@ function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_value
 			if (!empty($different_user_ids))
 			{
 				$sql = "UPDATE $table
-					SET $column = " . (int) $to_value. "
+					SET $column = " . (int) $to_value . "
 					WHERE $column = '" . $db->sql_escape($from_value) . "'
 					AND " . $db->sql_in_set('user_id', $different_user_ids);
 				$queries[] = $sql;
@@ -101,3 +101,108 @@ function phpbb_update_rows_avoiding_duplicates($db, $table, $column, $from_value
 		$db->sql_transaction('commit');
 	}
 }
+
+/**
+* Updates rows in given table from a set of values to a new value.
+* If this results in rows violating uniqueness constraints, the duplicate
+* rows are merged respecting notify_status (0 takes precedence over 1).
+*
+* The only supported table is topics_watch.
+*
+* @param dbal $db Database object
+* @param string $table Table on which to perform the update
+* @param string $column Column whose values to change
+* @param array $from_values An array of values that should be changed
+* @param int $to_value The new value
+* @return null
+*/
+function phpbb_update_rows_avoiding_duplicates_notify_status($db, $table, $column, $from_values, $to_value)
+{
+	$sql = "SELECT $column, user_id, notify_status
+		FROM $table
+		WHERE " . $db->sql_in_set($column, $from_values);
+	$result = $db->sql_query($sql);
+
+	$old_user_ids = array();
+	while ($row = $db->sql_fetchrow($result))
+	{
+		$old_user_ids[(int) $row['notify_status']][$row[$column]][] = $row['user_id'];
+	}
+	$db->sql_freeresult($result);
+
+	$sql = "SELECT $column, user_id
+		FROM $table
+		WHERE $column = '" . (int) $to_value . "'";
+	$result = $db->sql_query($sql);
+
+	$new_user_ids = array();
+	while ($row = $db->sql_fetchrow($result))
+	{
+		$new_user_ids[$row[$column]][] = $row['user_id'];
+	}
+	$db->sql_freeresult($result);
+
+	$queries = array();
+	$any_found = false;
+	$extra_updates = array(
+		0 => 'notify_status = 0',
+		1 => '',
+	);
+	foreach ($from_values as $from_value)
+	{
+		foreach ($extra_updates as $notify_status => $extra_update) {
+			if (!isset($old_user_ids[$notify_status][$from_value]))
+			{
+				continue;
+			}
+			$any_found = true;
+			if (empty($new_user_ids))
+			{
+				$sql = "UPDATE $table
+					SET $column = " . (int) $to_value . "
+					WHERE $column = '" . $db->sql_escape($from_value) . "'";
+				$queries[] = $sql;
+			}
+			else
+			{
+				$different_user_ids = array_diff($old_user_ids[$notify_status][$from_value], $new_user_ids[$to_value]);
+				if (!empty($different_user_ids))
+				{
+					$sql = "UPDATE $table
+						SET $column = " . (int) $to_value . "
+						WHERE $column = '" . $db->sql_escape($from_value) . "'
+						AND " . $db->sql_in_set('user_id', $different_user_ids);
+					$queries[] = $sql;
+				}
+				
+				if ($extra_update) {
+					$same_user_ids = array_diff($old_user_ids[$notify_status][$from_value], $different_user_ids);
+					if (!empty($same_user_ids))
+					{
+						$sql = "UPDATE $table
+							SET $extra_update
+							WHERE $column = '" . (int) $to_value . "'
+							AND " . $db->sql_in_set('user_id', $same_user_ids);
+						$queries[] = $sql;
+					}
+				}
+			}
+		}
+	}
+
+	if ($any_found)
+	{
+		$db->sql_transaction('begin');
+
+		foreach ($queries as $sql)
+		{
+			$db->sql_query($sql);
+		}
+
+		$sql = "DELETE FROM $table
+			WHERE " . $db->sql_in_set($column, $from_values);
+		$db->sql_query($sql);
+
+		$db->sql_transaction('commit');
+	}
+}
-- 
cgit v1.2.1