From 7b428641f04766ea8711cb47e76bbe2b52638abe Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Thu, 14 Nov 2019 21:32:50 +0100 Subject: [ticket/16211] Prevent skipping COPPA via URL parameter PHPBB3-16211 --- phpBB/includes/ucp/ucp_register.php | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) (limited to 'phpBB/includes') diff --git a/phpBB/includes/ucp/ucp_register.php b/phpBB/includes/ucp/ucp_register.php index 54e418d58c..29829c2e68 100644 --- a/phpBB/includes/ucp/ucp_register.php +++ b/phpBB/includes/ucp/ucp_register.php @@ -40,6 +40,7 @@ class ucp_register } $coppa = $request->is_set('coppa') ? (int) $request->variable('coppa', false) : false; + $token = $request->variable('hash', ''); $agreed = $request->variable('agreed', false); $submit = $request->is_set_post('submit'); $change_lang = $request->variable('change_lang', ''); @@ -50,6 +51,11 @@ class ucp_register $agreed = false; } + if ($coppa !== false && !check_link_hash($token, 'coppa') && !check_form_key('ucp_register')) + { + $coppa = false; + } + /** * Add UCP register data before they are assigned to the template or submitted * @@ -164,13 +170,15 @@ class ucp_register ->format($user->lang['DATE_FORMAT'], true); unset($now); + $coppa_link_hash = '&hash=' . generate_link_hash('coppa'); + $template_vars = array( 'S_LANG_OPTIONS' => (count($lang_row) > 1) ? language_select($user_lang) : '', 'L_COPPA_NO' => sprintf($user->lang['UCP_COPPA_BEFORE'], $coppa_birthday), 'L_COPPA_YES' => sprintf($user->lang['UCP_COPPA_ON_AFTER'], $coppa_birthday), - 'U_COPPA_NO' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=0'), - 'U_COPPA_YES' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=1'), + 'U_COPPA_NO' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=0' . $coppa_link_hash), + 'U_COPPA_YES' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=1' . $coppa_link_hash), 'S_SHOW_COPPA' => true, 'S_HIDDEN_FIELDS' => build_hidden_fields($s_hidden_fields), -- cgit v1.2.1 From 417271f5738b0a73bc3dba28f516675ca3d146ea Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Wed, 27 Nov 2019 22:01:26 +0100 Subject: [ticket/16211] Use form to ensure link data is passed on coppa registration PHPBB3-16211 --- phpBB/includes/ucp/ucp_register.php | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) (limited to 'phpBB/includes') diff --git a/phpBB/includes/ucp/ucp_register.php b/phpBB/includes/ucp/ucp_register.php index 29829c2e68..03ac63b12b 100644 --- a/phpBB/includes/ucp/ucp_register.php +++ b/phpBB/includes/ucp/ucp_register.php @@ -39,8 +39,8 @@ class ucp_register trigger_error('UCP_REGISTER_DISABLE'); } - $coppa = $request->is_set('coppa') ? (int) $request->variable('coppa', false) : false; - $token = $request->variable('hash', ''); + $coppa = $request->is_set('coppa_yes') ? 1 : ($request->is_set('coppa_no') ? 0 : false); + $coppa = $request->is_set('coppa') ? $request->variable('coppa', 0) : $coppa; $agreed = $request->variable('agreed', false); $submit = $request->is_set_post('submit'); $change_lang = $request->variable('change_lang', ''); @@ -51,7 +51,7 @@ class ucp_register $agreed = false; } - if ($coppa !== false && !check_link_hash($token, 'coppa') && !check_form_key('ucp_register')) + if ($coppa !== false && !check_form_key('ucp_register')) { $coppa = false; } @@ -170,15 +170,10 @@ class ucp_register ->format($user->lang['DATE_FORMAT'], true); unset($now); - $coppa_link_hash = '&hash=' . generate_link_hash('coppa'); - $template_vars = array( 'S_LANG_OPTIONS' => (count($lang_row) > 1) ? language_select($user_lang) : '', - 'L_COPPA_NO' => sprintf($user->lang['UCP_COPPA_BEFORE'], $coppa_birthday), - 'L_COPPA_YES' => sprintf($user->lang['UCP_COPPA_ON_AFTER'], $coppa_birthday), - - 'U_COPPA_NO' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=0' . $coppa_link_hash), - 'U_COPPA_YES' => append_sid("{$phpbb_root_path}ucp.$phpEx", 'mode=register&coppa=1' . $coppa_link_hash), + 'L_COPPA_NO' => $user->lang('UCP_COPPA_BEFORE', $coppa_birthday), + 'L_COPPA_YES' => $user->lang('UCP_COPPA_ON_AFTER', $coppa_birthday), 'S_SHOW_COPPA' => true, 'S_HIDDEN_FIELDS' => build_hidden_fields($s_hidden_fields), -- cgit v1.2.1