From 8d12838aedeaa23cccf128e98e93d05507edda4d Mon Sep 17 00:00:00 2001 From: Joas Schilling Date: Mon, 14 Feb 2011 16:09:09 +0100 Subject: [ticket/9549] Make the class non static and extend delete_group function. delete_group() can now be used, so it does not update the actual group. This can save a query, when you update the group anyway. PHPBB3-9549 --- phpBB/includes/acp/acp_groups.php | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) (limited to 'phpBB/includes/acp') diff --git a/phpBB/includes/acp/acp_groups.php b/phpBB/includes/acp/acp_groups.php index 5e6ebcaa7d..015be3c30e 100644 --- a/phpBB/includes/acp/acp_groups.php +++ b/phpBB/includes/acp/acp_groups.php @@ -819,6 +819,10 @@ class acp_groups // Invalid mode trigger_error($user->lang['NO_MODE'] . adm_back_link($this->u_action), E_USER_WARNING); } + else if ($field) + { + $group_position = new phpbb_group_positions($db, $field); + } switch ($action) { @@ -826,26 +830,25 @@ class acp_groups set_config('legend_sort_groupname', request_var('legend_sort_groupname', 0)); break; - case 'set_config_teampage': set_config('teampage_forums', request_var('teampage_forums', 0)); set_config('teampage_multiple', request_var('teampage_multiple', 0)); break; case 'add': - phpbb_group_positions::add_group($field, $group_id); + $group_position->add_group($group_id); break; case 'delete': - phpbb_group_positions::delete_group($field, $group_id); + $group_position->delete_group($group_id); break; case 'move_up': - phpbb_group_positions::move_up($field, $group_id); + $group_position->move_up($group_id); break; case 'move_down': - phpbb_group_positions::move_down($field, $group_id); + $group_position->move_down($group_id); break; } -- cgit v1.2.1