From 16a163662bf463d7fa2195e73832e8bf4a26a06f Mon Sep 17 00:00:00 2001
From: 3D-I <480857+3D-I@users.noreply.github.com>
Date: Sun, 22 Dec 2019 17:44:03 +0100
Subject: [ticket/16260] Missing check whether the index exists in ACP - PHP
 7.4

PHPBB3-16260
---
 phpBB/includes/acp/acp_board.php | 18 +++++++++++-------
 1 file changed, 11 insertions(+), 7 deletions(-)

(limited to 'phpBB/includes/acp')

diff --git a/phpBB/includes/acp/acp_board.php b/phpBB/includes/acp/acp_board.php
index b0cefbd064..2285ac997e 100644
--- a/phpBB/includes/acp/acp_board.php
+++ b/phpBB/includes/acp/acp_board.php
@@ -530,15 +530,19 @@ class acp_board
 
 			if ($submit)
 			{
-				if (strpos(isset($data['type']) ? $data['type'] : '', 'password') === 0 && $config_value === '********')
+				if (isset($data['type']))
 				{
-					/**
-					 * Do not update password fields if the content is ********,
-					 * because that is the password replacement we use to not
-					 * send the password to the output
-					 */
-					continue;
+					if (strpos($data['type'], 'password') === 0 && $config_value === '********')
+					{
+						/**
+						 * Do not update password fields if the content is ********,
+						 * because that is the password replacement we use to not
+						 * send the password to the output
+						 */
+						continue;
+					}
 				}
+
 				$config->set($config_name, $config_value);
 
 				if ($config_name == 'allow_quick_reply' && isset($_POST['allow_quick_reply_enable']))
-- 
cgit v1.2.1