From 5b61ac06cbb065d0e5d6c0c108ead96cea0c3333 Mon Sep 17 00:00:00 2001 From: Marc Alexander Date: Sat, 2 Apr 2016 09:46:54 +0200 Subject: [ticket/14577] Do not calculate size of array in for loop For loops that modify the size of the looped arrays were obviously not changed. PHPBB3-14577 --- phpBB/includes/acp/acp_modules.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'phpBB/includes/acp/acp_modules.php') diff --git a/phpBB/includes/acp/acp_modules.php b/phpBB/includes/acp/acp_modules.php index ea6b388328..55ea26b9d3 100644 --- a/phpBB/includes/acp/acp_modules.php +++ b/phpBB/includes/acp/acp_modules.php @@ -888,7 +888,7 @@ class acp_modules $diff = sizeof($moved_modules) * 2; $moved_ids = array(); - for ($i = 0; $i < sizeof($moved_modules); ++$i) + for ($i = 0, $size = sizeof($moved_modules); $i < $size; ++$i) { $moved_ids[] = $moved_modules[$i]['module_id']; } -- cgit v1.2.1