From 19a36ed364ffdc4da784a253baa8aa2a8ac6845a Mon Sep 17 00:00:00 2001 From: Meik Sievertsen Date: Sun, 28 May 2006 19:15:24 +0000 Subject: - adjusted coding guidelines - fixed custom bbcode {TEXT} token - added unapproved item/info for unapproved posts in a topic git-svn-id: file:///svn/phpbb/trunk@5982 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/docs/coding-guidelines.html | 43 ++++++++++++++++----------------------- 1 file changed, 17 insertions(+), 26 deletions(-) (limited to 'phpBB/docs/coding-guidelines.html') diff --git a/phpBB/docs/coding-guidelines.html b/phpBB/docs/coding-guidelines.html index 803d88ebc2..3f15f22a55 100644 --- a/phpBB/docs/coding-guidelines.html +++ b/phpBB/docs/coding-guidelines.html @@ -348,7 +348,7 @@ class ...

2. Code Layout/Guidelines

-

Please note that these Guidelines also applies to js code.

+

Please note that these Guidelines also applies to javascript code.

2.i. Variable/Function Naming

@@ -691,6 +691,7 @@ switch ($mode) } + Top

@@ -892,10 +893,21 @@ trigger_error('NO_FORUM');

All urls pointing to internal files need to be prepended by the $phpbb_root_path variable. Within the administration control panel all urls pointing to internal files need to be prepended by the $phpbb_admin_path variable. This makes sure the path is always correct and users being able to just rename the admin folder and the acp still working as intended.

-

General Functions:

-

Use sizeof instead of count, this is just a general preference and guideline and has no other benefit than to be consistent.

+

General function usage:

-

Use strpos instead of strstr.

+

Some of these functions are only chosen over others because of a personal preference and are having no other benefit than to be consistant over the code.

+ + Top @@ -1158,33 +1170,12 @@ markup

5. Guidelines Changelog

-

Revision 1.7

- - - -

Revision 1.6

- - -

Revision 1.5

-

Revision 1.3

- -
Top -- cgit v1.2.1