From 01b41453812dc7b990f03b81f85dcfb9a18076fd Mon Sep 17 00:00:00 2001 From: Meik Sievertsen Date: Sun, 11 Jun 2006 18:13:52 +0000 Subject: - fixed a few bugs - added user_add() function - check posted images ([img]) for same domain/scipt and php files - auth_api.html updated to the coding guidelines look&feel - introduced ability to force non page-updates (cron is using it) - correctly resend coppa email git-svn-id: file:///svn/phpbb/trunk@6048 89ea8834-ac86-4346-8a33-228a782c2dd0 --- phpBB/docs/coding-guidelines.html | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) (limited to 'phpBB/docs/coding-guidelines.html') diff --git a/phpBB/docs/coding-guidelines.html b/phpBB/docs/coding-guidelines.html index 3f15f22a55..5510a28b78 100644 --- a/phpBB/docs/coding-guidelines.html +++ b/phpBB/docs/coding-guidelines.html @@ -184,13 +184,14 @@ body {

Coding Guidelines

    -
  1. Defaults
    2. +
  2. Defaults
    1. Editor Settings
    2. File Header
    3. File Locations
    -
  3. Code Layout/Guidelines
    4. + +
  4. Code Layout/Guidelines
    1. Variable/Function Naming
    2. Code Layout
      3. @@ -198,6 +199,7 @@ body {
    3. Optimizations
    4. General Guidelines
    +
  5. Styling
  6. Templating
  7. Guidelines Changelog
    8. @@ -218,7 +220,7 @@ body { 
     $mode{TAB}{TAB}= request_var('mode', '');
 $search_id{TAB}= request_var('search_id', '');
-
    +

    If entered with tabs (replace the {TAB}) both equal signs need to be on the same column.

    @@ -853,15 +855,15 @@ $submit = (isset($_POST['submit'])) ? true : false; $start = request_var('start', '0'); -

    // Getting an array, keys are integers, value defaults to 0 +

    // Getting an array, keys are integers, value defaults to 0

     $mark_array = request_var('mark', array(0));
-
    + -

    // Getting an array, keys are strings, value defaults to 0 +

    // Getting an array, keys are strings, value defaults to 0

     $action_ary = request_var('action', array('' => 0));
-
    +

    Login checks/redirection:

    To show a forum login box use login_forum_box($forum_data), else use the login_box() function.

    @@ -918,7 +920,6 @@ trigger_error('NO_FORUM');

    3. Styling

    -

    General things

    Templates should be produced in a consistent manner. Where appropriate they should be based off an existing copy, e.g. index, viewforum or viewtopic (the combination of which implement a range of conditional and variable forms).

    -- cgit v1.2.1