From b73b9f1dec0f5f063808980684ba98020dc8974f Mon Sep 17 00:00:00 2001
From: Joas Schilling <nickvergessen@gmx.de>
Date: Sun, 3 May 2015 12:58:30 +0200
Subject: [ticket/13809] Perform the lint test prior to normal tests

PHPBB3-13809
---
 .travis.yml                      | 1 +
 travis/phpunit-mysqli-travis.xml | 3 ---
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/.travis.yml b/.travis.yml
index e68ba5f501..2542898324 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -46,6 +46,7 @@ script:
   - travis/check-sami-parse-errors.sh $DB $TRAVIS_PHP_VERSION
   - travis/check-image-icc-profiles.sh $DB $TRAVIS_PHP_VERSION
   - travis/check-executable-files.sh $DB $TRAVIS_PHP_VERSION ./
+  - sh -c "if [ '$SLOWTESTS' != '1' -a '$DB' = 'mysqli' ]; then phpBB/vendor/bin/phpunit tests/lint_test.php; fi"
   - sh -c "if [ '$SLOWTESTS' != '1' ]; then phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml; fi"
   - sh -c "if [ '$SLOWTESTS' = '1' ]; then phpBB/vendor/bin/phpunit --configuration travis/phpunit-$DB-travis.xml --group slow; fi"
   - sh -c "if [ '$TRAVIS_PHP_VERSION' = '5.3.3' -a '$DB' = 'mysqli' -a '$TRAVIS_PULL_REQUEST' != 'false' ]; then git-tools/commit-msg-hook-range.sh origin/$TRAVIS_BRANCH..FETCH_HEAD; fi"
diff --git a/travis/phpunit-mysqli-travis.xml b/travis/phpunit-mysqli-travis.xml
index 4c963895fc..b12ae6fe8b 100644
--- a/travis/phpunit-mysqli-travis.xml
+++ b/travis/phpunit-mysqli-travis.xml
@@ -18,9 +18,6 @@
 			<exclude>../tests/lint_test.php</exclude>
 			<exclude>../tests/ui</exclude>
 		</testsuite>
-		<testsuite name="phpBB Lint Test">
-			<file>../tests/lint_test.php</file>
-		</testsuite>
 		<testsuite name="phpBB Functional Tests">
 			<directory suffix="_test.php" phpVersion="5.3.19" phpVersionOperator=">=">../tests/functional</directory>
 		</testsuite>
-- 
cgit v1.2.1


From 923fdb0aa094f8d4957b0ad36f7ea32ad2323042 Mon Sep 17 00:00:00 2001
From: Joas Schilling <nickvergessen@gmx.de>
Date: Sun, 3 May 2015 14:35:04 +0200
Subject: [ticket/13809] Test each file individually

PHPBB3-13809
---
 tests/lint_test.php | 49 ++++++++++++++++++++++++++++---------------------
 1 file changed, 28 insertions(+), 21 deletions(-)

diff --git a/tests/lint_test.php b/tests/lint_test.php
index 9fb1c7624c..fb43196bae 100644
--- a/tests/lint_test.php
+++ b/tests/lint_test.php
@@ -38,31 +38,34 @@ class phpbb_lint_test extends phpbb_test_case
 				self::markTestSkipped(sprintf('Could not run PHP_BINARY %s. Output: %s', self::$php_binary, $output));
 			}
 		}
-
-		self::$exclude = array(
-			dirname(__FILE__) . '/../.git',
-			dirname(__FILE__) . '/../build/new_version',
-			dirname(__FILE__) . '/../build/old_versions',
-			dirname(__FILE__) . '/../phpBB/cache',
-			// PHP Fatal error:  Cannot declare class Container because the name is already in use in /var/www/projects/phpbb3/tests/../phpBB/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
-			// https://gist.github.com/e003913ffd493da63cbc
-			dirname(__FILE__) . '/../phpBB/vendor',
-		);
 	}
 
-	public function test_lint()
+	/**
+	 * @dataProvider lint_data
+	 */
+	public function test_lint($path)
 	{
 		if (version_compare(PHP_VERSION, '5.3.0', '<'))
 		{
 			$this->markTestSkipped('phpBB uses PHP 5.3 syntax in some files, linting on PHP < 5.3 will fail');
 		}
 
-		$root = dirname(__FILE__) . '/..';
-		$this->check($root);
+		$cmd = sprintf('(%s -l %s) 2>&1', self::$php_binary, escapeshellarg($path));
+		$output = array();
+		$status = 1;
+		exec($cmd, $output, $status);
+		$output = implode("\n", $output);
+		$this->assertEquals(0, $status, "PHP lint failed for $path:\n$output");
+	}
+
+	public function lint_data()
+	{
+		return $this->check(dirname(__FILE__) . '/..');
 	}
 
 	protected function check($root)
 	{
+		$files = array();
 		$dh = opendir($root);
 		while (($filename = readdir($dh)) !== false)
 		{
@@ -76,19 +79,23 @@ class phpbb_lint_test extends phpbb_test_case
 			{
 				continue;
 			}
-			if (is_dir($path) && !in_array($path, self::$exclude))
+			if (is_dir($path) && !in_array($path, array(
+					dirname(__FILE__) . '/../.git',
+					dirname(__FILE__) . '/../build/new_version',
+					dirname(__FILE__) . '/../build/old_versions',
+					dirname(__FILE__) . '/../phpBB/cache',
+					// PHP Fatal error:  Cannot declare class Container because the name is already in use in /var/www/projects/phpbb3/tests/../phpBB/vendor/symfony/dependency-injection/Symfony/Component/DependencyInjection/Tests/Fixtures/php/services1-1.php on line 20
+					// https://gist.github.com/e003913ffd493da63cbc
+					dirname(__FILE__) . '/../phpBB/vendor',
+				)))
 			{
-				$this->check($path);
+				$files = array_merge($files, $this->check($path));
 			}
 			else if (substr($filename, strlen($filename)-4) == '.php')
 			{
-				$cmd = sprintf('(%s -l %s) 2>&1', self::$php_binary, escapeshellarg($path));
-				$output = array();
-				$status = 1;
-				exec($cmd, $output, $status);
-				$output = implode("\n", $output);
-				$this->assertEquals(0, $status, "PHP lint failed for $path:\n$output");
+				$files[] = array($path);
 			}
 		}
+		return $files;
 	}
 }
-- 
cgit v1.2.1