Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | [ticket/11495] Fix more grammar issues in doc blocks | Joas Schilling | 2013-04-30 | 1 | -8/+8 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix "as well" typo and remove brackets | Joas Schilling | 2013-04-30 | 2 | -4/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Do not reset item_parent if not required | Joas Schilling | 2013-04-30 | 1 | -15/+17 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix @return doc of get_sql_where() | Joas Schilling | 2013-04-30 | 1 | -1/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove useless release_lock() method | Joas Schilling | 2013-04-30 | 1 | -24/+14 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use $lock->owns_lock() instead of own property | Joas Schilling | 2013-04-30 | 1 | -16/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add owns_lock() method to lock classes | Joas Schilling | 2013-04-30 | 2 | -0/+22 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove useless cast | Joas Schilling | 2013-04-30 | 1 | -1/+1 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Move lock code into two methods to allow easier handling | Joas Schilling | 2013-04-30 | 1 | -40/+71 |
| | | | | | | | This also allows to simply remove the lock handling by overwriting the two methods acquire_lock() and release_lock(). PHPBB3-11495 | ||||
* | [ticket/11495] Fix docs of add_item_to_nestedset() and take id as argument | Joas Schilling | 2013-04-30 | 1 | -6/+10 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix some more comments and the package tag | Joas Schilling | 2013-04-30 | 3 | -6/+6 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Correctly distinguish between children and descendants | Joas Schilling | 2013-04-30 | 1 | -4/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use descendants and ancestors instead of parents/children | Joas Schilling | 2013-04-30 | 2 | -23/+23 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove get_parent_data from interface and rename it | Joas Schilling | 2013-04-30 | 2 | -12/+6 |
| | | | | | | | The method is implementation specific and has no use, apart from cache, that is not covered by get_path_data(). PHPBB3-11495 | ||||
* | [ticket/11495] Fix some docs and replace branch with other terms | Joas Schilling | 2013-04-30 | 2 | -22/+22 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix doc blocks once more | Joas Schilling | 2013-04-26 | 2 | -6/+6 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Make method names for add/remove more descriptive | Joas Schilling | 2013-04-26 | 1 | -4/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix comments and package docs | Joas Schilling | 2013-04-25 | 3 | -5/+5 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use constructor arguments over properties in implementation | Joas Schilling | 2013-04-25 | 2 | -22/+47 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove add/remove from the interface | Joas Schilling | 2013-04-25 | 2 | -23/+13 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove fixing function from tree interface | Joas Schilling | 2013-04-25 | 2 | -29/+24 |
| | | | | | | The fixing function is implementation dependent. PHPBB3-11495 | ||||
* | [ticket/11495] Move classes to tree/ as they all implement a tree | Joas Schilling | 2013-04-25 | 3 | -6/+6 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Explain use of set_subset_zero on remove_subset() | Joas Schilling | 2013-04-25 | 1 | -2/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use default exceptions | Joas Schilling | 2013-04-25 | 2 | -34/+14 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Explain what "given item" means | Joas Schilling | 2013-04-25 | 2 | -4/+4 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Split get_branch_data into multiple methods | Joas Schilling | 2013-04-25 | 2 | -21/+62 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Rename set_parent to change_parent() | Joas Schilling | 2013-04-25 | 2 | -3/+5 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Explain whether move_children prepends/appends/overwrittes | Joas Schilling | 2013-04-25 | 1 | -0/+3 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Rename fix function to regenerate_left_right_ids() | Joas Schilling | 2013-04-25 | 2 | -4/+16 |
| | | | | | | | | | | | | | | | This method regenerates the left/right ids for the nested set based on the parent/child relations. This function executes three queries per item, so it should only be called, when the set has one of the following problems: - The set has a duplicated value inside the left/right id chain - The set has a missing value inside the left/right id chain - The set has items that do not have a left/right is set When regenerating the items, the items are sorted by parent id and their current left id, so the current child/parent relationships are kept and running the function on a working set will not change any orders. PHPBB3-11495 | ||||
* | [ticket/11495] Explain move() more | Joas Schilling | 2013-04-25 | 1 | -0/+4 |
| | | | | | | | | An item is only moved up/down within the same parent. If the delta is larger then the number of children, the item is moved to the top/bottom of the list of children within this parent. PHPBB3-11495 | ||||
* | [ticket/11495] Do not compare to null anymore (left over from item class) | Joas Schilling | 2013-04-25 | 1 | -2/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use item ids instead of requiring all data | Joas Schilling | 2013-04-19 | 2 | -31/+90 |
| | | | | | | | The data is grabbed again in most cases anyway, so it just makes the system easier to use. PHPBB3-11495 | ||||
* | [ticket/11495] Cast some values to int | Joas Schilling | 2013-04-19 | 1 | -5/+5 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use item_id only as parameter for delete() and remove() | Joas Schilling | 2013-04-19 | 2 | -12/+13 |
| | | | | | | The data is acquired again anyway PHPBB3-11495 | ||||
* | [ticket/11495] Use item_id only as parameter for get_branch_data() | Joas Schilling | 2013-04-19 | 2 | -16/+9 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix Spacing and lowercase on docs | Joas Schilling | 2013-04-19 | 2 | -7/+7 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove acquire locks from forum implementation | Joas Schilling | 2013-04-18 | 1 | -63/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Acquire locks for operations that manipulate the tree | Joas Schilling | 2013-04-18 | 1 | -9/+66 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove item class as its no longer required | Joas Schilling | 2013-04-18 | 2 | -6/+0 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Manually specify the table columns | Joas Schilling | 2013-04-18 | 1 | -2/+2 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Move nestedset default values to new method | Joas Schilling | 2013-04-18 | 1 | -8/+21 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix column variable names | Joas Schilling | 2013-04-18 | 2 | -7/+7 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Remove item classes | Joas Schilling | 2013-04-18 | 3 | -171/+0 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use array directly instead of phpbb_nestedset_item_interface | Joas Schilling | 2013-04-18 | 3 | -103/+97 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Fix description of get_sql_where | Joas Schilling | 2013-04-17 | 1 | -3/+1 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Use unique properties for the column names | Joas Schilling | 2013-04-17 | 2 | -102/+95 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add forum implementation of nestedset | Joas Schilling | 2013-04-16 | 3 | -0/+169 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add abstract implementation of the interface | Joas Schilling | 2013-04-16 | 2 | -0/+714 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11495] Add basic interface with nestedset operations | Joas Schilling | 2013-04-16 | 2 | -0/+192 |
| | | | | PHPBB3-11495 | ||||
* | [ticket/11488] Use correct base class in email notification method | Marc Alexander | 2013-04-15 | 2 | -2/+2 |
| | | | | | | | | | In ticket/11451 this was not correctly changed to reflect the new class phpbb_notifcation_method_messenger_base. Additionally, an undefined variable error has been fixed in messenger_base.php (change should be confirmed by bantu though). PHPBB3-11488 |