aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes
Commit message (Collapse)AuthorAgeFilesLines
...
* | Fix Bug #57375 - Do not delete unrelated attachments when deleting empty forums.Andreas Fischer2010-02-231-6/+7
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10526 89ea8834-ac86-4346-8a33-228a782c2dd0
* | General errors can't be logged if there isn't a database connection, ↵Chris Smith2010-02-221-1/+1
| | | | | | | | | | | | introduced in r9924 #57975 git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10518 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Enter stage left: the INTTEXT tokenHenry Sudhof2010-02-212-2/+8
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10516 89ea8834-ac86-4346-8a33-228a782c2dd0
* | BBCode parser now uses the user object for all settings rather than taking ↵Nils Adermann2010-02-211-1/+1
| | | | | | | | | | | | some from the template object [Bug #57365] git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10515 89ea8834-ac86-4346-8a33-228a782c2dd0
* | warn users about TEXTHenry Sudhof2010-02-201-91/+107
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10511 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Fix Bug #57755 - Make user_email_hash() function independent from system's ↵Andreas Fischer2010-02-182-3/+5
| | | | | | | | | | | | architecture. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10499 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Bug #57795 - [Fix] Restrict search for language/../iso.txt to folders.Joas Schilling2010-02-171-0/+5
| | | | | | | | | | | | | | Authorised by: bantu git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10496 89ea8834-ac86-4346-8a33-228a782c2dd0
* | r10491 - Also in the Post Settings section. Thanks leviatan21Andreas Fischer2010-02-161-1/+1
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10492 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Add sql_bit_or() dbal method. Add ability to enable quick reply in all ↵Andreas Fischer2010-02-155-2/+69
| | | | | | | | | | | | forums. -- Voila ;-) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10491 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Forgot to properly update the file header of mssqlnative.php, revising ↵Nils Adermann2010-02-111-2/+4
| | | | | | | | | | | | r10489 [Bug #57055] git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10490 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Support for Microsoft's Native SQL Server Driver for PHP - Patch by Chris ↵Nils Adermann2010-02-118-2/+775
| | | | | | | | | | | | | | | | | | | | | | | | | | Pucci at Microsoft [Bug #57055] If you are using SQL Server, please try to test this new dbal so we can safely include it in 3.0.8. If you want to try it on a current phpBB version you can apply the latest version of the patch to your board which you can find attached to the bug tracker ticket (look in the comments for the latest version, the one in the ticket itself is outdated): http://www.phpbb.com/bugs/phpbb3/ticket.php?ticket_id=57055 git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10489 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Fix Bug #57455 - Fix problems with firebird by no longer using 'count' as a ↵Andreas Fischer2010-02-083-5/+6
| | | | | | | | | | | | column alias. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10484 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Fix #57395, a regression from r10427Josh Woody2010-02-071-1/+1
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10482 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Bug #57345 - No longer return the character O in generated random strings ↵Andreas Fischer2010-02-071-1/+1
| | | | | | | | | | | | and passwords. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10480 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Bug #13181 - Honor minimum and maximum password length in generated ↵Andreas Fischer2010-02-071-5/+6
| | | | | | | | | | | | passwords as much as we can. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10479 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Fix Bug #57385Andreas Fischer2010-02-061-2/+2
| | | | | | | | | | | | | | | | Correctly sort database backup file list by date on database restore page. Take admin's time zone settings into account when listing database backup files. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10478 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Bug #57265 - Convertors cannot read configuration filesJosh Woody2010-02-041-2/+16
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10473 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Slight performance optimisation for r9624 refs #54265Chris Smith2010-02-011-1/+3
| | | | | | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10470 89ea8834-ac86-4346-8a33-228a782c2dd0
* | Change version numbers to 3.0.7 and 3.0.8-dev in preparation for development ↵Nils Adermann2010-02-011-1/+1
|/ | | | | | on next release git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10468 89ea8834-ac86-4346-8a33-228a782c2dd0
* Do not store email templates in database. [Bug #54505]Nils Adermann2010-01-262-16/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To explain what this is about, first a short phpBB code history lesson: ;-) r9823 originally introduced the usage of our template class for emails. The messenger class uses set_custom_template() to initialise the template object which neither disables storedb nor inheritance. These two values are set in $user->theme rather than inside a particular template instance (quite a design failure if I may add). Thus the html page that is displayed to the user also determines these settings for the email templates. This obviously causes problems because both emails and other custom templates can quite simply not be stored in the database because the db table only stores the filename, not the path and requires a template id. r9839 then generally disabled storedb and template inheritance for custom templates to fix Bug #40515. This works for custom templates, but not for emails where lots of template objects are created. In such a situation the last call to set(_custom)_template() would now determine the values of storedb and inheritance in _tpl_load. So any page sending emails would neither load its template from the database nor use template inheritance. The same revision also introduced orig_tpl_* variables in set_template() which on their own are very much pointless, but could allow resetting the storedb and inheritance values if they were used to reset $user->theme just before template execution in _tpl_load. In r10150 these orig_tpl_* variables are correctly used to access information about the template of the page being displayed - contrary to the last template used - from within the bbcode, fixing Bug #51285. However r10150 also introduces a pointless $template_mode parameter for set_custom_template(). $template_mode is really just a boolean flag (value you can be 'template' or an arbitrary other value) that if it set circumvents the unsetting of storedb and template inheritance. The very code that had been added to prevent issues with emails and custom templates. Fixing the problem introduced by r8839 but at the same time reintroducing the much greater problem from the original implementation of email templates. And now an explanation of what I did: Based on this I have now changed the set_custom_template method to always disable storedb. It can now properly use inheritance, you simply tell it the path where the parent template can be found, by default the path is false which will turn inheritance off. To make this work the template class now always overwrites $user->theme storedb and inheritance variabbles with orig_tpl_* just before rendering a template in _tpl_load. This way they are guaranteed to always contain the value they had at the time set_template/set_custom_template were called. This fixes [Bug #54505]. In summary, using global state is simply a horrible idea in object oriented programming. Always Pass values, that an object depends on, as parameters - never through magic global variables. Following this principle will safe you from a lot of headaches. Please test this patch as much as possible to make sure templates still work properly for you, focus on multiple languages, missing language files, and custom templates in systems that make use of the template class outside of phpBB itself. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10460 89ea8834-ac86-4346-8a33-228a782c2dd0
* okay, now the confirm_id is no longer enough to get a new row into the qa tableHenry Sudhof2010-01-261-15/+3
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10459 89ea8834-ac86-4346-8a33-228a782c2dd0
* Add a warning for users of old PHP versions about ending support.Josh Woody2010-01-261-0/+8
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10458 89ea8834-ac86-4346-8a33-228a782c2dd0
* erm, that wouldn't workHenry Sudhof2010-01-261-3/+3
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10457 89ea8834-ac86-4346-8a33-228a782c2dd0
* tuningHenry Sudhof2010-01-261-0/+38
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10454 89ea8834-ac86-4346-8a33-228a782c2dd0
* debug code, begoneHenry Sudhof2010-01-261-1/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10453 89ea8834-ac86-4346-8a33-228a782c2dd0
* tuningHenry Sudhof2010-01-261-5/+5
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10451 89ea8834-ac86-4346-8a33-228a782c2dd0
* ACP usabilityHenry Sudhof2010-01-261-12/+61
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10450 89ea8834-ac86-4346-8a33-228a782c2dd0
* Further fixes for r10447 and r10448. Correctly account for custom language ↵Josh Woody2010-01-261-1/+10
| | | | | | directories (caught by naderman) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10449 89ea8834-ac86-4346-8a33-228a782c2dd0
* Remove needless check (revising r10447)Josh Woody2010-01-261-7/+4
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10448 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fall back to board default language email template if the file does not ↵Josh Woody2010-01-261-2/+8
| | | | | | exist user's preferred language (#35595) git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10447 89ea8834-ac86-4346-8a33-228a782c2dd0
* Database updater now separates ADD COLUMN from SET NOT NULL and SET DEFAULT, ↵Nils Adermann2010-01-261-1/+23
| | | | | | when using PostgreSQL <= 7.4 [Bug #54435] git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10446 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Fix] Don't send activation email when user tries to change email without ↵Cullen Walsh2010-01-251-5/+8
| | | | | | | | | permission (fix by nrohler). (Bug #56335) Authorised by: naderman git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10443 89ea8834-ac86-4346-8a33-228a782c2dd0
* Deprecate $allow_reply parameter to truncate_string() (Bug #56675)Josh Woody2010-01-251-2/+3
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10442 89ea8834-ac86-4346-8a33-228a782c2dd0
* Bug #52495 - [Fix] Replace hard coded "px" with translated language-string.Joas Schilling2010-01-251-3/+3
| | | | | | | Authorised by: bantu git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10441 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Fix] Don't send activation email when user tries to change email without ↵Cullen Walsh2010-01-251-1/+1
| | | | | | | | | permission (fix by nrohler). (Bug #56335) Authorised by: naderman git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10438 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Fix] Do not automatically unsubscribe users from topics, when email and ↵Joas Schilling2010-01-241-1/+1
| | | | | | | | jabber is disabled. Authorised by: bantu git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10436 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix bug #55045 - Do not duplicate previous/next links in pagination text of ↵Ruslan Uzdenov2010-01-242-2/+2
| | | | | | | | moderator logs and user notes in MCP for subsilver2. Authorised by: bantu git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10433 89ea8834-ac86-4346-8a33-228a782c2dd0
* Trigger error right away if user has exceeded login attempts instead of ↵Andreas Fischer2010-01-201-0/+5
| | | | | | asking for the authentication data over and over again without accepting it even if it is correct. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10432 89ea8834-ac86-4346-8a33-228a782c2dd0
* Make sure captcha factory is there. Make sure language array is there.Andreas Fischer2010-01-202-0/+10
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10431 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Feature] Ability to use HTTP authentication in ATOM feeds by passing the ↵Andreas Fischer2010-01-193-0/+99
| | | | | | GET parameter auth=http git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10430 89ea8834-ac86-4346-8a33-228a782c2dd0
* Bug #56285 - Properly calculate posts in a topic in the MCPCullen Walsh2010-01-191-1/+8
| | | | | | | Authorised by: bantu git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10428 89ea8834-ac86-4346-8a33-228a782c2dd0
* - Bug #56255 - Moving topics to a forum where you are on queue Josh Woody2010-01-183-8/+19
| | | | | | - Allow some error handling in compress class by returning false if file does not exist. git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10427 89ea8834-ac86-4346-8a33-228a782c2dd0
* Friends and foes will not show up as private message rule options if their ↵Chris Smith2010-01-181-0/+17
| | | | | | respective UCP modules are disabled. #51155 git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10425 89ea8834-ac86-4346-8a33-228a782c2dd0
* Include live data in the statistics #53795Chris Smith2010-01-171-0/+4
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10423 89ea8834-ac86-4346-8a33-228a782c2dd0
* The easy solution to all my problems with SQLite is this. :( #56105Chris Smith2010-01-171-1/+8
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10422 89ea8834-ac86-4346-8a33-228a782c2dd0
* Load reCAPTCHA over https when using a secure connection to the board. #55755Chris Smith2010-01-171-0/+7
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10420 89ea8834-ac86-4346-8a33-228a782c2dd0
* spacesHenry Sudhof2010-01-171-1/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10418 89ea8834-ac86-4346-8a33-228a782c2dd0
* Invalidate captcha after regHenry Sudhof2010-01-171-1/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10417 89ea8834-ac86-4346-8a33-228a782c2dd0
* Invalidate captcha after regHenry Sudhof2010-01-171-0/+6
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10415 89ea8834-ac86-4346-8a33-228a782c2dd0
* spacesHenry Sudhof2010-01-171-1/+1
| | | | git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10413 89ea8834-ac86-4346-8a33-228a782c2dd0