| Commit message (Collapse) | Author | Age | Files | Lines | |
|---|---|---|---|---|---|
| * | [feature/template-engine] Delete _get_locator function. | Oleg Pudeyev | 2011-08-13 | 1 | -13/+0 |
| | | | | | | | It is no longer needed as locator is injected into template. PHPBB3-9726 | ||||
| * | [feature/template-engine] Clean up template locator usage in bbcode. | Oleg Pudeyev | 2011-08-13 | 1 | -3/+2 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Need to call set_template on template. | Oleg Pudeyev | 2011-08-09 | 1 | -1/+1 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Dependency inject locator into template. | Oleg Pudeyev | 2011-08-09 | 3 | -4/+7 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete useless code from set_template. | Oleg Pudeyev | 2011-08-09 | 1 | -7/+1 |
| | | | | | | | | set_custom_template performs these calls, repeating them in set_template is not needed. PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete no longer used $template_filename property. | Oleg Pudeyev | 2011-08-09 | 1 | -1/+0 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete useless $template globalization. | Oleg Pudeyev | 2011-08-09 | 1 | -1/+1 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Use template engine class in bbcode class. | Oleg Pudeyev | 2011-08-07 | 2 | -17/+19 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Corrected an error message in template locator. | Oleg Pudeyev | 2011-08-07 | 1 | -1/+1 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Remaining documentation. | Oleg Pudeyev | 2011-08-07 | 7 | -1/+57 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] More documentation for template class. | Oleg Pudeyev | 2011-08-07 | 1 | -8/+35 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Create load_and_render to reduce code duplication. | Oleg Pudeyev | 2011-08-07 | 1 | -7/+13 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Get rid of orig_tpl_* in template engine. | Oleg Pudeyev | 2011-08-04 | 2 | -68/+28 |
| | | | | | | | | | | | | | | | | | | | | | | | | | | | The origins of orig_tpl_* are not pretty. Please see the following commits and associated tickets: r9823, r9839, r9847, r10150, r10460. In short, multiple hacks were required due to template engine reading inheritance/storedb flags from $user (global) even when the template that was being looked up or rendered was not the "active style of the current user". We no longer store templates in the database, removing half of the problem. This commit fixes the second half of the problem by deleting set_template_path function from template locator, and moving that logic back into the template class' set_template. set_template now calls set_custom_template, the latter only taking the template path and the fallback paths as parameters. With this change template locator no longer uses $user and does not use phpbb root path either. All logic involving setting the user's "active" template is now encapsulated in a single template class's function, set_template. Setting other templates is done via set_custom_template and the caller is responsible for determining and passing in fallback/inheritance path, if any. PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete $style_name param from locator's ↵ | Oleg Pudeyev | 2011-08-04 | 2 | -5/+3 |
| | | | | | | | | | | set_custom_template. This parameter was unused, it was only used by template's set_custom_template to determine cache file prefix. PHPBB3-9726 | ||||
| * | [feature/template-engine] Add constructor to template locator. | Oleg Pudeyev | 2011-08-04 | 2 | -1/+9 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Factor template locator out of template class. | Oleg Pudeyev | 2011-07-30 | 2 | -118/+283 |
| | | | | | | | | | | | | Template locator is responsible for maintaining mapping from template handles to filenames and paths, and provides resolution services using these mappings. Template locator is aware of template inheritance and is capable of checking template file existence on the filesystem. PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete $files_template property. | Oleg Pudeyev | 2011-07-30 | 1 | -4/+0 |
| | | | | | | | | | This seems to have been used for db storage of templates. We no longer offer db storage of templates, and thus currenty $files_template is only written to but not read anywhere. PHPBB3-9726 | ||||
| * | [feature/template-engine] Rename is_absolute to phpbb_is_absolute. | Oleg Pudeyev | 2011-07-24 | 2 | -3/+3 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Docblocks, no more constructor for filter | Igor Wiedler | 2011-07-16 | 1 | -6/+18 |
| | | | | | | | Add docblocks for phpbb_template_filter, remove the useless constructor. PHPBB3-9726 | ||||
| * | [feature/template-engine] Add ampersands to return refs by reference. | Oleg Pudeyev | 2011-07-10 | 1 | -2/+2 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete useless assignment by reference for $lang. | Oleg Pudeyev | 2011-07-10 | 2 | -2/+2 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Remove $include_once argument of display() | Igor Wiedler | 2011-07-10 | 1 | -9/+6 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Refactor $config dependency out of the filter | Igor Wiedler | 2011-07-10 | 3 | -10/+31 |
| | | | | | | | | | | | The template stream filter no longer depends on the $config global. Instead it uses a 'allow_php' param that is passed via stream_bucket_append's last argument. Tests also adjusted. PHPBB3-9726 | ||||
| * | [feature/template-engine] Fix some comments | Igor Wiedler | 2011-07-10 | 2 | -15/+16 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Move template.php to includes/template | Igor Wiedler | 2011-07-10 | 1 | -0/+0 |
| | | | | | | | This allows making use of autoloading. PHPBB3-9726 | ||||
| * | [feature/template-engine] Fixed absolute path PHP includes, added test. | Oleg Pudeyev | 2011-05-19 | 1 | -1/+8 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete @version everywhere. | Oleg Pudeyev | 2011-05-14 | 7 | -7/+0 |
| | | | | | | | This is not used since the switch to git. PHPBB3-9726 | ||||
| * | [feature/template-engine] Moved phpbb_template_filter into own file. | Oleg Pudeyev | 2011-05-14 | 2 | -831/+848 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Delete @access everywhere. | Oleg Pudeyev | 2011-05-14 | 3 | -36/+0 |
| | | | | | | | Access specification in php 5 is done directly on functions/properties. PHPBB3-9726 | ||||
| * | [feature/template-engine] Make INCLUDEPHP relative to board root. | Oleg Pudeyev | 2011-05-12 | 2 | -4/+4 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Replaced globals with dependency injection. | Oleg Pudeyev | 2011-05-12 | 2 | -37/+60 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Clarify cache directory path for set_custom_template | Oleg Pudeyev | 2011-05-12 | 1 | -1/+4 |
| | | | | | | | | Even if the template may be outside of phpBB, phpBB's cache directory is still going to be used for storing compiled template code. PHPBB3-9726 | ||||
| * | [feature/template-engine] Try to handle failed template includes. | Oleg Pudeyev | 2011-05-12 | 1 | -2/+3 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Rename $filename to $compiled_path for clarity. | Oleg Pudeyev | 2011-05-12 | 1 | -6/+6 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Move DEBUG_EXTRA check for $recompile up. | Oleg Pudeyev | 2011-05-12 | 1 | -14/+10 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Deleted useless assignment. | Oleg Pudeyev | 2011-05-12 | 1 | -1/+0 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Added docblocks to get_*_ref in context. | Oleg Pudeyev | 2011-05-12 | 1 | -0/+22 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Fixed reference usage. | Oleg Pudeyev | 2011-05-12 | 3 | -3/+7 |
| | | | | | | | | Hopefully this is right, I have not checked it against the manual (assuming the manual even covers these things). PHPBB3-9726 | ||||
| * | [feature/template-engine] Disposed of underscores in property names. | Oleg Pudeyev | 2011-05-12 | 2 | -32/+32 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Remove commented out error reporting logic. | Oleg Pudeyev | 2011-05-12 | 1 | -10/+0 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Refactor hook logic into a separate function. | Oleg Pudeyev | 2011-05-12 | 1 | -7/+24 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Reinstate phpbb_template#destroy function. | Oleg Pudeyev | 2011-05-12 | 1 | -0/+9 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Add back IN_PHPBB preamble. | Oleg Pudeyev | 2011-05-12 | 1 | -1/+20 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Moved template classes to subdirectory. | Oleg Pudeyev | 2011-05-08 | 5 | -0/+0 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Renamed template executor and friends to renderer. | Oleg Pudeyev | 2011-05-08 | 4 | -33/+33 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Added docblocks and boilerplate to new files. | Oleg Pudeyev | 2011-05-07 | 4 | -0/+76 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Removed more dead code. | Oleg Pudeyev | 2011-05-07 | 1 | -6/+0 |
| | | | | | PHPBB3-9726 | ||||
| * | [feature/template-engine] Added phpbb_template_context class. | Oleg Pudeyev | 2011-05-07 | 6 | -246/+367 |
| | | | | | | | Objects of this class hold variables assigned to templates. PHPBB3-9726 | ||||
| * | [feature/template-engine] Always call ob_end_clean. | Oleg Pudeyev | 2011-05-05 | 1 | -1/+1 |
| | | | | | | | We have to stop output buffering even when rendering fails. PHPBB3-9726 | ||||
| * | [feature/template-engine] Removed some dead code. | Oleg Pudeyev | 2011-05-04 | 1 | -3/+1 |
| | | | | | PHPBB3-9726 | ||||
