aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes
Commit message (Collapse)AuthorAgeFilesLines
...
* [feature/template-engine] Split template execution logic into classes.Oleg Pudeyev2011-05-044-63/+123
| | | | | | | | | | | Template executor interface defines a template executor object. It is an object which can execute (i.e. display/render) a template. Currently there are two implementations: * phpbb_template_executor_include includes php code from a file. * phpbb_template_executor_eval eval's php code. PHPBB3-9726
* [feature/template-engine] Removed storedb-related logic.Oleg Pudeyev2011-05-041-124/+2
| | | | | | | | | phpBB 3.1 will not provide the option to store templates in the database. This commit removes code that handles templates stored in database from the template engine. PHPBB3-9726
* [feature/template-engine] Delete template class, use phpbb_template instead.Oleg Pudeyev2011-05-042-10/+1
| | | | PHPBB3-9726
* [feature/template-engine] Rename template_compile methods for clarity.Oleg Pudeyev2011-05-042-11/+11
| | | | PHPBB3-9726
* [feature/template-engine] Extracted compile_stream_to_stream.Oleg Pudeyev2011-05-011-4/+19
| | | | PHPBB3-9726
* [feature/template-engine] Close output stream in compile().Oleg Pudeyev2011-05-011-1/+4
| | | | | | | There is no need to leave the stream to the garbage collector, and the amount of data stuck in it may be substantial. PHPBB3-9726
* [feature/template-engine] Fixed description of assign_display().Oleg Pudeyev2011-05-011-1/+1
| | | | | | | This function returns false on failure, which can happen if display() failed. Document the failure return value. PHPBB3-9726
* [feature/template-engine] Check return value of display() in assign_display().Oleg Pudeyev2011-05-011-1/+5
| | | | | | If display() failed, propagate the failure out of assign_display(). PHPBB3-9726
* [feature/template-engine] Removed $this from new phpbb_template_compile calls.Oleg Pudeyev2011-04-261-3/+3
| | | | | | The compile class no longer takes template as a parameter. PHPBB3-9726
* [feature/template-engine] Fix negative variable expressionsIgor Wiedler2011-04-251-11/+4
| | | | | | | | | | | | | compile_tag_if had the flawed approach of adding an isset statement for all variables to the beginning of the if. This fails for negative expressions, and checking those takes a considerable effort. The easier solution is to make the variable expression itself conditional, defaulting to null if it is not set. Thanks to naderman for the solution. PHPBB3-9726
* [feature/template-engine] Corrected miscompilation of loop size constructs.Oleg Pudeyev2011-04-251-1/+1
| | | | PHPBB3-9726
* [feature/template-engine] Corrected an off-by-one error in nested namespaces.Oleg Pudeyev2011-04-241-1/+5
| | | | | | | | This error resulted in a dot from the namespace being placed into variable reference in compiled template code, thus creating bogus compiled template code. PHPBB3-9726
* [feature/template-engine] Deleted silencing of notices.Oleg Pudeyev2011-04-241-0/+2
| | | | | | | The code is now supposed to be notice-free, therefore there is no need to have the notices silenced. PHPBB3-9726
* [feature/template-engine] Deleted $template from phpbb_template_compile class.Oleg Pudeyev2011-04-242-94/+73
| | | | | | | | | | | | | phpbb_template_compile is now much simpler. It takes complete file paths as inputs, either source template path or source template path and output compiled template path. The number of methods also went down to two - compile template and returned compiled text or compile and write to file. phpbb_compile class is responsible for determining source and compiled paths. It already had all the data necessary for this, now the code is in the same place as the data it uses. PHPBB3-9726
* [ticket/9924] Pass template instance into $template->display hookIgor Wiedler2011-04-241-1/+1
| | | | | | | This is a cherry-pick of 053cf790a93e9cfb521f484901d79c72783f868f which appears to have been partially reverted here. PHPBB3-9924
* [feature/template-engine] Removed a useless space.Oleg Pudeyev2011-04-241-1/+1
| | | | PHPBB3-9726
* [feature/template-engine] Delete class_exists checks, rely on autoloading.Oleg Pudeyev2011-04-241-10/+0
| | | | PHPBB3-9726
* [feature/template-engine] Allow leading underscores in variable names.Oleg Pudeyev2011-04-241-3/+3
| | | | | | Subsilver uses ._file in overall_header. PHPBB3-9726
* [feature/template-engine] Fix recompilation logic.Oleg Pudeyev2011-04-241-10/+13
| | | | | | | | | Do not change $recompile from true to false - any recompilation condition alone is sufficient to force recompilation. Also uncomment the nonexistent file test which passes with this fix. PHPBB3-9726
* [feature/template-engine] Delete ?>, add newline at EOF.Oleg Pudeyev2011-04-232-3/+1
| | | | PHPBB3-9726
* [feature/template-engine] Improved template engine.Marek A. Ruszczynski2011-04-233-877/+1204
| | | | PHPBB3-9726
* Merge branch 'develop-olympus' into developAndreas Fischer2011-04-231-1/+1
|\ | | | | | | | | * develop-olympus: [ticket/10147] Corrected a typo in includes/functions_template.php.
| * Merge branch 'ticket/p/10147' into develop-olympusAndreas Fischer2011-04-231-1/+1
| |\ | | | | | | | | | | | | * ticket/p/10147: [ticket/10147] Corrected a typo in includes/functions_template.php.
| | * [ticket/10147] Corrected a typo in includes/functions_template.php.Oleg Pudeyev2011-04-231-1/+1
| | | | | | | | | | | | PHPBB3-10147
* | | Merge branch 'develop-olympus' into developAndreas Fischer2011-04-221-1/+11
|\ \ \ | |/ / | | | | | | | | | | | | | | | * develop-olympus: [ticket/10141] Save a hash lookup when value is not in cache. [ticket/10141] Split double-assignment into conditional and unconditional part. [ticket/10141] Use a cache in $auth->_fill_acl() for better performance.
| * | [ticket/10141] Save a hash lookup when value is not in cache.Oleg Pudeyev2011-04-211-3/+7
| | | | | | | | | | | | PHPBB3-10141
| * | [ticket/10141] Split double-assignment into conditional and unconditional part.Andreas Fischer2011-04-221-7/+5
| | | | | | | | | | | | PHPBB3-10141
| * | [ticket/10141] Use a cache in $auth->_fill_acl() for better performance.Bart van Bragt2011-04-211-2/+10
| |/ | | | | | | | | | | | | Many sequences being converted are the same. Use a local cache to convert each sequence once, speeding up the function. PHPBB3-10141
* | [ticket/10139] Make signatures of set_atomic() consistent by using $new_value.Andreas Fischer2011-04-191-3/+3
| | | | | | | | PHPBB3-10139
* | [ticket/10139] Rename $cache to $use_cache to avoid confusion with cache objectAndreas Fischer2011-04-192-32/+32
| | | | | | | | PHPBB3-10139
* | Merge branch 'ticket/erikfrerejean/10006' into developOleg Pudeyev2011-04-192-0/+35
|\ \
| * | [ticket/10006] Remove unneeded if statementsErik Frèrejean2011-04-182-10/+0
| | | | | | | | | | | | | | | | | | Remove some of the additional `if (isset)` checks PHPBB3-10006
| * | [ticket/10006] Remove return valuesErik Frèrejean2011-04-182-11/+4
| | | | | | | | | | | | | | | | | | Remove some unneeded return values PHPBB3-10006
| * | [ticket/10006] Add phpbb_config::deleteErik Frèrejean2011-04-182-0/+52
| | | | | | | | | | | | | | | | | | Add the missing `phpbb_config::delete` method to the config class PHPBB3-10006
* | | [ticket/7252] Removed an outdated comment pertaining to PHP 4.x.Oleg Pudeyev2011-04-171-1/+0
| | | | | | | | | | | | PHPBB3-7252
* | | Merge branch 'develop-olympus' into developOleg Pudeyev2011-04-171-25/+26
|\ \ \ | | |/ | |/| | | | | | | * develop-olympus: [ticket/10109] Fix "Undefined Index" errors when copying a topic.
| * | Merge branch 'ticket/nickvergessen/10109' into develop-olympusOleg Pudeyev2011-04-171-25/+26
| |\ \ | | | | | | | | | | | | | | | | * ticket/nickvergessen/10109: [ticket/10109] Fix "Undefined Index" errors when copying a topic.
| | * | [ticket/10109] Fix "Undefined Index" errors when copying a topic.Joas Schilling2011-04-071-25/+26
| | | | | | | | | | | | | | | | PHPBB3-10109
* | | | Merge branch 'develop-olympus' into developOleg Pudeyev2007-01-031-15/+20
|\ \ \ \ | |/ / / | | | / | |_|/ |/| | | | | | | | | | | * develop-olympus: [ticket/10117] Add one more missed 'u' modifier, add code comment [ticket/10115] Switch UTF-8 mode on for the rest of BBCodes [ticket/10117] Make smilies to be correctly parsed within unicode text. [ticket/10115] Make some text oriented BBCodes to properly handle unicode.
| * | Merge branch 'ticket/rxu/10117' into develop-olympusOleg Pudeyev2011-04-171-2/+7
| |\ \ | | | | | | | | | | | | | | | | | | | | * ticket/rxu/10117: [ticket/10117] Add one more missed 'u' modifier, add code comment [ticket/10117] Make smilies to be correctly parsed within unicode text.
| | * | [ticket/10117] Add one more missed 'u' modifier, add code commentrxu2011-04-031-1/+6
| | | | | | | | | | | | | | | | PHPBB3-10117
| | * | [ticket/10117] Make smilies to be correctly parsed within unicode text.rxu2011-04-031-2/+2
| | | | | | | | | | | | | | | | PHPBB3-10117
| * | | Merge branch 'ticket/rxu/10115' into develop-olympusOleg Pudeyev2011-04-171-13/+13
| |\ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/rxu/10115: [ticket/10115] Switch UTF-8 mode on for the rest of BBCodes [ticket/10115] Make some text oriented BBCodes to properly handle unicode.
| | * | | [ticket/10115] Switch UTF-8 mode on for the rest of BBCodesrxu2011-04-031-6/+6
| | | | | | | | | | | | | | | | | | | | PHPBB3-10115
| | * | | [ticket/10115] Make some text oriented BBCodes to properly handle unicode.rxu2011-04-021-7/+7
| | |/ / | | | | | | | | | | | | | | | | | | | | [quote], [b], [i], [size], [color], [u], [list] are affected. PHPBB3-10115
* | | | Merge remote-tracking branch 'p/ticket/10136' into developIgor Wiedler2011-04-111-2/+2
|\ \ \ \ | | | | | | | | | | | | | | | | | | | | * p/ticket/10136: [ticket/10136] Added missing $request globalizations in functions.php.
| * | | | [ticket/10136] Added missing $request globalizations in functions.php.Oleg Pudeyev2011-04-101-2/+2
| | | | | | | | | | | | | | | | | | | | PHPBB3-10136
* | | | | Merge branch 'ticket/nickvergessen/9684' into developOleg Pudeyev2011-04-1111-572/+125
|\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/nickvergessen/9684: [ticket/9684] Also display forum-name in subsilver2 template [ticket/9684] Move currently existing GAs to a selectable forum while updating. [ticket/9684] View origin-forumname for GAs in topic-list [ticket/9684] Fix Forum/Topic-Tracking for global announcements [ticket/9684] Fix a SQL-Error in the posting.php [ticket/9684] Remove code in some more files especially includes/ [ticket/9684] Remove code for global announcement in root-files
| * | | | | [ticket/9684] Fix Forum/Topic-Tracking for global announcementsJoas Schilling2011-04-073-69/+34
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Should be ready for intensive testing now. PHPBB3-9684
| * | | | | [ticket/9684] Remove code in some more files especially includes/Joas Schilling2011-04-0710-347/+78
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Topic-Tracking is still missing. PHPBB3-9684