| Commit message (Collapse) | Author | Age | Files | Lines |
| |\
| |
| |
| | |
ticket/11538
|
| | |
| |
| |
| |
| |
| | |
The given path is an absolute path in general, just not on our current system.
PHPBB3-11545
|
| | |
| |
| |
| | |
PHPBB3-11546
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
It will be possible to use this function via the validate_data() function
interface that has already been used previously. Thus, this new function
will extend the capabilities of validate_data() to checking hex color
values.
PHPBB3-11538
|
| | |
| |
| |
| |
| |
| |
| | |
This will now make sure that 'AAFF00' will be matched but strings like
'AAFF00 AABB00' will not.
PHPBB3-11538
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The input length for the hex color is now limited to 6 characters and
the support for colors starting with a '#' has been dropped. The allowed
input length of 7 in prosilver seems to have been a relict from old ages
of phpBB3. In order to have proper support for correct checking of the
colour value, the new code was also ported to the ACP groups manage page.
The tests have been modified to reflect the changes to the behavior of
the color check. Tests for the ACP will follow.
PHPBB3-11538
|
| | |
| |
| |
| | |
PHPBB3-11538
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
We are now using a regex with preg_match() in order to properly check
if the entered color value is in hex color format or not. A proper
error message is triggered if an incorrect color value is entered and
the prepended '#' is removed if necessary.
PHPBB3-11538
|
| |/
|
|
|
|
|
| |
In order to prevent future issues with this, a basic set of functional
tests for the UCP groups manage page have been added.
PHPBB3-11538
|
| |
|
|
|
|
|
|
| |
There was no space between ; and the string "url=". But according to w3c, we
should have atleast one space between them. So, added space characters
accordingly.
PHPBB3-11105
|
| |\
| |
| |
| |
| |
| | |
* MGaetan89/ticket/11144:
[ticket/11144] Add missing {FORUM_NAME} variable
[ticket/11144] Add missing {FORUM_NAME} variable
|
| | |
| |
| |
| |
| |
| |
| | |
The template variable {FORUM_NAME} was missing from
the login page of a password protected forum
PHPBB3-11144
|
| |/
|
|
|
|
|
| |
The error message about missing style data was not
translated
PHPBB3-9975
|
| |\
| |
| |
| |
| |
| | |
* ticket/11358:
[ticket/11358] Removed all trailing white spaces.
[ticket/11358] Fixed the code according to coding guidlines.
|
| | |
| |
| |
| |
| |
| | |
Removed all trailing white spaces with new lines.
PHPBB3-11358
|
| | |
| |
| |
| |
| |
| |
| | |
Added proper indentation and new line after break in switch
statement.
PHPBB3-11358
|
| |/
|
|
|
|
|
| |
Rather than send invalid message ids with a missing domain part we try
to read one from $_SERVER and otherwise use phpbb.generated
PHPBB3-10986
|
| |
|
|
|
|
|
|
| |
Replaced the parameter name 'defaultbylink' to a meaningful name
'set_default_on_all'. Parameter is used for making all users
default for selected group in acp_groups.php.
PHPBB3-11358
|
| |
|
|
|
|
|
|
|
| |
Changed the action parameter value to recognize whether 'Make default
group for every member' is clicked. If so execute a seperate code block
under switch statement for $action and add all the users as default
for the group.
PHPBB3-11358
|
| |
|
|
|
|
|
|
|
| |
Detect whether link is clicked or form is posted for making users
default for a group. If form is posted and no users are selected,
validation happens and displays an error message. When the link is
clicked, all the users will be default users for that group.
PHPBB3-11358
|
| |
|
|
|
|
|
|
|
| |
Error was thrown when no users are selected before executing the code
chunk which manually adds all the user to make the group default.
Removed this code and referred $mark_ary instead of $name_ary which
will not have selected user ids.
PHPBB3-11358
|
| |
|
|
|
|
|
|
|
|
|
| |
In group membership management, if you perform the action
'Make group default for member' without selecting any user,
a confirm box will be displayed and will show a success
message after confirming. Added a new condition to fix this
issue in acp_groups.php. It will check weather any users are
selected before performing above action.
PHPBB3-11358
|
| |
|
|
|
|
|
| |
Earlier PR was referring wrong variable $name_ary. Changed it to
$mark_ary which actually contains selected user ids.
PHPBB3-11355
|
| |
|
|
|
|
|
|
|
|
|
| |
In ACP group membership management, if you select 'remove member
from group' without selecting any users and submit,it will display
a wrong error after confirmbox. Since no users are selected, this
should not go even until confirmbox. Added a new condition to check
weather any users are selected when the action is 'deleteusers'
in acp_groups.php and disply a correct error.
PHPBB3-11355
|
| |\
| |
| |
| |
| | |
* github-bantu/ticket/11361:
[ticket/11361] Make sure that array passed to strtr() has the proper format.
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The array $date_cache[$format]['lang'] passed to strtr() contains a sub-array
which results in an E_NOTICE being thrown for 'Array to string conversion' on
PHP 5.4.
Ensure that the array passed to strtr() is one-dimensional by filtering out
non-string values.
PHPBB3-11361
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
develop-olympus
* github-exreaction/ticket/10896:
[ticket/10896] Move EMAIL_INVALID_EMAIL to common, replace EMAIL_INVALID
[ticket/10896] Adds email validation to email settings in ACP
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Adds a new validation type to the ACP validate_config_vars function
and implements it on the board_contact and board_email settings.
PHPBB3-10896
|
| | | |
| | |
| | |
| | | |
PHPBB3-7262
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
The logic is the other way around here in comparison to develop's
phpbb_config_db class, so add examples to make things more clear.
PHPBB3-7262
|
| | |/
|/|
| |
| | |
PHPBB3-7262
|
| |/
|
|
|
|
|
| |
In session.php 401 response message was "Not Authorized".
I changed it to "Unauthorized".
PHPBB3-11196
|
| |
|
|
|
|
|
| |
While composing pm, it should not be allowed to add
anonymous user as a PM recipient
PHPBB3-11233
|
| |
|
|
| |
PHPBB3-11343
|
| |
|
|
| |
PHPBB3-11343
|
| |
|
|
|
|
|
| |
Use strict comparison when checking whether stored user_actkey is equal to user
input.
PHPBB3-11343
|
| |\
| |
| |
| |
| |
| |
| | |
# By Sajaki
# Via Sajaki
* remotes/Sajaki/ticket/10854:
[ticket/10854] sql server drop default constraint when dropping column
|
| | |
| |
| |
| |
| |
| | |
drops default columns with T-SQL before attempting drop column to
avoids sql exception. This is a huge annoyance in UMIL scripts running
under sql server.
|
| | |
| |
| |
| | |
PHPBB3-11301
|
| | |
| |
| |
| | |
PHPBB3-11301
|
| |\ \
| | |
| | |
| | |
| | | |
* gn36/ticket/11292:
[ticket/11292] Fix: Newlines removed in display of PM reports
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
Report text is run through make_clickable and bbcode_nl2br for PMs
just as it is for posts.
PHPBB3-11292
|
| |/ /
| |
| |
| |
| |
| |
| | |
php 5.5 alpha 2 deprecated mysql extension, prefer mysqli if
both are available.
PHPBB3-11293
|
| | |
| |
| |
| | |
PHPBB3-10880
|
| | |
| |
| |
| | |
PHPBB3-8610
|
| |\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
# By Oleg Pudeyev (29) and others
# Via Andreas Fischer (3) and others
* 'develop-olympus' of github.com:phpbb/phpbb3: (36 commits)
[ticket/11262] Add .lock in cache directory to .gitignore
[ticket/11265] Add assertions for board installation success.
[ticket/11162] Reformat.
[ticket/10491] Make recreate_database static.
[ticket/11162] Rename tricky updates to database helper.
[ticket/10491] Install board once per test run.
[ticket/10972] Drop user deletion.
[ticket/10972] Tweak user addition.
[ticket/10972] Add destroy method to mock cache.
[ticket/10972] Add mock null cache.
[ticket/10972] Backport get_db from develop.
[ticket/10972] Added explicit checks for creating duplicate users.
[ticket/10972] Moved tests into appropriate places and added comments
[ticket/10972] Added methods for creating and deleting basic users
[ticket/11162] Use empty($queries).
[ticket/11162] Review comments fixed.
[ticket/11162] Reformat.
[ticket/11162] Newlines to LF.
[ticket/11162] Use correct functions.
[ticket/11162] Account for notify_status.
...
Conflicts:
phpBB/includes/mcp/mcp_topic.php
|
| | |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* p/ticket/11162: (22 commits)
[ticket/11162] Reformat.
[ticket/11162] Rename tricky updates to database helper.
[ticket/11162] Use empty($queries).
[ticket/11162] Review comments fixed.
[ticket/11162] Reformat.
[ticket/11162] Newlines to LF.
[ticket/11162] Use correct functions.
[ticket/11162] Account for notify_status.
[ticket/11162] This test really only works for bookmarks.
[ticket/11162] The test is not at all trivial.
[ticket/11162] Add includes.
[ticket/11162] Move to a separate file to avoid blowing out functions.php.
[ticket/11162] No whitespace changes in olympus.
[ticket/11162] Fix inaccurately copy pasted comment.
[ticket/11162] Use phpbb_update_rows_avoiding_duplicates in mcp.
[ticket/11162] Clarify that only the two tables actually work.
[ticket/11162] Uncomment transactions.
[ticket/11162] An implementation that actually works.
[ticket/11162] Make count function upper case.
[ticket/11162] Rename count variable name to remaining_rows.
...
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-11162
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-11162
|
| | | | |
| | | |
| | | |
| | | | |
PHPBB3-11162
|