| Commit message (Collapse) | Author | Age | Files | Lines |
|\
| |
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[ticket/11548] Use new static methods for request and submit
[ticket/11548] Run array_map on complete error array and not just colour_error
Conflicts:
tests/functional/ucp_groups_test.php
|
| |
| |
| |
| |
| |
| |
| |
| | |
Up to now the array_map() that turns error messages into the localized output
was only ran if the group's color was set. With this patch it'll run the
array_map() on the complete error array if it's not empty.
PHPBB3-11548
|
| |
| |
| |
| |
| |
| |
| | |
The avatar manager's method localize_errors() shouldn't be called if
avatars are disabled in the config.
PHPBB3-11602
|
| |
| |
| |
| |
| |
| |
| | |
Without passing those values, the group is removed from the teampage and
the legend while submitting the edit form on the ucp groups manage page.
PHPBB3-11587
|
|\ \
| |/
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* develop-olympus:
[ticket/11538] Add optional switch as argument to hex colour validation
[ticket/11538] Modify test colour values
[ticket/11538] Limit comment in acp_groups to 80 characters per line
[ticket/11538] Move group ID into abstract test class and add more test cases
[ticket/11538] Merge calls to validate_data() in acp_groups
[ticket/11538] Rename phpbb_validate_colour to phpbb_validate_hex_colour
[ticket/11538] Use abstract class for functional test cases for group colour
[ticket/11538] Add function phpbb_validate_colour for validating colours
[ticket/11538] Make sure regex doesn't allow multiple color values
[ticket/11538] Add tests for acp group manage page
[ticket/11538] Simplify colour value check and remove support for '#'
[ticket/11538] Fix incorrect regex and test for duplicate # in color string
[ticket/11538] Use regex for testing color value and improve tests
[ticket/11538] Make sure group color can't exceed maximum of 6 characters
Conflicts:
phpBB/includes/functions_user.php
phpBB/styles/prosilver/template/ucp_groups_manage.html
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The value of $optional will decide whether an empty string will be
treated as incorrect input or if it is allowed. The optional argument
will default to false and therefore treat an empty string as incorrect
unless explicitly told to not do so.
PHPBB3-11538
|
| |
| |
| |
| | |
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
It will be possible to use this function via the validate_data() function
interface that has already been used previously. Thus, this new function
will extend the capabilities of validate_data() to checking hex color
values.
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| | |
This will now make sure that 'AAFF00' will be matched but strings like
'AAFF00 AABB00' will not.
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The input length for the hex color is now limited to 6 characters and
the support for colors starting with a '#' has been dropped. The allowed
input length of 7 in prosilver seems to have been a relict from old ages
of phpBB3. In order to have proper support for correct checking of the
colour value, the new code was also ported to the ACP groups manage page.
The tests have been modified to reflect the changes to the behavior of
the color check. Tests for the ACP will follow.
PHPBB3-11538
|
| |
| |
| |
| | |
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
We are now using a regex with preg_match() in order to properly check
if the entered color value is in hex color format or not. A proper
error message is triggered if an incorrect color value is entered and
the prepended '#' is removed if necessary.
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| | |
In order to prevent future issues with this, a basic set of functional
tests for the UCP groups manage page have been added.
PHPBB3-11538
|
| |
| |
| |
| |
| |
| |
| |
| | |
The $avatar_errors array needs to be merged into the primary $error array
before the group settings get applied. This is currently not the case.
Functional tests for this will be provided by PR #1401.
PHPBB3-11535
|
| |
| |
| |
| |
| |
| |
| |
| | |
This should fix some other bugs that may not have yet been recognized--some
areas only set to(), but sent according to user_notify_type, which is not
necessarily email.
PHPBB3-11454
|
| |
| |
| |
| |
| |
| |
| | |
The phpbb_user object might be used for language variables and other
things.
PHPBB3-10018
|
|\ \
| | |
| | |
| | |
| | | |
Conflicts:
phpBB/config/services.yml
|
| | |
| | |
| | |
| | | |
PHPBB3-9492
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Remove the $request property from the phpbb_avatar_driver class and rather
pass it as function argument if it's needed in a function. Currently this
is only the case for the class methods prepare_form() and process_form().
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Although get_user_avatar() is not new, the phpbb prefix was prepended. This
is due to the fact that it was entirely rewritten and is therefore more or
less a completely new function.
PHPBB3-10018
|
|\ \ \
| |/ /
| | |
| | |
| | | |
Conflicts:
phpBB/includes/ucp/ucp_groups.php
|
| | |
| | |
| | |
| | | |
PHPBB3-11259
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This shouldn't be done in the avatar drivers. We need to force the
display all avatar drivers in the ACP or it won't be possible to enable
avatars after they have been disabled.
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | | |
PHPBB3-10018
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This seems to be the last component where the new avatars system was still
missing.
PHPBB3-10018
|
|\ \ \
| |/ /
|/| |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
feature/avatars
Conflicts:
phpBB/adm/style/acp_groups.html
phpBB/adm/style/acp_users_avatar.html
phpBB/includes/acp/acp_groups.php
phpBB/includes/acp/acp_users.php
phpBB/includes/functions_display.php
phpBB/install/database_update.php
phpBB/install/schemas/mssql_schema.sql
phpBB/styles/prosilver/template/ucp_avatar_options.html
|
| |\ \
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
* develop: (201 commits)
[feature/new-tz-handling] Don't use global user but make it a parameter
[feature/new-tz-handling] Fix size of suggestion button in chrome
[feature/new-tz-handling] Fall back to UTC, if the timezone is invalid
[feature/new-tz-handling] Add previous selected value to validation if valid
[feature/new-tz-handling] Display suggestion when a different value is selected
[ticket/10998] Add border-radius to forum rules block - prosilver
[feature/new-tz-handling] Remove additional marking of selected items
[feature/new-tz-handling] Move update helper function to new class
[feature/new-tz-handling] Fix unit test
[feature/new-tz-handling] Delete old variable which is not used anymore
[feature/new-tz-handling] Rename $user->tz back to $user->timezone
[feature/pagination-as-list] New parameter for name of start var
[feature/pagination-as-list] Updates for nils comments
[feature/pagination-as-list] Rename and deprecate functions
[feature/pagination-as-list] Various fixes and improvements
[ticket/10968] Render pagination within the template
[feature/new-tz-handling] Remove "timezone might be numeric"
[feature/new-tz-handling] Add function to update the timezone
[feature/new-tz-handling] Correctly update user and board timezones on update
[ticket/10996] Use correct DBMS name in Travis config for PostgreSQL
...
|
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
A modularized avatar system that easily allows plugins to be created
for various avatar services, such as Gravatar.
This inital commit includes module support and is backwards
compatible with 3.0 avatars, but does notcontain ACP or UCP modules
for manipulating new avatars.
PHPBB3-10018
|
| | | |
| | | |
| | | |
| | | | |
PHPBB3-10939
|
| |/ /
|/| |
| | |
| | | |
PHPBB3-10990
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Add a new parameter to hold the name of the start variable. This
fulfills ticket PHPBB3-8535.
PHPBB3-10968
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Re-remove deprecated functions, change on_page to phpbb_on_page,
add null returns, remove globals and pass as params.
PHPBB3-10968
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Returned and marked deprecated topic_generate_pagination. Rename
new function in line with coding guidelines.
PHPBB3-10968
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Extracted common template code for prosilver as per subsilver2.
Various other fixups and oversight corrections, changed name
of the "new" template function and re-introduced existing
version. Altered on_page to compensate for removal of some
templating vars from pagination routine.
PHPBB3-10968
|
|/ /
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Since phpBB 2 pagination has been rendered mostly within the source. This
limits just what designers can do with pagination. The current form is also
questionable in terms of "best practice". The aim is to move rendering
completely to the template via the use of a block element. Enabling S_
template vars also allows for control over specific aspects of the
pagination output such as next, previous, active and ellipsis.
Related to this - merging the capabilities of the topic_generate_pagination
with generate_pagination removes an element of duplication.
PHPBB3-10968
|
| |
| |
| |
| | |
PHPBB3-9916
|
| |
| |
| |
| | |
PHPBB3-10345
|
| |
| |
| |
| |
| |
| |
| | |
I added two function avatar_explanation_string() and avatar_error_wrong_size()
for easier handling of the "pixels"-languages, as they are used quite often.
PHPBB3-10345
|
|\ \
| |/
| |
| |
| | |
* develop-olympus:
[ticket/10259] Do not send notifications to user accounts joining free groups.
|
| |
| |
| |
| |
| |
| |
| |
| | |
It does not make sense to send notifications to users joining a freely open
group. They already know that they were added to the group, because they
triggered the actual join.
PHPBB3-10259
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Closing tags converted using Oleg's script.
remove-php-end-tags.py -a .
Trailing newlines added using the following where $ext is file extension.
find . -type f -name "*.$ext" -print | xargs printf "e %s\nw\n" | ed -s;
Extensions: php, css, html, js, xml.
PHPBB3-9556
|