aboutsummaryrefslogtreecommitdiffstats
path: root/phpBB/includes/functions.php
Commit message (Collapse)AuthorAgeFilesLines
* Merge pull request #5637 from EA117/ticket/16054Marc Alexander2019-08-111-6/+4
|\ | | | | | | [ticket/16054] Restore ability to login from any template.
| * [ticket/16054] Restore ability to login from any template.EA1172019-07-281-6/+4
| | | | | | | | | | | | | | | | Moving the login form's add_form_key() work into page_header(), so that the template variables required for presenting a login form are again available to any template that chooses to consume them. PHPBB3-16054
* | Merge pull request #5628 from marc1706/ticket/16101Derky2019-07-301-1/+2
|\ \ | | | | | | | | | [ticket/16101] Add Referrer-Policy header to phpBB's headers
| * | [ticket/16101] Add Referrer-Policy header to phpBB's headersMarc Alexander2019-07-201-1/+2
| | | | | | | | | | | | PHPBB3-16101
* | | Merge pull request #5635 from EA117/ticket/16066Marc Alexander2019-07-291-1/+1
|\ \ \ | | | | | | | | | | | | [ticket/16066] Fix FORM_INVALID always returned for banned user.
| * | | [ticket/16066] Fix FORM_INVALID always returned for banned user.EA1172019-07-281-1/+1
| | |/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After the introduction of add_form_key() and check_form_key() calls to login_box() in phpBB 3.2.6 and later, if a banned user attempts to login, they receive a "The submitted form was invalid. Try submitting again." Instead of the message indicating that they are banned, and why. This is happening because check_ban() actually calls into login_box() recursively, but after the $user->session_id has been switched to a new session ID for the logging-on user. Therefore, now that check_form_key() has been introduced to login_box(), it is impossible for check_form_key() to succeed during this recursive call. Fix is to make login_box()'s use of check_form_key() conditional on whether IN_CHECK_BAN is defined, so that the recursive call does not attempt to re-validate the form_key again. Note the form_key has already been successfully verified by the original call into login_box(), prior to calling into check_ban() and attempting to recursively call login_box(). So the protection of why check_form_key() was added is still intact with this change. PHPBB3-16066
* | | Merge pull request #5459 from mrgoldy/ticket/15886Marc Alexander2019-07-281-2/+2
|\ \ \ | |/ / |/| | | | | [ticket/15886] Group helper functions
| * | [ticket/15886] Change phpbb_get_group_avatar variable namesmrgoldy2018-12-301-2/+2
| | | | | | | | | | | | PHPBB3-15886
* | | Merge pull request #5610 from espipj/ticket/16070Marc Alexander2019-07-231-21/+0
|\ \ \ | | | | | | | | | | | | [ticket/16070] Remove support for WebSTAR and Xitami
| * | | [ticket/16070] Remove unused codeespipj2019-05-271-21/+0
| | |/ | |/| | | | | | | PHPBB3-16070
* | | [ticket/16089] Add core.confirm_box_ajax_beforeJakub Senko2019-07-221-4/+24
|/ / | | | | | | PHPBB3-16089
* | [ticket/16042] Adjust positioning and add comment to overwriteMarc Alexander2019-05-021-1/+2
| | | | | | | | PHPBB3-16042
* | [ticket/16042] Use S_LOGIN_REDIRECT to output login form tokenMarc Alexander2019-05-021-1/+13
| | | | | | | | PHPBB3-16042
* | [ticket/16036] Add S_FORM_TOKEN_LOGIN to all login formsrubencm2019-04-291-0/+3
| | | | | | | | PHPBB3-16036
* | Merge pull request #48 from phpbb/ticket/security/228Marc Alexander2019-04-271-2/+17
|\ \ | | | | | | | | | [ticket/security/228] Add form token to login box
| * | [ticket/security/228] Add form token to login boxDerky2019-04-261-2/+17
| | | | | | | | | | | | SECURITY-228
* | | Merge pull request #5513 from mrgoldy/ticket/15942Marc Alexander2019-04-171-11/+31
|\ \ \ | |/ / |/| | | | | [ticket/15942] Allow array in confirm_box title
| * | [ticket/15942] Add language to compatibility globals & use in confirm_boxMarc Alexander2019-04-171-8/+12
| | | | | | | | | | | | PHPBB3-15942
| * | [ticket/15942] Past tensemrgoldy2019-04-161-1/+1
| | | | | | | | | | | | PHPBB3-15942
| * | [ticket/15942] Update DocBlockmrgoldy2019-04-161-0/+2
| | | | | | | | | | | | PHPBB3-15942
| * | [ticket/15942] Allow array in confirm_box titlemrgoldy2019-01-151-7/+21
| |/ | | | | | | PHPBB3-15942
* | [ticket/15972] Let the event be triggered3D-I2019-02-261-8/+0
| | | | | | | | | | | | Removes old coding which is there just to save a few iterations. PHPBB3-15972
* | [ticket/15972] Add core.markread_after3D-I2019-02-201-0/+21
|/ | | | PHPBB3-15972
* [ticket/15860] Unique_id() return 16 characters againRuben Calvo2018-10-311-1/+1
| | | | PHPBB3-15860
* [ticket/15860] Fix format of backup filesRuben Calvo2018-10-301-1/+1
| | | | PHPBB3-15860
* Merge pull request #5381 from senky/ticket/15616Marc Alexander2018-10-131-1/+3
|\ | | | | | | [ticket/15616] Remove jumpbox from login_forum.html
| * [ticket/15616] Add jumpbox to login_forum.htmlJakub Senko2018-09-261-1/+3
| | | | | | | | PHPBB3-15616
* | Merge pull request #5374 from senky/ticket/15758Marc Alexander2018-10-101-5/+5
|\ \ | | | | | | | | | [ticket/15758] Show translated msg for INSECURE_REDIRECT
| * | [ticket/15758] Show translated msg for INSECURE_REDIRECTJakub Senko2018-09-281-5/+5
| |/ | | | | | | PHPBB3-15758
* | Merge pull request #5377 from senky/ticket/15700Marc Alexander2018-10-091-1/+1
|\ \ | | | | | | | | | [ticket/15700] Use correct T_THEME_LANG_NAME
| * | [ticket/15700] Use correct T_THEME_LANG_NAMEJakub Senko2018-09-251-1/+1
| |/ | | | | | | PHPBB3-15700
* | Merge pull request #5370 from senky/ticket/15805Marc Alexander2018-10-081-1/+3
|\ \ | |/ |/| | | [ticket/15805] Add result to core.login_box_redirect
| * [ticket/15805] Add result to core.login_box_redirectJakub Senko2018-09-241-1/+3
| | | | | | | | PHPBB3-15805
* | [ticket/15723] Rewrite unique_id tooRubén Calvo2018-08-081-1/+1
| | | | | | | | PHPBB3-15723
* | [ticket/15723] Rewrite gen_rand_string() and gen_rand_string_friendly()Rubén Calvo2018-07-141-7/+20
|/ | | | PHPBB3-15723
* Merge pull request #5253 from senky/ticket/15618Tristan Darricau2018-07-081-1/+1
|\ | | | | | | | | | | | | [ticket/15618] Display The team link only to users with permission * github.com:/phpbb/phpbb: [ticket/15618] Display The team link only to users with permission
| * [ticket/15618] Display The team link only to users with permissionJakub Senko2018-06-181-1/+1
| | | | | | | | PHPBB3-15618
* | Merge branch 'prep-release-3.2.3' into 3.2.xTristan Darricau2018-07-081-2/+26
|\ \ | | | | | | | | | | | | | | | | | | | | | * prep-release-3.2.3: [ticket/15676] Use paragraphs and classes as suggested by hanakin [ticket/15676] Use twig syntax [ticket/15676] Simplify link text and use privacy link in cookie notice [ticket/15676] Display privacy notice in footer & allow overriding U_PRIVACY
| * | [ticket/15676] Simplify link text and use privacy link in cookie noticeMarc Alexander2018-05-311-0/+2
| | | | | | | | | | | | PHPBB3-15676
| * | [ticket/15676] Display privacy notice in footer & allow overriding U_PRIVACYMarc Alexander2018-05-311-2/+24
| | | | | | | | | | | | PHPBB3-15676
* | | [ticket/15695] Fix gen_rand_string returning less characters than expectedRubén Calvo2018-06-181-4/+6
| |/ |/| | | | | PHPBB3-15695
* | [ticket/15693] Update tests to reflect changes to gen_rand_string()Marc Alexander2018-06-171-0/+4
| | | | | | | | PHPBB3-15693
* | [ticket/15693] Fix get_rand_string()Rubén Calvo2018-06-151-2/+2
|/ | | | PHPBB3-15693
* Merge pull request #5074 from marc1706/ticket/15498Marc Alexander2018-01-071-1/+1
|\ | | | | | | [ticket/15498] Do not pass whether URL uses router to is_route
| * [ticket/15498] Do not pass whether URL uses router to is_routeMarc Alexander2018-01-061-1/+1
| | | | | | | | | | | | | | | | is_route expects a flag of whether this is a route that was generated with the router as opposed to is_router_used() which returns whether the router will be used via app.php. PHPBB3-15498
* | Merge remote-tracking branch 'upstream/3.2.x' into prep-release-3.2.2Marc Alexander2018-01-071-15/+15
|\ \
| * | [ticket/14972] Fix sizeof callsrxu2018-01-011-15/+15
| |/ | | | | | | | | | | | | | | | | | | As of PHP 7.2, only arrays and objects implementing the Countable interface should be passed as a count() or sizeof() parameter. See https://github.com/php/php-src/blob/php-7.2.0alpha2/UPGRADING#L197-L198 Also, sizeof() seems to be sheduled for deprecation, see https://wiki.php.net/rfc/deprecations_php_7_2#suggested_deprecations PHPBB3-14972
* | Merge branch 'ticket/security/211' into ticket/security/211-rheaMarc Alexander2018-01-011-2/+7
|\ \ | |/ |/|
| * [ticket/security/211] Do not match javascript URIs with URL regexesMarc Alexander2017-07-261-2/+2
| | | | | | | | SECURITY-211
| * [ticket/security/211] Make sure website URL only uses http & https schemesMarc Alexander2017-07-221-0/+5
| | | | | | | | SECURITY-211