| Commit message (Collapse) | Author | Age | Files | Lines |
... | |
|
|
|
|
|
| |
This change is somewhat questionable, maybe it should be reviewed.
PHPBB3-10003
|
|
|
|
| |
PHPBB3-10003
|
|\
| |
| |
| |
| | |
* callumacrae/ticket/10112:
[ticket/10112] Replaced a couple occurrences of count() with sizeof()
|
| |
| |
| |
| |
| |
| | |
As per the coding guidlines, sizeof() should be used instead of count().
PHPBB3-10112
|
|\ \
| | |
| | |
| | |
| | | |
* ticket/jellydoughnut/9946:
[ticket/9946] Allow storage of data >4kB on Oracle again
|
| |/
| |
| |
| |
| |
| | |
This fixes the fix to PHPBB3-9132, which introduced a fatal error on Oracle.
PHPBB3-9946
|
| |
| |
| |
| |
| |
| |
| |
| | |
To have a generic solution there is now a sql_buffer_nested_transaction()
which indicates that the given SQL driver requires buffering to run a
transaction while iterating over another result set.
PHPBB3-9685
|
| |
| |
| |
| | |
PHPBB3-10057
|
| |
| |
| |
| | |
PHPBB3-10057
|
| |
| |
| |
| |
| |
| | |
This necessitates adding connect_error property to firebird.
PHPBB3-10057
|
| |
| |
| |
| | |
PHPBB3-10057
|
| |
| |
| |
| |
| |
| |
| |
| | |
pg_last_error does not work if no connection was ever established.
Therefore we must keep track of connection errors in postgres
dbal ourselves.
PHPBB3-10057
|
| |
| |
| |
| |
| |
| |
| | |
ibase_errmsg works for the most recent call. If the connection
fails, any error message is clobbered by ibase_service_attach call.
PHPBB3-10057
|
| |
| |
| |
| |
| |
| |
| |
| | |
Calling nonexistent functions with @ destroys the script with
no feedback as to the cause of the error. Check whether
interbase functions exist before calling them.
PHPBB3-10057
|
| |
| |
| |
| | |
PHPBB3-10057
|
| |
| |
| |
| |
| |
| | |
This change is in its own commit because it will be reverted for 3.1.
PHPBB3-10057
|
| |
| |
| |
| |
| |
| |
| | |
Replaced error collection functions with a class for a cleaner
implementation.
PHPBB3-10057
|
| |
| |
| |
| |
| |
| |
| | |
When pg_connect/pg_pconnect do not exist, mention that they come
with pgsql extension.
PHPBB3-10057
|
|/
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Addresses two issues:
1. When pgsql extension is missing, @pg_connect would silently
abort execution. Check for pg_connect existence before calling it,
same with pg_pconnect.
2. When connection fails, the error reported by php is discarded.
User is shown the failure message without the reason for failure,
making debugging difficult. Collect the error (if any) via a
temporarily installed error handler, and display it if connection
failed.
PHPBB3-10057
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Standard HTML output now includes:
Powered by <a href="http://www.phpbb.com/">phpBB</a> © phpBB Group
Print output now includes:
Powered by phpBB © phpBB Group<br />http://www.phpbb.com/
This also fixes an inconsistency where "phpBB Group" was linked instead of
"phpBB".
PHPBB3-9859
|
|\
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
* task/naderman/mssql-db-tests:
[task/mssql-db-tests] Remove MS SQL helper values from SELECT LIMIT results.
[task/mssql-db-tests] Split up database tests into SELECT and write operations
[task/mssql-db-tests] PHPUnit output got stuck after unterminated ob_start.
[task/mssql-db-tests] sql_query_limit must return all results when total = 0
[task/mssql-db-tests] Add support for odbc & sqlsrv PDO test connections
[task/mssql-db-tests] Refactored getConnection into multiple smaller parts.
[task/mssql-db-tests] Allow test configuration with environment variables.
[task/mssql-db-tests] No longer display an error when skipping db tests.
[task/mssql-db-tests] Use a simple getter for test case helpers.
|
| |
| |
| |
| | |
PHPBB3-9868
|
| |
| |
| |
| | |
PHPBB3-9868
|
|/
|
|
|
|
|
|
|
| |
We require version 1.1 of the sqlsrv extension anyway so the regular
sqlsrv_num_rows can be used instead of buffering the result. The result
buffer (class result_mssqlnative) should never automatically free the
resource it receives - we consistently close resources using sql_freeresult().
PHPBB3-9686
|
|\
| |
| |
| |
| |
| | |
* ticket/evil3/8944:
[ticket/8944] Patch db_tools to support index length for MySQL4
[ticket/8944] Add index length to CREATE INDEX for MySQL4 in database_update
|
| | |
|
|/
|
|
| |
PHPBB3-9039
|
|\
| |
| |
| |
| | |
* ticket/kellanved/9521:
[ticket/9521] Fix error reporting for the native SQL Server plugin.
|
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The native SQL Server plugin used to return an error string when calling
sql_error. However, some error condition checks are done using is_array.
This patch wraps the error into an array to follow the error logic used
elsewhere.
PHPBB3-9521
|
|\ \
| | |
| | |
| | |
| | | |
* ticket/jellydoughnut/9637:
[ticket/9637] Do not cache SQL server version in all cases
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Because the existing cache is global, there is no way to differentiate between
each of two databases which may be two different DBAL objects pointing to
servers with wildly different versions of an RDBMS. phpBB only has this
situation in the UCF, thus only one file changed outside the DBAL. I have
added a second optional parameter, $use_cache to each of the implementations
of dbal::sql_server_info()
PHPBB3-9637
|
|\ \ \
| | | |
| | | |
| | | |
| | | | |
* ticket/bantu/9643:
[ticket/9643] Only split $port from $sqlserver, if it's not an IPv6 address.
|
| |/ /
| | |
| | |
| | | |
PHPBB3-9643
|
|/ /
| |
| |
| |
| |
| | |
This reverts Oracle support to the state it was in prior to phpBB 3.0.6. That is, storage of long strings works again (e.g. posts > 4 KB), but the database backup/restore functionality is broken. We feel that the ability to store long strings is more important than the DB restore, since Oracle 10g itself provides tools for backing up databases.
PHPBB3-9132
|
|/
|
|
|
|
|
|
| |
connection is forced.
pg_connect() takes an integer as the second parameter, but we were passing a boolean parameter. The function especially requires passing the PGSQL_CONNECT_FORCE_NEW constant if a new connection is to be forced. Passing 0 as the second parameter for 'do not force a new connection' doesn't work as expected, hence we're calling the function without a second parameter in this case.
PHPBB3-9518
|
|
|
|
|
|
| |
forums. -- Voila ;-)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10491 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
| |
r10489 [Bug #57055]
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10490 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Pucci at Microsoft [Bug #57055]
If you are using SQL Server, please try to test this new dbal so we can safely include it in 3.0.8. If you
want to try it on a current phpBB version you can apply the latest version of the patch to your board which
you can find attached to the bug tracker ticket (look in the comments for the latest version, the one in the
ticket itself is outdated): http://www.phpbb.com/bugs/phpbb3/ticket.php?ticket_id=57055
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10489 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
| |
when using PostgreSQL <= 7.4 [Bug #54435]
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10446 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
|
| |
Note: As pointed out by gn#36, phpBB doesn't use persistent connections at all.
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10375 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
|
|
| |
Fix Bug #53335
Fix wrong unique index fetch for oracle and sqlite
Fix alter column definition for firebird (although the query will fail in these circumstances [primary key] because firebird (again) does not support simple things... although... mssql/oracle having the same "problems", but there you are able to do more advanced queries)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10248 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
| |
consist of not detecting correct parameters and then resulting in partial WHERE statements, where non-detected strings are simply removed. grrrrrr
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10247 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
| |
(better sooner than later), but retaining backwards compatibility.
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10246 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
| |
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10231 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
|
|
| |
- fix index check for sqlite, firebird and oracle
- add check for unique index
- fix changing default value for column in mssql (add constraint)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10185 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
| |
allow for queries > 4k to let it recognise concatenated strings and strings having the character ")" in it. I also added fallback code in case our regex splits too much. :/
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10175 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
| |
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@10041 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
| |
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9970 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
|
|
|
|
|
| |
Generally, our config table is not really suited for holding large datasets. Because feed settings for the forums to enable news feeds and excluded forums rely on the forums itself we have decided to introduce a forum_options table where custom options can be stored.
Additionally, for this to work across all DBMS we support, we added a new method to the DBAL for the bitwise AND operator.
Also moved the forum/topic feed template variable to the location where they belong to (forum and topic view)
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9965 89ea8834-ac86-4346-8a33-228a782c2dd0
|
|
|
|
| |
git-svn-id: file:///svn/phpbb/branches/phpBB-3_0_0@9911 89ea8834-ac86-4346-8a33-228a782c2dd0
|