Commit message (Collapse) | Author | Age | Files | Lines | |
---|---|---|---|---|---|
* | [ticket/12720] Allow commit heading to begin with lowercase letters | Dhruv | 2014-06-16 | 1 | -2/+2 |
| | | | | PHPBB3-12720 | ||||
* | [ticket/11630] Improvements to the PHP lint pre-commit hook | Matthew Fonda | 2013-07-06 | 1 | -52/+5 |
| | | | | | | | | | | The PHP lint pre-commit hook fails to display any output when an error other than a parse error is decteced. Additionally, the hook may not display any meaningful output depending on php.ini settings. This commit removes the dependency on php.ini. PHPBB3-11630 | ||||
* | [ticket/10767] Clarify what happens at the end of the hook. | Oleg Pudeyev | 2012-04-17 | 1 | -1/+8 |
| | | | | | | | | | | If there are problems and fatal is true, print that the commit is aborted. If there are problems and fatal is false, print instructions for fixing the commit. PHPBB3-10767 | ||||
* | [ticket/10767] Use warning/error language as appropriate. | Oleg Pudeyev | 2012-04-17 | 1 | -1/+3 |
| | | | | | | | | | | | When commit-msg hook is fatal, label the message as an error. When it is not fatal, label the message as a warning. "Syntax error" is still always an error, not sure if this should be changed. PHPBB3-10767 | ||||
* | [ticket/10767] Default to non-fatal behavior. | Oleg Pudeyev | 2012-04-17 | 1 | -4/+6 |
| | | | | PHPBB3-10767 | ||||
* | [ticket/10767] Revert unconditional unfatality in commit-msg hook. | Oleg Pudeyev | 2012-04-16 | 1 | -3/+18 |
| | | | | | | | | | Revert "[ticket/10093] Make commit-msg always not fatal by nuking all fatal logic." This reverts commit 88cad5523e7cdac6826dd8581e27e22a65afda26. PHPBB3-10093 PHPBB3-10767 | ||||
* | [ticket/10760] Fix numbering in php fun facts. | Oleg Pudeyev | 2012-04-04 | 1 | -5/+5 |
| | | | | PHPBB3-10760 | ||||
* | [ticket/10760] Value must be quoted as it might be two words. | Oleg Pudeyev | 2012-04-04 | 1 | -1/+1 |
| | | | | PHPBB3-10760 | ||||
* | [ticket/10760] PHP is great. This commit is the proof. | Oleg Pudeyev | 2012-04-04 | 1 | -0/+24 |
| | | | | PHPBB3-10760 | ||||
* | [ticket/10760] Catch both versions of parse error output in php. | Oleg Pudeyev | 2012-04-04 | 1 | -0/+14 |
| | | | | PHPBB3-10760 | ||||
* | [ticket/10760] Account for display_errors=stderr in pre-commit hook. | Oleg Pudeyev | 2012-04-03 | 1 | -1/+7 |
| | | | | | | | | | With that php.ini value set errors are printed to stderr, therefore by redirecting stderr to /dev/null we also throw out the errors. Instead merge stderr into stdout. PHPBB3-10760 | ||||
* | [ticket/10760] Quote PHP_BIN when using it. | Oleg Pudeyev | 2012-04-03 | 1 | -2/+2 |
| | | | | | | This should make a difference on windows where paths may include spaces. PHPBB3-10760 | ||||
* | [ticket/10760] Use echo -e only if echo understands -e. | Oleg Pudeyev | 2012-04-03 | 1 | -2/+9 |
| | | | | | | | | | /bin/echo on freebsd and dash's builtin echo do not understand -e, therefore -e is printed with the other messages in such cases. Test if echo understands -e, if not do not use it. PHPBB3-10760 | ||||
* | [ticket/10760] Use externally specified PHP_BIN if any. | Oleg Pudeyev | 2012-04-03 | 1 | -3/+5 |
| | | | | | | | | | | | | | We have a PHP_BIN variable but we always set it unconditionally, therefore in order to use a different php binary one had to modify the hook script. Instead set PHP_BIN if it is not set. Now one can set PHP_BIN in their environment to use a non-default php binary. PHPBB3-10760 | ||||
* | [ticket/10093] Use correct ANSI code for clearing color. | Oleg Pudeyev | 2011-12-03 | 1 | -2/+2 |
| | | | | PHPBB3-10093 | ||||
* | [ticket/10093] Make commit-msg always not fatal by nuking all fatal logic. | Oleg Pudeyev | 2011-12-03 | 1 | -18/+3 |
| | | | | PHPBB3-10093 | ||||
* | [ticket/10093] Use color in commit-msg hook warning/error messages. | Oleg Pudeyev | 2011-11-26 | 1 | -1/+50 |
| | | | | | | | By default color is used if the message is printed to a tty, phpbb.hooks.commit-msg.color configuration setting can override this. PHPBB3-10093 | ||||
* | [ticket/10093] Refactor complaining in commit-msg hook for color support. | Oleg Pudeyev | 2011-11-26 | 1 | -17/+22 |
| | | | | PHPBB3-10093 | ||||
* | [ticket/10093] Respect phpbb.hooks.commit-msg.fatal on syntax errors. | Oleg Pudeyev | 2011-11-26 | 1 | -1/+1 |
| | | | | PHPBB3-10093 | ||||
* | [ticket/10093] Document phpbb.hooks.commit-msg.fatal setting. | Oleg Pudeyev | 2011-11-26 | 1 | -0/+5 |
| | | | | PHPBB3-10093 | ||||
* | Merge branch 'ticket/p/10092' into develop-olympus | Andreas Fischer | 2011-03-14 | 1 | -1/+1 |
|\ | | | | | | | | | * ticket/p/10092: [ticket/10092] Ignore overlength comment lines in commit-msg hook. | ||||
| * | [ticket/10092] Ignore overlength comment lines in commit-msg hook. | Oleg Pudeyev | 2011-03-11 | 1 | -1/+1 |
| | | | | | | | | PHPBB3-10092 | ||||
* | | [ticket/10078] Avoid \n in strings given to echo for portability. | Oleg Pudeyev | 2011-03-11 | 1 | -2/+3 |
|/ | | | | | | | Also preserve whitespace (including newlines) when printing the lines that exceed 80 character limit. PHPBB3-10078 | ||||
* | [ticket/9824] Accept commit messages with less than perfect headings. | Oleg Pudeyev | 2011-03-01 | 1 | -1/+13 |
| | | | | | | | | Some commit messages exist only temporarily, because they are given on commits that are intended to be squashed. Accept such commit messages with a warning. PHPBB3-9824 | ||||
* | [ticket/9824] Allow empty lines after ticket reference. | Oleg Pudeyev | 2011-03-01 | 1 | -1/+8 |
| | | | | PHPBB3-9824 | ||||
* | [ticket/9824] Use printf instead of echo to render \n. | Oleg Pudeyev | 2011-03-01 | 1 | -1/+1 |
| | | | | | | On FreeBSD `echo "\n"` prints \n verbatim. Use printf instead. PHPBB3-9824 | ||||
* | [ticket/9824] Handle empty commit messages in commit-msg hook. | Oleg Pudeyev | 2011-03-01 | 1 | -0/+11 |
| | | | | | | | | | Git already handles the case of commit message being empty by aborting the commit and displaying a reasonably helpful message. If there is no commit message, the hook will exit with success exit code to let git do its thing. PHPBB3-9824 | ||||
* | [ticket/9824] Add space after [ticket/12345] in prepared commit message. | Andreas Fischer | 2011-03-02 | 1 | -1/+1 |
| | | | | PHPBB3-9824 | ||||
* | [ticket/9824] Remove space after PHPBB3-12345 in prepared commit message. | Andreas Fischer | 2011-03-02 | 1 | -1/+1 |
| | | | | PHPBB3-9824 | ||||
* | Merge branch 'task/cs278/git-tools' into develop-olympus | Igor Wiedler | 2010-09-09 | 1 | -4/+5 |
|\ | | | | | | | | | | | * task/cs278/git-tools: [task/git-tools] Change the GNU --lines argument to the POSIX -l [task/git-tools] Solve dependency on the GNU wc --max-line-length option | ||||
| * | [task/git-tools] Change the GNU --lines argument to the POSIX -l | Chris Smith | 2010-09-08 | 1 | -1/+1 |
| | | | | | | | | | | | | | | | | Changed to awk which handles the formatting differences between the two versions of wc -- BSD version prefixes the output with spaces, the GNU version does not. PHPBB3-9808 | ||||
| * | [task/git-tools] Solve dependency on the GNU wc --max-line-length option | Chris Smith | 2010-09-07 | 1 | -3/+4 |
| | | | | | | | | PHPBB3-9808 | ||||
* | | [ticket/9777] Print error message in pre-commit hook when php is not installed. | Oleg Pudeyev | 2010-08-19 | 1 | -0/+7 |
|/ | | | | PHPBB3-9777 | ||||
* | [task/git-tools] Ignore git commit message comments | Chris Smith | 2010-08-10 | 1 | -1/+13 |
| | | | | | | | Git commit message comments can be contained anywhere in the message and this change ignores where they appear. PHPBB3-9768 | ||||
* | [task/git-tools] Adjust the hook to enforce that a ticket is always mentioned | Chris Smith | 2010-08-10 | 1 | -2/+2 |
| | | | | PHPBB3-9768 | ||||
* | [task/git-tools] Vastly expanded commit-msg hook. | Chris Smith | 2010-08-10 | 1 | -5/+224 |
| | | | | | | | | | | | | | | | | This updated hook supports validates each line of the commit message confirms to the phpBB standards [1], there are two git config options which adjust the behaviour of the hook. They are: * phpbb.hooks.commit-msg.fatal: Set to false for the hook to allow commits with malformed structure, useful if you'll be squashing or editing the commits later. True is the default value. * phpbb.hooks.commit-msg.debug: Any integer value greater than 0 will increase the debugging verbosity of the hook, the default value is 0. [1] http://wiki.phpbb.com/display/DEV/Git PHPBB3-9768 | ||||
* | [task/git-tools] Beginnings of a syntax checking hook. | Chris Smith | 2010-08-10 | 1 | -0/+26 |
| | | | | | | Currently this hook checks line length is less than or equal to 80 characters. PHPBB3-9768 | ||||
* | [task/git-tools] Append ticket identifier to commit message prior to editing. | Chris Smith | 2010-08-10 | 2 | -25/+9 |
| | | | | PHPBB3-9770 | ||||
* | [task/git-tools] add install and uninstall scripts for hooks | Igor Wiedler | 2010-07-12 | 2 | -0/+33 |
| | | | | PHPBB3-9769 | ||||
* | [task/git-tools] move ticket id appending to commit-msg hook | Igor Wiedler | 2010-07-12 | 2 | -7/+24 |
| | | | | PHPBB3-9770 | ||||
* | [task/git-tools] append ticket id to git log message | Igor Wiedler | 2010-07-12 | 1 | -0/+7 |
| | | | | PHPBB3-9770 | ||||
* | [git-tools] Use @ instead of : in sed command in pre-commit hook for wider ↵ | Oleg Pudeyev | 2010-04-13 | 1 | -1/+1 |
| | | | | compatibility. | ||||
* | [git-tools] Adjusted pre-commit hook to run under freebsd /bin/sh. | Oleg Pudeyev | 2010-04-13 | 1 | -2/+5 |
| | |||||
* | [git-tools] Changed pre-commit hook to use sh instead of bash | Oleg Pudeyev | 2010-04-13 | 1 | -1/+1 |
| | |||||
* | [git-tools] add note about PHP_BIN using env | Igor Wiedler | 2010-04-03 | 1 | -0/+1 |
| | |||||
* | [git-tools] do not display stderr | Igor Wiedler | 2010-04-03 | 1 | -1/+1 |
| | |||||
* | [git-tools] Prepend the branch to the commit message for all branches. | Chris Smith | 2010-04-03 | 1 | -1/+1 |
| | |||||
* | [git-tools] Use env to find the correct paths to binaries. | Chris Smith | 2010-04-03 | 1 | -2/+2 |
| | |||||
* | [git-tools] Display what parse errors were found. | Chris Smith | 2010-04-03 | 1 | -1/+6 |
| | |||||
* | [git-tools] This script requires bash to run, so point directly to bash. | Chris Smith | 2010-04-03 | 1 | -1/+1 |
| |