aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | | | [feature/request-class] Request class test now uses a type cast helper mock.Nils Adermann2010-09-174-8/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Removed the dependency of the request class test on having an actual phpbb_type_cast_helper instance, by replacing it with an object mocking the phpbb_type_cast_helper_interface. PHPBB3-9716
| * | | | | | | | | [feature/request-class] Refactored request class and wrapper functions.Nils Adermann2010-09-176-173/+56
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The request class - now makes use of the new type cast helper (dependency injection) - has no static methods anymore. - now has a constructor argument to leave super globals turned on Brought back the set_var function in functions.php. It is now a wrapper around the type cast helper. It creates an instance on the fly. The request_var wrapper function now has an optional last argument to inject the request class instance, rather than abusing the $var_name. PHPBB3-9716
| * | | | | | | | | [feature/request-class] Extracted type casting helpers from the request class.Nils Adermann2010-09-173-0/+274
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | These methods should be available without having to instantiate a request class object, better separation of concerns. A set_var wrapper around this class no longer requires a request object at all. PHPBB3-9716
| * | | | | | | | | [feature/request-class] Replace direct use of GET/REQUEST with request_var.Nils Adermann2010-09-172-8/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Now with $_VARs causing fatal errors we should really be able to find and delete all of these occurances. PHPBB3-9716
| * | | | | | | | | [feature/request-class] Use the request class in the installer & updater.Nils Adermann2010-09-172-4/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Just like common.php database_update.php and install/index.php need to include the request class files and create an instance for use in request_var. PHPBB3-9716
| * | | | | | | | | [feature/request-class] request_var should return after setting the request ↵Nils Adermann2010-09-171-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | object. If the "dependency injection" mechanism is used there should not be any regular computation of a result value. request_var has to return immediately. PHPBB3-9716
| * | | | | | | | | [feature/request-class] Instantiate a global request class instance.Nils Adermann2010-09-171-1/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | It should at all cost be avoided to rely on this global variable. Instead either use the request_var method (deprecated) or pass the instance to your function as a parameter or to your object as a contructor argument or through a setter function. PHPBB3-9716
| * | | | | | | | | [feature/request-class] New request class supports recursive arrays.Nils Adermann2010-09-171-2/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | So we can enable this old 3 level deep array input entry in the request_var data provider, it is now also supported! PHPBB3-9716
| * | | | | | | | | [feature/request-class] Adding a request class based on ascraeus-experiment.Nils Adermann2010-09-179-174/+789
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The well known request_var function is now a wrapper that calls a method on a phpbb_request object. The class provides additional functionality. It can replace all super globals with special objects that throw errors when being accessed. They still allow isset operations to keep backward compatibility with isset($_POST['var']) checks. The phpbb_request class implements the phpbb_request_interface which is available for easy mocking of input in tests. PHPBB3-9716
* | | | | | | | | | Merge branch 'ticket/bantu/9792' into developIgor Wiedler2010-10-042-395/+412
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9792: [ticket/9792] Move function definitions out of download/file.php Conflicts: phpBB/download/file.php
| * | | | | | | | | | [ticket/9792] Move function definitions out of download/file.phpAndreas Fischer2010-08-302-394/+411
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Move functions defined in download/file.php out to includes/functions_download.php so they can be properly reused and unit tested. PHPBB3-9792
* | | | | | | | | | | Merge branch 'develop-olympus' into developIgor Wiedler2010-10-042-5/+2
|\ \ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / / |/| | / / / / / / / / | | |/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9804] Account evil3 renamed to igorw, adjust AUTHORS [ticket/9829] Fix error in recaptcha validation.
| * | | | | | | | | Merge branch 'ticket/bantu/9829' into develop-olympusIgor Wiedler2010-10-041-4/+1
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9829: [ticket/9829] Fix error in recaptcha validation.
| | * | | | | | | | | [ticket/9829] Fix error in recaptcha validation.Cristian Rodriguez2010-09-191-4/+1
| | | |_|_|_|_|/ / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The recaptcha plugin falsely accepted error responses by recaptcha as valid solutions. PHPBB3-9829
| * | | | | | | | | Merge branch 'ticket/igorw/9804' into develop-olympusAndreas Fischer2010-09-241-1/+1
| |\ \ \ \ \ \ \ \ \ | | |/ / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/igorw/9804: [ticket/9804] Account evil3 renamed to igorw, adjust AUTHORS
| | * | | | | | | | [ticket/9804] Account evil3 renamed to igorw, adjust AUTHORSIgor Wiedler2010-09-211-1/+1
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9804
* | | | | | | | | Merge branch 'develop-olympus' into developIgor Wiedler2010-09-163-0/+13
|\ \ \ \ \ \ \ \ \ | |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9091] Extract IPv4 address from addresses mapped into IPv6.
| * | | | | | | | Merge branch 'ticket/bantu/9091' into develop-olympusIgor Wiedler2010-09-163-0/+13
| |\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9091: [ticket/9091] Extract IPv4 address from addresses mapped into IPv6.
| | * | | | | | | | [ticket/9091] Extract IPv4 address from addresses mapped into IPv6.Andreas Fischer2010-07-233-0/+13
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9091
* | | | | | | | | | Merge branch 'develop-olympus' into developIgor Wiedler2010-09-162-12/+29
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9825] Add unit test config and db to gitignore [ticket/9825] Unit tests: Use sqlite when possible and no test_config exists.
| * | | | | | | | | Merge branch 'ticket/bantu/9825' into develop-olympusIgor Wiedler2010-09-162-12/+29
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9825: [ticket/9825] Add unit test config and db to gitignore [ticket/9825] Unit tests: Use sqlite when possible and no test_config exists.
| | * | | | | | | | | [ticket/9825] Add unit test config and db to gitignoreIgor Wiedler2010-09-161-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9825
| | * | | | | | | | | [ticket/9825] Unit tests: Use sqlite when possible and no test_config exists.Andreas Fischer2010-09-161-11/+26
| | | |_|_|/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9825
* | | | | | | | | | Merge branch 'develop-olympus' into developIgor Wiedler2010-09-1613-20/+38
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9609] Change header() calls setting HTTP status to send_status_line(). [ticket/9613] Slightly update language strings. [ticket/9613] Fix missing database part for unread posts search load switch. [ticket/9613] Implement a load switch for unread posts search feature. [ticket/9785] Allow users to request new passwords when board is disabled. [ticket/9644] Check $mode before calling user_notification() from submit_post()
| * | | | | | | | | Merge branch 'ticket/bantu/9644' into develop-olympusIgor Wiedler2010-09-161-1/+1
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9644: [ticket/9644] Check $mode before calling user_notification() from submit_post()
| | * | | | | | | | | [ticket/9644] Check $mode before calling user_notification() from submit_post()Andreas Fischer2010-07-231-1/+1
| | | |/ / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9644
| * | | | | | | | | Merge branch 'ticket/bantu/9613' into develop-olympusIgor Wiedler2010-09-169-5/+22
| |\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9613: [ticket/9613] Slightly update language strings. [ticket/9613] Fix missing database part for unread posts search load switch. [ticket/9613] Implement a load switch for unread posts search feature.
| | * | | | | | | | | [ticket/9613] Slightly update language strings.Andreas Fischer2010-08-293-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9613
| | * | | | | | | | | [ticket/9613] Fix missing database part for unread posts search load switch.rxu2010-08-292-0/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A record for load_unreads_search parameter had to be added to CONFIG_TABLE. PHPBB3-9613
| | * | | | | | | | | [ticket/9613] Implement a load switch for unread posts search feature.rxu2010-08-297-5/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Since unread posts search can produce a high server load in certain circumstances, we implement a switch for ACP "Load settings" to have an option to disable this type of search. PHPBB3-9613
| * | | | | | | | | | Merge branch 'ticket/bantu/9785' into develop-olympusIgor Wiedler2010-09-161-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9785: [ticket/9785] Allow users to request new passwords when board is disabled.
| | * | | | | | | | | | [ticket/9785] Allow users to request new passwords when board is disabled.Andreas Fischer2010-08-221-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9785
| * | | | | | | | | | | Merge branch 'ticket/bantu/9609' into develop-olympusIgor Wiedler2010-09-163-13/+14
| |\ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|/ / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9609: [ticket/9609] Change header() calls setting HTTP status to send_status_line().
| | * | | | | | | | | | [ticket/9609] Change header() calls setting HTTP status to send_status_line().Andreas Fischer2010-09-113-13/+14
| | | |_|_|_|/ / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9609
* | | | | | | | | | | Merge branch 'develop-olympus' into developAndreas Fischer2010-09-152-15/+49
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9592] Slight adjustments to simplify db test cases [ticket/9592] Remove test cases for empty IN() [ticket/9592] Test suite does not run on SQlite
| * | | | | | | | | | Merge branch 'ticket/evil3/9592' into develop-olympusAndreas Fischer2010-09-152-15/+49
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/evil3/9592: [ticket/9592] Slight adjustments to simplify db test cases [ticket/9592] Remove test cases for empty IN() [ticket/9592] Test suite does not run on SQlite
| | * | | | | | | | | | [ticket/9592] Slight adjustments to simplify db test casesIgor Wiedler2010-09-151-11/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9592
| | * | | | | | | | | | [ticket/9592] Remove test cases for empty IN()Igor Wiedler2010-09-121-2/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | They failed under SQLite because SQLite accepts empty IN() syntax. PHPBB3-9592
| | * | | | | | | | | | [ticket/9592] Test suite does not run on SQliteIgor Wiedler2010-09-111-11/+47
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9592
* | | | | | | | | | | | Merge branch 'develop-olympus' into developAndreas Fischer2010-09-142-11/+15
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9820] phpBB Debug Error when trying to post a new topic. [ticket/9162] BBCode in poll options is broken, when posting without question. [ticket/9804] Update docs/AUTHORS. Move DavidMJ, add evil<3.
| * | | | | | | | | | | Merge branch 'ticket/nickvergessen/9162' into develop-olympusAndreas Fischer2010-09-141-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/nickvergessen/9162: [ticket/9162] BBCode in poll options is broken, when posting without question.
| | * | | | | | | | | | | [ticket/9162] BBCode in poll options is broken, when posting without question.Joas Schilling2010-09-141-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9162
| * | | | | | | | | | | | Merge branch 'ticket/nickvergessen/9820' into develop-olympusAndreas Fischer2010-09-141-9/+12
| |\ \ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/nickvergessen/9820: [ticket/9820] phpBB Debug Error when trying to post a new topic.
| | * | | | | | | | | | | [ticket/9820] phpBB Debug Error when trying to post a new topic.Joas Schilling2010-09-141-9/+12
| |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Regression from aa4519fb44f4ff83e923c6cc4d5bde3f20082340 PHPBB3-9820 PHPBB3-7260
| * | | | | | | | | | | Merge branch 'ticket/bantu/9804' into develop-olympusIgor Wiedler2010-09-121-1/+2
| |\ \ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9804: [ticket/9804] Update docs/AUTHORS. Move DavidMJ, add evil<3.
| | * | | | | | | | | | | [ticket/9804] Update docs/AUTHORS. Move DavidMJ, add evil<3.Andreas Fischer2010-09-121-1/+2
| | | |_|_|_|_|_|_|_|/ / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9804
* | | | | | | | | | | | Merge branch 'develop-olympus' into developIgor Wiedler2010-09-123-3/+3
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * develop-olympus: [ticket/9754] Populate S_USER_POSTED variable with correct value in search.php [ticket/9748] Replace <br /> before converting < and > to their entities. [ticket/9503] Show 'No subject specified' in 'Posts awaiting approval'.
| * | | | | | | | | | | Merge branch 'ticket/bantu/9748' into develop-olympusIgor Wiedler2010-09-121-1/+1
| |\ \ \ \ \ \ \ \ \ \ \ | | |_|_|_|_|_|_|_|/ / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9748: [ticket/9748] Replace <br /> before converting < and > to their entities.
| | * | | | | | | | | | [ticket/9748] Replace <br /> before converting < and > to their entities.Richard Foote2010-07-241-1/+1
| | | |_|_|_|_|/ / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9748
| * | | | | | | | | | Merge branch 'ticket/bantu/9503' into develop-olympusIgor Wiedler2010-09-121-1/+1
| |\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9503: [ticket/9503] Show 'No subject specified' in 'Posts awaiting approval'.