aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
| * | | | | | | [ticket/10100] Update rand_seed_last_update before rand_seed in unique_id().Andreas Fischer2011-03-171-1/+1
|/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update $config['rand_seed_last_update'] before updating $config['rand_seed'] in unique_id() to mitigate a race condition and unnecessary updates on heavily busy boards. PHPBB3-10100
* | | | | | | Merge branch 'ticket/naderman/9685' into develop-olympusAndreas Fischer2011-03-153-3/+35
|\ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/naderman/9685: [ticket/9685] Buffer posts for search indexing when using mssqlnative.
| * | | | | | | [ticket/9685] Buffer posts for search indexing when using mssqlnative.Nils Adermann2011-03-153-3/+35
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | To have a generic solution there is now a sql_buffer_nested_transaction() which indicates that the given SQL driver requires buffering to run a transaction while iterating over another result set. PHPBB3-9685
* | | | | | | | Merge branch 'ticket/p/10096' into develop-olympusAndreas Fischer2011-03-141-1/+1
|\ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/p/10096: [ticket/10096] Fixed whitespace in functions.php.
| * | | | | | | | [ticket/10096] Fixed whitespace in functions.php.Oleg Pudeyev2011-03-131-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10096
* | | | | | | | | Merge branch 'ticket/p/10092' into develop-olympusAndreas Fischer2011-03-141-1/+1
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/p/10092: [ticket/10092] Ignore overlength comment lines in commit-msg hook.
| * | | | | | | | | [ticket/10092] Ignore overlength comment lines in commit-msg hook.Oleg Pudeyev2011-03-111-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10092
* | | | | | | | | | Merge branch 'ticket/p/10078' into develop-olympusAndreas Fischer2011-03-141-2/+3
|\ \ \ \ \ \ \ \ \ \ | |_|/ / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/p/10078: [ticket/10078] Avoid \n in strings given to echo for portability.
| * | | | | | | | | [ticket/10078] Avoid \n in strings given to echo for portability.Oleg Pudeyev2011-03-111-2/+3
| |/ / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Also preserve whitespace (including newlines) when printing the lines that exceed 80 character limit. PHPBB3-10078
* | | | | | | | | Merge branch 'ticket/bantu/8802' into develop-olympusOleg Pudeyev2011-03-122-2/+3
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/8802: [ticket/8802] Make FORUMS_MARKED more generic as it is also used for subforums. [ticket/8802] Rename "Mark forums read" to "Mark subforums read" for subforums.
| * | | | | | | | | [ticket/8802] Make FORUMS_MARKED more generic as it is also used for subforums.Andreas Fischer2011-03-101-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-8802
| * | | | | | | | | [ticket/8802] Rename "Mark forums read" to "Mark subforums read" for subforums.Andreas Fischer2011-03-102-1/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Clicking "Mark forums read" when not browsing on the index page only marks all subforums (and sub-sub forums etc.) read, topics in the current forum have to marked seperately by clicking the "Mark topics read" link. Let's indicate this circumstance by using the word "subforums". PHPBB3-8802
* | | | | | | | | | Merge branch 'ticket/erikfrerejean/9948' into develop-olympusOleg Pudeyev2011-03-122-4/+4
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|/ / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/erikfrerejean/9948: [ticket/9948] Inline quicktime files won't show
| * | | | | | | | | [ticket/9948] Inline quicktime files won't showErik Frèrejean2010-12-152-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When attaching a quicktime file and placing it inline the movie won't be shown due to the size the movie box is being given. PHPBB3-9948
* | | | | | | | | | Merge branch 'ticket/bantu/10088' into develop-olympusIgor Wiedler2011-03-121-0/+5
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/10088: [ticket/10088] Also ignore DBMS versions other than MySQLi in cache mock.
| * | | | | | | | | | [ticket/10088] Also ignore DBMS versions other than MySQLi in cache mock.Andreas Fischer2011-03-121-0/+5
| | |_|_|/ / / / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10088
* | | | | | | | | | Merge branch 'ticket/bantu/10046' into develop-olympusIgor Wiedler2011-03-123-90/+13
|\ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/10046: [ticket/10046] Do not link bots to cron.php. [ticket/10046] No longer change $phpbb_root_path to an absolute path for cron. [ticket/10046] Call flush() in cron.php [ticket/10046] Remove calls to register_shutdown_function() in cron.php
| * | | | | | | | | [ticket/10046] Do not link bots to cron.php.Oleg Pudeyev2011-03-121-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Bots, generally speaking, will not request cron.php immediately, thus telling them to request it is pointless. PHPBB3-10046
| * | | | | | | | | [ticket/10046] No longer change $phpbb_root_path to an absolute path for cron.Andreas Fischer2011-03-121-5/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is no longer required because we no longer call register_shutdown_function() which made this change necessary. PHPBB3-10046
| * | | | | | | | | [ticket/10046] Call flush() in cron.phpAndreas Fischer2011-03-121-3/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10046
| * | | | | | | | | [ticket/10046] Remove calls to register_shutdown_function() in cron.phpAndreas Fischer2011-03-121-81/+10
|/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | After reading some PHP source as well as the PHP manual we have arrived at the following two situations with one conclusion: * SAPI supports flush(): o call to flush() is enough to stop the page from displaying as loading o and thus register_shutdown_function is unnecessary * SAPI does not support flush(): o neither a call to flush() nor the beginning of shutdown phase, which calls registered shutdown functions can flush anything to the client o and thus register_shutdown_function is unnecessary Thanks to lacton for reporting the initial issue. Thanks to nn- and naderman for doing all the dirty works. PHPBB3-10046
* | | | | | | | | Merge branch 'ticket/bantu/9970' into develop-olympusOleg Pudeyev2011-03-113-3/+28
|\ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/bantu/9970: [ticket/9970] Rename validate_language() to validate_language_iso_name(). [ticket/9970] Do not allow switching to languages not installed on reg. page. [ticket/9970] Check whether language pack is installed. [ticket/9970] User language input is checked for existance
| * | | | | | | | | [ticket/9970] Rename validate_language() to validate_language_iso_name().Andreas Fischer2011-03-073-9/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9970
| * | | | | | | | | [ticket/9970] Do not allow switching to languages not installed on reg. page.Andreas Fischer2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9970
| * | | | | | | | | [ticket/9970] Check whether language pack is installed.Andreas Fischer2011-03-071-19/+14
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-9970
| * | | | | | | | | [ticket/9970] User language input is checked for existanceJosh Woody2011-03-073-2/+32
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Users could select a language which did not exist in the database by altering form fields because there was no back-end verification. PHPBB3-9970
* | | | | | | | | | Merge branch 'ticket/erikfrerejean/10090' into develop-olympusOleg Pudeyev2011-03-111-0/+1
|\ \ \ \ \ \ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/erikfrerejean/10090: [ticket/10090] Add phpBB/cache/queue.php.lock to the gitignore
| * | | | | | | | | | [ticket/10090] Add phpBB/cache/queue.php.lock to the gitignoreErik Frèrejean2011-03-101-0/+1
| | |_|_|_|_|_|_|_|/ | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10090
* | | | | | | | | | Merge branch 'ticket/p/10016' into develop-olympusAndreas Fischer2011-03-111-1/+5
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/p/10016: [ticket/10016] Add comment for text casting (for PostgreSQL 7.x) [ticket/10016] Leave Firebird unchanged. [ticket/10016] Fixed varchar to decimal cast on postgresql 7.x.
| * | | | | | | | | [ticket/10016] Add comment for text casting (for PostgreSQL 7.x)Andreas Fischer2011-03-051-0/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10016
| * | | | | | | | | [ticket/10016] Leave Firebird unchanged.Andreas Fischer2011-03-051-0/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10016
| * | | | | | | | | [ticket/10016] Fixed varchar to decimal cast on postgresql 7.x.Oleg Pudeyev2011-01-281-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10016
* | | | | | | | | | Merge branch 'ticket/rxu/10035' into develop-olympusOleg Pudeyev2011-03-101-1/+1
|\ \ \ \ \ \ \ \ \ \ | |_|_|_|_|/ / / / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/rxu/10035: [ticket/10035] ACP template edit feature allows to read any files on webserver.
| * | | | | | | | | [ticket/10035] ACP template edit feature allows to read any files on webserver.rxu2011-03-071-1/+1
| | |_|_|_|/ / / / | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ... and to upload/execute any script on it. Use preg_replace to filter filename PHPBB3-10035
* | | | | | | | | Merge branch 'ticket/p/10057' into develop-olympusAndreas Fischer2011-03-093-4/+142
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * ticket/p/10057: [ticket/10057] Fixes for a bunch of small problems. [ticket/10057] Handle the case of missing interbase extension better. [ticket/10057] Fixed wrong usage of sql_error again, in firebird. [ticket/10057] Fixed usage of sql_error again. [ticket/10057] Condition file/line display on DEBUG_EXTRA or IN_INSTALL. [ticket/10057] Fixed wrong usage of sql_error in postgres dbal. [ticket/10057] Skip ibase_service_attach if firebird connection failed. [ticket/10057] Check for interbase function existence. [ticket/10057] Split statements in firebird dbal for readability. [ticket/10057] Include error collector class file in postgres dbal. [ticket/10057] Moved error collector class into its own file. [ticket/10057] Use a class for error collection. [ticket/10057] More informative error messages in postgres dbal. [ticket/10057] No negative array indexing. [ticket/10057] Report postgres db connection errors.
| * | | | | | | | [ticket/10057] Fixes for a bunch of small problems.Oleg Pudeyev2011-03-083-2/+18
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10057
| * | | | | | | | [ticket/10057] Handle the case of missing interbase extension better.Oleg Pudeyev2011-03-071-1/+17
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10057
| * | | | | | | | [ticket/10057] Fixed wrong usage of sql_error again, in firebird.Oleg Pudeyev2011-03-071-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This necessitates adding connect_error property to firebird. PHPBB3-10057
| * | | | | | | | [ticket/10057] Fixed usage of sql_error again.Oleg Pudeyev2011-03-071-2/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10057
| * | | | | | | | [ticket/10057] Condition file/line display on DEBUG_EXTRA or IN_INSTALL.Oleg Pudeyev2011-03-071-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10057
| * | | | | | | | [ticket/10057] Fixed wrong usage of sql_error in postgres dbal.Oleg Pudeyev2011-03-061-3/+15
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | pg_last_error does not work if no connection was ever established. Therefore we must keep track of connection errors in postgres dbal ourselves. PHPBB3-10057
| * | | | | | | | [ticket/10057] Skip ibase_service_attach if firebird connection failed.Oleg Pudeyev2011-03-061-1/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | ibase_errmsg works for the most recent call. If the connection fails, any error message is clobbered by ibase_service_attach call. PHPBB3-10057
| * | | | | | | | [ticket/10057] Check for interbase function existence.Oleg Pudeyev2011-03-061-0/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Calling nonexistent functions with @ destroys the script with no feedback as to the cause of the error. Check whether interbase functions exist before calling them. PHPBB3-10057
| * | | | | | | | [ticket/10057] Split statements in firebird dbal for readability.Oleg Pudeyev2011-03-061-2/+16
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHPBB3-10057
| * | | | | | | | [ticket/10057] Include error collector class file in postgres dbal.Oleg Pudeyev2011-03-061-0/+5
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This change is in its own commit because it will be reverted for 3.1. PHPBB3-10057
| * | | | | | | | [ticket/10057] Moved error collector class into its own file.Oleg Pudeyev2011-03-062-44/+45
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will make it autoloadable in 3.1. This commit breaks 3.0 since no code includes the error collector. Such include code will be in its own commit since it will need to be reverted in 3.1. PHPBB3-10057
| * | | | | | | | [ticket/10057] Use a class for error collection.Oleg Pudeyev2011-03-062-36/+38
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Replaced error collection functions with a class for a cleaner implementation. PHPBB3-10057
| * | | | | | | | [ticket/10057] More informative error messages in postgres dbal.Oleg Pudeyev2011-03-061-2/+2
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When pg_connect/pg_pconnect do not exist, mention that they come with pgsql extension. PHPBB3-10057
| * | | | | | | | [ticket/10057] No negative array indexing.Oleg Pudeyev2011-03-061-1/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | PHP manual does not say that negative array indices are allowed, so it's best to assume they are not guaranteed to work the way one would expect. PHPBB3-10057
| * | | | | | | | [ticket/10057] Report postgres db connection errors.Oleg Pudeyev2011-03-062-1/+58
| |/ / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Addresses two issues: 1. When pgsql extension is missing, @pg_connect would silently abort execution. Check for pg_connect existence before calling it, same with pg_pconnect. 2. When connection fails, the error reported by php is discarded. User is shown the failure message without the reason for failure, making debugging difficult. Collect the error (if any) via a temporarily installed error handler, and display it if connection failed. PHPBB3-10057