aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [feature/template-engine] Replaced globals with dependency injection.Oleg Pudeyev2011-05-124-39/+65
| | | | PHPBB3-9726
* [feature/template-engine] Deleted useless catch.Oleg Pudeyev2011-05-121-4/+0
| | | | | | In tests there is no need to catch unexpected exceptions. PHPBB3-9726
* [feature/template-engine] Delete obsolete comments pertaining to notices.Oleg Pudeyev2011-05-121-7/+0
| | | | PHPBB3-9726
* [feature/template-engine] Clarify cache directory path for set_custom_templateOleg Pudeyev2011-05-121-1/+4
| | | | | | | Even if the template may be outside of phpBB, phpBB's cache directory is still going to be used for storing compiled template code. PHPBB3-9726
* [feature/template-engine] Try to handle failed template includes.Oleg Pudeyev2011-05-121-2/+3
| | | | PHPBB3-9726
* [feature/template-engine] Rename $filename to $compiled_path for clarity.Oleg Pudeyev2011-05-121-6/+6
| | | | PHPBB3-9726
* [feature/template-engine] Move DEBUG_EXTRA check for $recompile up.Oleg Pudeyev2011-05-121-14/+10
| | | | PHPBB3-9726
* [feature/template-engine] Deleted useless assignment.Oleg Pudeyev2011-05-121-1/+0
| | | | PHPBB3-9726
* [feature/template-engine] Added docblocks to get_*_ref in context.Oleg Pudeyev2011-05-121-0/+22
| | | | PHPBB3-9726
* [feature/template-engine] Fixed reference usage.Oleg Pudeyev2011-05-123-3/+7
| | | | | | | Hopefully this is right, I have not checked it against the manual (assuming the manual even covers these things). PHPBB3-9726
* [feature/template-engine] Disposed of underscores in property names.Oleg Pudeyev2011-05-122-32/+32
| | | | PHPBB3-9726
* [feature/template-engine] Remove commented out error reporting logic.Oleg Pudeyev2011-05-121-10/+0
| | | | PHPBB3-9726
* [feature/template-engine] Refactor hook logic into a separate function.Oleg Pudeyev2011-05-121-7/+24
| | | | PHPBB3-9726
* [feature/template-engine] Reinstate phpbb_template#destroy function.Oleg Pudeyev2011-05-121-0/+9
| | | | PHPBB3-9726
* [feature/template-engine] Add back IN_PHPBB preamble.Oleg Pudeyev2011-05-123-1/+53
| | | | PHPBB3-9726
* [feature/template-engine] Moved template classes to subdirectory.Oleg Pudeyev2011-05-085-0/+0
| | | | PHPBB3-9726
* [feature/template-engine] Renamed template executor and friends to renderer.Oleg Pudeyev2011-05-084-33/+33
| | | | PHPBB3-9726
* [feature/template-engine] Added docblocks and boilerplate to new files.Oleg Pudeyev2011-05-074-0/+76
| | | | PHPBB3-9726
* [feature/template-engine] Removed more dead code.Oleg Pudeyev2011-05-071-6/+0
| | | | PHPBB3-9726
* [feature/template-engine] Added phpbb_template_context class.Oleg Pudeyev2011-05-076-246/+367
| | | | | | Objects of this class hold variables assigned to templates. PHPBB3-9726
* [feature/template-engine] Always call ob_end_clean.Oleg Pudeyev2011-05-051-1/+1
| | | | | | We have to stop output buffering even when rendering fails. PHPBB3-9726
* [feature/template-engine] Removed some dead code.Oleg Pudeyev2011-05-041-3/+1
| | | | PHPBB3-9726
* [feature/template-engine] Split template execution logic into classes.Oleg Pudeyev2011-05-044-63/+123
| | | | | | | | | | | Template executor interface defines a template executor object. It is an object which can execute (i.e. display/render) a template. Currently there are two implementations: * phpbb_template_executor_include includes php code from a file. * phpbb_template_executor_eval eval's php code. PHPBB3-9726
* [feature/template-engine] Removed storedb-related logic.Oleg Pudeyev2011-05-041-124/+2
| | | | | | | | | phpBB 3.1 will not provide the option to store templates in the database. This commit removes code that handles templates stored in database from the template engine. PHPBB3-9726
* [feature/template-engine] Delete template class, use phpbb_template instead.Oleg Pudeyev2011-05-045-13/+4
| | | | PHPBB3-9726
* [feature/template-engine] Rename template_compile methods for clarity.Oleg Pudeyev2011-05-043-12/+12
| | | | PHPBB3-9726
* [feature/template-engine] Extracted compile_stream_to_stream.Oleg Pudeyev2011-05-011-4/+19
| | | | PHPBB3-9726
* [feature/template-engine] Close output stream in compile().Oleg Pudeyev2011-05-011-1/+4
| | | | | | | There is no need to leave the stream to the garbage collector, and the amount of data stuck in it may be substantial. PHPBB3-9726
* [feature/template-engine] Fixed description of assign_display().Oleg Pudeyev2011-05-011-1/+1
| | | | | | | This function returns false on failure, which can happen if display() failed. Document the failure return value. PHPBB3-9726
* [feature/template-engine] Only copy files to cache if they exist.Oleg Pudeyev2011-05-011-2/+3
| | | | | | | | When testing eval code path, compiled templates may not be written to the file system, and unconditionally trying to copy them breaks tests. PHPBB3-9726
* [feature/template-engine] Relax missing file exception check.Oleg Pudeyev2011-05-011-1/+1
| | | | | | | As long as the exception message has the correct description and file name we should not care which function raised the exception. PHPBB3-9726
* [feature/template-engine] Check return value of display() in assign_display().Oleg Pudeyev2011-05-011-1/+5
| | | | | | If display() failed, propagate the failure out of assign_display(). PHPBB3-9726
* [feature/template-engine] Removed $this from new phpbb_template_compile calls.Oleg Pudeyev2011-04-261-3/+3
| | | | | | The compile class no longer takes template as a parameter. PHPBB3-9726
* [feature/template-engine] Fix negative variable expressionsIgor Wiedler2011-04-254-13/+9
| | | | | | | | | | | | | compile_tag_if had the flawed approach of adding an isset statement for all variables to the beginning of the if. This fails for negative expressions, and checking those takes a considerable effort. The easier solution is to make the variable expression itself conditional, defaulting to null if it is not set. Thanks to naderman for the solution. PHPBB3-9726
* [feature/template-engine] Added a test for reuse of loop identifiers.Oleg Pudeyev2011-04-252-0/+16
| | | | | | | | | This currently does not pass, thus it is commented out. The reuse appears implausible in the same file, however it may be also done across template files where it is much harder to detect. PHPBB3-9726
* [feature/template-engine] Corrected miscompilation of loop size constructs.Oleg Pudeyev2011-04-253-1/+47
| | | | PHPBB3-9726
* [feature/template-engine] Created a script to compile templates.Oleg Pudeyev2011-04-241-0/+24
| | | | | | | Script takes path to template as the only argument and outputs the compiled template to standard output. PHPBB3-9726
* [feature/template-engine] Corrected an off-by-one error in nested namespaces.Oleg Pudeyev2011-04-244-4/+29
| | | | | | | | This error resulted in a dot from the namespace being placed into variable reference in compiled template code, thus creating bogus compiled template code. PHPBB3-9726
* [feature/template-engine] Added a test for multilevel references in loops.Oleg Pudeyev2011-04-242-0/+24
| | | | | | | | | This currently fails. This test is a reduced version of permission_mask template in acp, which is not correctly compiled by the current template engine code. PHPBB3-9726
* [feature/template-engine] Deleted silencing of notices.Oleg Pudeyev2011-04-242-3/+5
| | | | | | | The code is now supposed to be notice-free, therefore there is no need to have the notices silenced. PHPBB3-9726
* [feature/template-engine] Deleted $template from phpbb_template_compile class.Oleg Pudeyev2011-04-243-96/+74
| | | | | | | | | | | | | phpbb_template_compile is now much simpler. It takes complete file paths as inputs, either source template path or source template path and output compiled template path. The number of methods also went down to two - compile template and returned compiled text or compile and write to file. phpbb_compile class is responsible for determining source and compiled paths. It already had all the data necessary for this, now the code is in the same place as the data it uses. PHPBB3-9726
* [ticket/9924] Pass template instance into $template->display hookIgor Wiedler2011-04-241-1/+1
| | | | | | | This is a cherry-pick of 053cf790a93e9cfb521f484901d79c72783f868f which appears to have been partially reverted here. PHPBB3-9924
* [feature/template-engine] Removed a useless space.Oleg Pudeyev2011-04-241-1/+1
| | | | PHPBB3-9726
* [feature/template-engine] Delete class_exists checks, rely on autoloading.Oleg Pudeyev2011-04-241-10/+0
| | | | PHPBB3-9726
* [feature/template-engine] Allow leading underscores in variable names.Oleg Pudeyev2011-04-243-3/+33
| | | | | | Subsilver uses ._file in overall_header. PHPBB3-9726
* [feature/template-engine] Fix recompilation logic.Oleg Pudeyev2011-04-242-11/+14
| | | | | | | | | Do not change $recompile from true to false - any recompilation condition alone is sufficient to force recompilation. Also uncomment the nonexistent file test which passes with this fix. PHPBB3-9726
* [feature/template-engine] Adjust path in includephp template.Oleg Pudeyev2011-04-241-1/+1
| | | | | | Now that tests are run from top level the '..' is wrong. PHPBB3-9726
* [feature/template-engine] Delete ?>, add newline at EOF.Oleg Pudeyev2011-04-232-3/+1
| | | | PHPBB3-9726
* [feature/template-engine] Improved template engine.Marek A. Ruszczynski2011-04-233-877/+1204
| | | | PHPBB3-9726
* [feature/template-engine] Update tests.Marek A. Ruszczynski2011-04-235-55/+30
| | | | PHPBB3-9726
generated by cgit v1.2.1 (git 2.21.0) at 2025-05-31 10:30:15 +0000