aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
* [ticket/11620] Add extract_current_hostnameAndy Chase2013-07-052-1/+68
| | | | | | Add a tests for extracting the current hostname from session. PHPBB3-11620
* [ticket/11620] Add data provider to extract_pageAndy Chase2013-07-051-14/+91
| | | | | | | | These test cases were taken from a live session, more test cases should be added to test specific functionality in this function. PHPBB3-11620
* [ticket/11620] Rename class_functions_test -> extract_page_testAndy Chase2013-07-051-1/+1
| | | | | | | Renaming this file because it is going to contain a large data provider, so I'd rather split this test out. PHPBB3-11620
* [ticket/11620] Remove accidental argument from testable_facade.Andy Chase2013-07-051-1/+1
| | | | PHPBB3-11620
* [ticket/11620] Add test for test_extract_current_pageAndy Chase2013-07-051-0/+49
| | | | PHPBB3-11620
* [ticket/11620] Add testable facade for sessions.phpAndy Chase2013-07-051-0/+49
| | | | | | | | | | Since many functions in session.php have global variables inside the function, this exposes those functions through a testable facade that uses testable_factory's mock global variables to modify global variables used in the functions. This is using the facade pattern to provide a testable "front" to the functions in sessions.php. PHPBB3-11620
* Merge remote-tracking branch 'Hardolaf/feature/auth-refactor' into developAndreas Fischer2013-07-055-0/+10
|\ | | | | | | | | * Hardolaf/feature/auth-refactor: [feature/auth-refactor] Move auth providers to separate directory
| * [feature/auth-refactor] Move auth providers to separate directoryJoseph Warner2013-07-045-0/+10
|/ | | | | | | Moves the provider files to their own directory per bantu's suggestion. PHPBB3-9734
* Merge remote-tracking branch 'VSEphpbb/ticket/11577' into developAndreas Fischer2013-07-031-1/+1
|\ | | | | | | | | | | * VSEphpbb/ticket/11577: [ticket/11577] Readjust min-height to 35px [ticket/11577] Correct over-sized Topic Rows
| * [ticket/11577] Readjust min-height to 35pxMatt Friedman2013-06-291-1/+1
| | | | | | | | | | | | | | Changing min-height to 35px in order to get pixel-for-pixel accurate height settings as before for topic-rows. PHPBB3-11577
| * [ticket/11577] Correct over-sized Topic RowsMatt Friedman2013-05-281-1/+1
| | | | | | | | | | | | | | | | | | | | Fixes a change made in PR 1331 that oversized topic rows. Icons in topic rows, in Prosilver, are only 27px high, so we do not need a min-height as high as 40px. Setting it to 30px is more conservative and reclaims the original height of topic rows from before PR 1331. http://tracker.phpbb.com/browse/PHPBB3-11577 PHPBB3-11577
* | Merge remote-tracking branch 'Hardolaf/feature/auth-refactor' into developDavid King2013-07-0318-1005/+1507
|\ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * Hardolaf/feature/auth-refactor: (44 commits) [feature/auth-refactor] Fix code style issue [feature/auth-refactor] Fix comment grammar [feature/auth-refactor] Fix the actual cause of test failures [feature/auth-refactor] A possible fix for the functional test failures [feature/auth-refactor] Forgot @inheritdoc on methods [feature/auth-refactor] Finish and clean up documentation [feature/auth-refactor] Change phpEx to php_ext in new classes [feature/auth-refactor] Fix two session tests broken by changes [feature/auth-refactor] Removed no longer used variable [feature/auth-refactor] Fix errors in acp_board [feature/auth-refactor] Fix indentation on acp_board [feature/auth-refactor] Refactor auth in acp_board [feature/auth-refactor] Don't truncate name then reattach same thing [feature/auth-refactor] Remove old auth plugins [feature/auth-refactor] Remove references to old auth plugins [feature/auth-refactor] Fix auth tests to use mock objects correctly [feature/auth-refactor] Test validate_session on provider_apache [feature/auth-refactor] Test autologin() on provider_apache [feature/auth-refactor] Test login() for provider_apache [feature/auth-refactor] Test for init on provider_apache ...
| * | [feature/auth-refactor] Fix code style issueJoseph Warner2013-07-021-2/+2
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Fix comment grammarJoseph Warner2013-07-021-1/+1
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Fix the actual cause of test failuresJoseph Warner2013-07-012-2/+5
| | | | | | | | | | | | | | | | | | | | | | | | Enables super globals before the new container is instantiated in the final step of installation to prevent issues caused by trying to create a phpbb_request object when super globals are disabled. PHPBB3-9734
| * | [feature/auth-refactor] A possible fix for the functional test failuresJoseph Warner2013-07-011-1/+1
| | | | | | | | | | | | | | | | | | | | | I don't like this fix as it really shouldn't be needed. But it makes the functional tests pass. PHPBB3-9734
| * | [feature/auth-refactor] Forgot @inheritdoc on methodsJoseph Warner2013-06-283-0/+54
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Finish and clean up documentationJoseph Warner2013-06-274-74/+43
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Change phpEx to php_ext in new classesJoseph Warner2013-06-262-9/+9
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Fix two session tests broken by changesJoseph Warner2013-06-262-0/+26
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Removed no longer used variableJoseph Warner2013-06-261-1/+0
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Fix errors in acp_boardJoseph Warner2013-06-251-2/+2
| | | | | | | | | | | | | | | | | | Fixes errors introduced by the last several commits. PHPBB3-9734
| * | [feature/auth-refactor] Fix indentation on acp_boardJoseph Warner2013-06-251-41/+38
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Refactor auth in acp_boardJoseph Warner2013-06-251-22/+3
| | | | | | | | | | | | | | | | | | | | | | | | Changes the acp_board code to directly call the auth providers out of the $auth_providers variable that is populated by the phpbb_container. PHPBB3-9734
| * | [feature/auth-refactor] Don't truncate name then reattach same thingJoseph Warner2013-06-251-4/+4
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Remove old auth pluginsJoseph Warner2013-06-253-886/+0
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Remove references to old auth pluginsJoseph Warner2013-06-251-29/+9
| | | | | | | | | | | | | | | | | | | | | Removes what is hopefully the last references to the old auth plugins in the code base. PHPBB3-9734
| * | [feature/auth-refactor] Fix auth tests to use mock objects correctlyJoseph Warner2013-06-251-25/+123
| | | | | | | | | | | | PHPBB3-9734
| * | [feature/auth-refactor] Test validate_session on provider_apacheJoseph Warner2013-06-251-1/+5
| | | | | | | | | | | | | | | | | | | | | Provides a test for the validate_session() method of provider_apache. PHPBB3-9734
| * | [feature/auth-refactor] Test autologin() on provider_apacheJoseph Warner2013-06-251-0/+28
| | | | | | | | | | | | | | | | | | | | | Provides a test for the autologin() method of provider_apache that assumes the user already exists in the database. PHPBB3-9734
| * | [feature/auth-refactor] Test login() for provider_apacheJoseph Warner2013-06-251-1/+20
| | | | | | | | | | | | | | | | | | | | | | | | Provides a test for the login() method for provider_apache. Appears to be failing due to an issue with the mock phpBB request class. PHPBB3-9734
| * | [feature/auth-refactor] Test for init on provider_apacheJoseph Warner2013-06-251-4/+12
| | | | | | | | | | | | | | | | | | | | | Provides a test for the init() method of provider_apache. Appears to be failing due to an error with the mock request class. PHPBB3-9734
| * | [feature/auth-refactor] Skeleton of provider_apache_testJoseph Warner2013-06-251-0/+49
| | | | | | | | | | | | | | | | | | Creates a skeleton of the tests for provider_apache. PHPBB3-9734
| * | [feature/auth-refactor] Finish provider_db unit test for loginJoseph Warner2013-06-251-2/+12
| | | | | | | | | | | | | | | | | | | | | Finishes the provider_db unit test for login. The test currently passes. PHPBB3-9734
| * | [feature/auth-refactor] Initial auth unit test provider_dbJoseph Warner2013-06-242-0/+73
| | | | | | | | | | | | | | | | | | | | | Initial work on a unit test for the provider_db login function. Does not work currently. PHPBB3-9734
| * | [feature/auth-refactor] Refactor code to use servicesJoseph Warner2013-06-213-40/+24
| | | | | | | | | | | | | | | | | | | | | Refactors all loading of auth providers to use services instead of directly calling the class. PHPBB3-9734
| * | [feature/auth-refactor] Create an auth.provider_collector serviceJoseph Warner2013-06-201-0/+12
| | | | | | | | | | | | | | | | | | Creates an auth.provider_collector service for all auth providers. PHPBB3-9734
| * | [feature/auth-refactor] Convert provider_apache to a serviceJoseph Warner2013-06-202-41/+55
| | | | | | | | | | | | | | | | | | Removes globals from provider_apache and turns it into a service. PHPBB3-9734
| * | [feature/auth-refactor] Convert provider_ldap to a serviceJoseph Warner2013-06-202-59/+67
| | | | | | | | | | | | | | | | | | Removes globals from provider_ldap and converts it into a service. PHPBB3-9734
| * | [feature/auth-refactor] Turn provider_db into a serviceJoseph Warner2013-06-202-41/+74
| | | | | | | | | | | | | | | | | | Removes globals from provider_db and turns it into a service. PHPBB3-9734
| * | [feature/auth-refactor] Start turning auth providers into servicesJoseph Warner2013-06-202-0/+2
| | | | | | | | | | | | | | | | | | | | | Creates auth_provider.yml and includes auth_providers.yml in services.yml. PHPBB3-9734
| * | [feature/auth-refactor] Fix LDAP conversion errorJoseph Warner2013-06-201-3/+3
| | | | | | | | | | | | | | | | | | | | | | | | | | | I messed up when converting over auth_ldap this commit fixes that error. I have not been able to extensively test ldap due to not having ldap set up on this computer yet. Apache authentication appears to work. PHPBB3-9734
| * | [feature/auth-refactor] Finish refactoring auth pluginsJoseph Warner2013-06-195-10/+55
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I believe that this commit should have final minimal changes needed to replace the old auth plugins with the refactored auth plugins. Added a few more elements to the interface based on the old auth plugins. Documentation is not complete and need works on these new elements. PHPBB3-9734
| * | [feature/auth-refactor] Refactor session for new auth interfaceJoseph Warner2013-06-191-4/+4
| | | | | | | | | | | | | | | | | | Refactors phpbb_session to use the new auth interface. PHPBB3-9734
| * | [feature/auth-refactor] Refactor acp_board for new auth interfaceJoseph Warner2013-06-195-23/+22
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Partially refactors acp_board for the new authentication interface. Leaves some questionable if statements in the file. Modifies the interface to correctly impletment the acp() method. Modifies each provider to comply with the above mentioned interface modification. PHPBB3-9734
| * | [feature/auth-refactor] Fix typos causing changes to not workJoseph Warner2013-06-195-6/+5
| | | | | | | | | | | | | | | | | | | | | | | | Replaces short tags with long tags. Fixes the interface to be an interface and not class in the file. Removes unnecessary include_once from auth.php. PHPBB-9734
| * | [feature/auth-refactor] Refactor login to use new interfaceJoseph Warner2013-06-181-3/+4
| | | | | | | | | | | | | | | | | | Refactors auth.php to use the provider_interface during login. PHPBB-9734
| * | [feature/auth-refactor] Make DB auth consistent with interfaceJoseph Warner2013-06-181-13/+9
| | | | | | | | | | | | | | | | | | | | | | | | | | | Makes provider_db consistent with provider_interface. Removes $ip, $browser, and $forwarded_for from the arguments of phpbb_auth_provider_db::login() as these are provided by the global variable $user. PHPBB3-9734
| * | [feature/auth-refactor] Make LDAP consistent with interfaceJoseph Warner2013-06-181-5/+8
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Makes the provider_ldap consistent with the provider_interface except for the acp() method which has not yet been finalized. Renames phpbb_auth_provider_ldap::user_filter to phpbb_auth_provider_ldap::ldap_user_filter to maintain the original name of the function from auth_ldap. PHPBB3-9734
| * | [feature/auth-refactor] Make Apache consistent with interfaceJoseph Warner2013-06-181-1/+1
| | | | | | | | | | | | | | | | | | | | | Makes the provider_apache consistent with the provider_interface by removing the pass-by-reference of $username and $password. PHPBB3-9734
generated by cgit v1.2.1 (git 2.21.0) at 2026-02-20 06:28:45 +0000