| Commit message (Collapse) | Author | Age | Files | Lines |
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
Since the continue->isvalid refactoring is now in a branch with the
session_test_case framework, this test can be refactored to use that framework.
PHPBB3-11620
|
|
|
|
|
|
|
|
| |
Refactoring the continue/is_valid test to remove
the confusing data provider work around, while
still keeping redundancies down to a minimum.
PHPBB3-11615
|
|
|
|
| |
PHPBB3-11615
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
When defining a database test case with a setUp function, it is important
to call the parent's setup function, because that is when the database is setup.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
|
| |
Rename the class and file name to better match
what the class is mocking, as well as implement the
interface of that class.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
The mock provider object now better matches the interface
given for providers.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
|
|
| |
Due to an auth_refactor, there is a new dependency
in session.php on phpbb_container and a provider.
For purposes of testing, implemented a simple one.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
Added a test for the creation of a session with a simple test
for detecting whether a bot is present.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
indentation is probably more important than 80 characters per line apparently.
Single quotes instead of double per coding guidelines.
PHPBB3-11620
|
|
|
|
|
|
| |
Add a test for the validate_referrer function.
PHPBB3-11620
|
|
|
|
|
|
|
|
| |
There are functions listed in testable facade that don't have a lot of dependencies,
instead mostly just take the input and perform database functions on them.
These can be tested without a testable facade function and so will be removed.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
| |
Make the class functions of testable_facade no longer static methods,
but a class based one and expand the methods to be filled in, in later commits.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
| |
Add a tests for extracting the current hostname from session.
PHPBB3-11620
|
|
|
|
|
|
|
|
| |
These test cases were taken from a live session,
more test cases should be added to test specific
functionality in this function.
PHPBB3-11620
|
|
|
|
|
|
|
| |
Renaming this file because it is going to contain a large data provider,
so I'd rather split this test out.
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
| |
PHPBB3-11620
|
|
|
|
|
|
|
|
|
|
| |
Since many functions in session.php have global variables inside the function,
this exposes those functions through a testable facade that uses testable_factory's
mock global variables to modify global variables used in the functions.
This is using the facade pattern to provide a testable "front" to the functions in sessions.php.
PHPBB3-11620
|
|\
| |
| |
| |
| | |
* Hardolaf/feature/auth-refactor:
[feature/auth-refactor] Move auth providers to separate directory
|
|/
|
|
|
|
|
| |
Moves the provider files to their own directory per bantu's
suggestion.
PHPBB3-9734
|
|\
| |
| |
| |
| |
| | |
* VSEphpbb/ticket/11577:
[ticket/11577] Readjust min-height to 35px
[ticket/11577] Correct over-sized Topic Rows
|
| |
| |
| |
| |
| |
| |
| | |
Changing min-height to 35px in order to get pixel-for-pixel accurate
height settings as before for topic-rows.
PHPBB3-11577
|
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
Fixes a change made in PR 1331 that oversized topic rows.
Icons in topic rows, in Prosilver, are only 27px high, so we do not need
a min-height as high as 40px. Setting it to 30px is more conservative
and reclaims the original height of topic rows from before PR 1331.
http://tracker.phpbb.com/browse/PHPBB3-11577
PHPBB3-11577
|
|\ \
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* Hardolaf/feature/auth-refactor: (44 commits)
[feature/auth-refactor] Fix code style issue
[feature/auth-refactor] Fix comment grammar
[feature/auth-refactor] Fix the actual cause of test failures
[feature/auth-refactor] A possible fix for the functional test failures
[feature/auth-refactor] Forgot @inheritdoc on methods
[feature/auth-refactor] Finish and clean up documentation
[feature/auth-refactor] Change phpEx to php_ext in new classes
[feature/auth-refactor] Fix two session tests broken by changes
[feature/auth-refactor] Removed no longer used variable
[feature/auth-refactor] Fix errors in acp_board
[feature/auth-refactor] Fix indentation on acp_board
[feature/auth-refactor] Refactor auth in acp_board
[feature/auth-refactor] Don't truncate name then reattach same thing
[feature/auth-refactor] Remove old auth plugins
[feature/auth-refactor] Remove references to old auth plugins
[feature/auth-refactor] Fix auth tests to use mock objects correctly
[feature/auth-refactor] Test validate_session on provider_apache
[feature/auth-refactor] Test autologin() on provider_apache
[feature/auth-refactor] Test login() for provider_apache
[feature/auth-refactor] Test for init on provider_apache
...
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
Enables super globals before the new container is instantiated in
the final step of installation to prevent issues caused by trying
to create a phpbb_request object when super globals are disabled.
PHPBB3-9734
|
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
I don't like this fix as it really shouldn't be needed. But it
makes the functional tests pass.
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | | |
PHPBB3-9734
|
| | |
| | |
| | |
| | |
| | |
| | | |
Fixes errors introduced by the last several commits.
PHPBB3-9734
|