aboutsummaryrefslogtreecommitdiffstats
Commit message (Collapse)AuthorAgeFilesLines
...
* - added phpBB test framework which is an extension with some additionalNils Adermann2008-11-242-0/+35
| | | | | | | | functionality of PHPUnit - first addition: setExpectedTriggerError() if a test expects a call to trigger_error(). git-svn-id: file:///svn/phpbb/trunk@9103 89ea8834-ac86-4346-8a33-228a782c2dd0
* - updated all code to use the request class instead of any direct access toNils Adermann2008-11-2473-347/+369
| | | | | | | | | super globals - disabled super globals in common.php. See commit r9101 for more information - cleaned up/simplified a few lines along the way. git-svn-id: file:///svn/phpbb/trunk@9102 89ea8834-ac86-4346-8a33-228a782c2dd0
* Introducing the new request class. All input his handled through this class.Nils Adermann2008-11-231-126/+513
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | "Given a choice between dancing pigs and security, users will pick dancing pigs every time." (Gary McGraw and Edward Felten) What stays the same? - request_var() keeps working as it used to, alternatively you can directly use request::variable() which allows choosing which super global you want to read So what's new? - request::disable_super_globals() which disables super globals. This function causes any direct use of $_POST, $_GET, $_REQUEST or $_COOKIE to result in an E_USER_ERROR. We hope that this will force MOD authors to at least think about validation as they will have to read about how to use the request class. - request::is_set() / request::is_set_post will be used instead of using isset directly on super globals - request_var() now supports arrays with arbitrary depth - request_var() can be used with an array as the variable name to directly access values in mutli dimensional arrays. What's next? - request::disable_super_globals() will be active by default (set in common.php) - all code will be adjusted to use the new class consistently - tests for the request class to make sure it works as designed and will not change behaviour between releases I've also already updated all the code within functions.php to use the request class. git-svn-id: file:///svn/phpbb/trunk@9101 89ea8834-ac86-4346-8a33-228a782c2dd0
* More testsChris Smith2008-11-237-9/+147
| | | | git-svn-id: file:///svn/phpbb/trunk@9100 89ea8834-ac86-4346-8a33-228a782c2dd0
* test advanced loop constructsChris Smith2008-11-232-1/+66
| | | | git-svn-id: file:///svn/phpbb/trunk@9099 89ea8834-ac86-4346-8a33-228a782c2dd0
* S_NUM_ROWS gives you the number of rows in a blockChris Smith2008-11-233-3/+13
| | | | git-svn-id: file:///svn/phpbb/trunk@9098 89ea8834-ac86-4346-8a33-228a782c2dd0
* Why did I not do it this way to begin with :)Chris Smith2008-11-231-32/+38
| | | | git-svn-id: file:///svn/phpbb/trunk@9097 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Change] Alllow applications to set custom module inclusion path (idea by HoL)Meik Sievertsen2008-11-231-1/+35
| | | | git-svn-id: file:///svn/phpbb/trunk@9096 89ea8834-ac86-4346-8a33-228a782c2dd0
* Will he ever be happy? ...Chris Smith2008-11-231-21/+14
| | | | git-svn-id: file:///svn/phpbb/trunk@9094 89ea8834-ac86-4346-8a33-228a782c2dd0
* Refactor and fix :)Chris Smith2008-11-233-43/+27
| | | | git-svn-id: file:///svn/phpbb/trunk@9093 89ea8834-ac86-4346-8a33-228a782c2dd0
* Run template tests over non-cached data as wellChris Smith2008-11-232-8/+55
| | | | git-svn-id: file:///svn/phpbb/trunk@9092 89ea8834-ac86-4346-8a33-228a782c2dd0
* all 557 tests pass now :DChris Smith2008-11-232-1/+14
| | | | git-svn-id: file:///svn/phpbb/trunk@9091 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix r9088Chris Smith2008-11-231-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9089 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix a tiny bugChris Smith2008-11-231-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9088 89ea8834-ac86-4346-8a33-228a782c2dd0
* - Deprecate S_ROW_COUNT use S_ROW_NUMChris Smith2008-11-225-59/+78
| | | | | | | | | - S_ROW_NUM, S_FIRST_ROW, S_LAST_ROW are now using internal template engine variables saving memory - Other small changes - Update of template tests git-svn-id: file:///svn/phpbb/trunk@9087 89ea8834-ac86-4346-8a33-228a782c2dd0
* - merge r9084 and r9085Nils Adermann2008-11-224-3/+165
| | | | | | - added tests for make_clickable git-svn-id: file:///svn/phpbb/trunk@9086 89ea8834-ac86-4346-8a33-228a782c2dd0
* Only display special ranks to guests; no longer display normal ranks for ↵Meik Sievertsen2008-11-224-7/+8
| | | | | | | | guests (Bug #36735) [changed parameters for get_user_rank(), breaks backward compatibility] git-svn-id: file:///svn/phpbb/trunk@9083 89ea8834-ac86-4346-8a33-228a782c2dd0
* define cookie var for styleswitcher.js for popups (Bug #36765)Meik Sievertsen2008-11-221-0/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9081 89ea8834-ac86-4346-8a33-228a782c2dd0
* Do not try to send jabber notifications if no jid entered (Bug #36775)Meik Sievertsen2008-11-221-0/+11
| | | | git-svn-id: file:///svn/phpbb/trunk@9079 89ea8834-ac86-4346-8a33-228a782c2dd0
* merge revisions i missed... hopefully not breaking things - did not check ↵Meik Sievertsen2008-11-2233-59/+161
| | | | | | every change. git-svn-id: file:///svn/phpbb/trunk@9077 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge in r9065Chris Smith2008-11-221-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9074 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge R 9067Henry Sudhof2008-11-212-3/+5
| | | | git-svn-id: file:///svn/phpbb/trunk@9068 89ea8834-ac86-4346-8a33-228a782c2dd0
* been a while :( ... merge in r8997, r8998, r8999, r9000, r9001, r9002, ↵Chris Smith2008-11-1334-47/+139
| | | | | | r9003, r9004, r9005, r9007, r9008, r9009, r9010, r9011, r9012, r9013, r9014, r9015, r9022, r9023, r9029, r9030, r9034, r9048, r9049, r9054, r9056 git-svn-id: file:///svn/phpbb/trunk@9064 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merging R9051 and R 9052Henry Sudhof2008-11-131-5/+8
| | | | git-svn-id: file:///svn/phpbb/trunk@9062 89ea8834-ac86-4346-8a33-228a782c2dd0
* #36695Henry Sudhof2008-11-131-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9061 89ea8834-ac86-4346-8a33-228a782c2dd0
* db_tools from static to non-static due to the db dependancy (#31245)Meik Sievertsen2008-11-022-168/+142
| | | | git-svn-id: file:///svn/phpbb/trunk@9044 89ea8834-ac86-4346-8a33-228a782c2dd0
* we no longer need them. Schema is in install now.Meik Sievertsen2008-11-022-3347/+0
| | | | git-svn-id: file:///svn/phpbb/trunk@9043 89ea8834-ac86-4346-8a33-228a782c2dd0
* i had these changes sitting... must've been a merge not committed (and ↵Meik Sievertsen2008-11-027-10/+22
| | | | | | because we do not use svn 1.5 as the client version i am not able to say which they were) git-svn-id: file:///svn/phpbb/trunk@9042 89ea8834-ac86-4346-8a33-228a782c2dd0
* gah@trunkMeik Sievertsen2008-10-171-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9027 89ea8834-ac86-4346-8a33-228a782c2dd0
* Disable referer validation on install if it is not possible to determine ↵Meik Sievertsen2008-10-171-0/+10
| | | | | | correct referer due to a proxy setup (Bug #32765) git-svn-id: file:///svn/phpbb/trunk@9025 89ea8834-ac86-4346-8a33-228a782c2dd0
* Initial template tests, a bit hackish currently, excuse the rushed nature of ↵Chris Smith2008-10-1510-0/+330
| | | | | | this commit got to catch a train :) git-svn-id: file:///svn/phpbb/trunk@9020 89ea8834-ac86-4346-8a33-228a782c2dd0
* Mini bug fix for UNDEFINEChris Smith2008-10-151-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@9016 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merging r8993, r8994, r8995Chris Smith2008-10-105-9/+21
| | | | git-svn-id: file:///svn/phpbb/trunk@8996 89ea8834-ac86-4346-8a33-228a782c2dd0
* Add two standard language items - #30885Meik Sievertsen2008-10-094-4/+37
| | | | | | | Make sure users still get notifications if they set to only be notified by Jabber, but Jabber service disabled. (Bug #29715 - Patch by Paul) git-svn-id: file:///svn/phpbb/trunk@8991 89ea8834-ac86-4346-8a33-228a782c2dd0
* - Do not show link to user/group profiles if user has no permission to view ↵Meik Sievertsen2008-10-0912-23/+45
| | | | | | | | | the linked page and gets a denied message anyway. (Bug #15088) - Do not display last post link and sort display options for search engines. (Bug #15088) git-svn-id: file:///svn/phpbb/trunk@8988 89ea8834-ac86-4346-8a33-228a782c2dd0
* Implemented strict check for cached user permissions and existing ACL ↵Meik Sievertsen2008-10-091-9/+46
| | | | | | options. This fix makes sure cached permissions are valid, even if they got already cached. git-svn-id: file:///svn/phpbb/trunk@8986 89ea8834-ac86-4346-8a33-228a782c2dd0
* Show coloured guest names correctly if not enclosed in <a> tags. ;) Bug #21935Meik Sievertsen2008-10-081-0/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@8984 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge revisions:Meik Sievertsen2008-10-0810-42/+69
| | | | | | r8974, r8975, r8976, r8977, r8978, r8979 git-svn-id: file:///svn/phpbb/trunk@8980 89ea8834-ac86-4346-8a33-228a782c2dd0
* merge r8970 and r8971Meik Sievertsen2008-10-064-25/+35
| | | | git-svn-id: file:///svn/phpbb/trunk@8972 89ea8834-ac86-4346-8a33-228a782c2dd0
* [Change] Remove NUL-Bytes directly in request_var() for strings and within ↵Meik Sievertsen2008-10-026-6/+11
| | | | | | the custom DBAL sql_escape() functions (MSSQL, Firebird, Oracle) (reported by AdhostMikeSw) git-svn-id: file:///svn/phpbb/trunk@8968 89ea8834-ac86-4346-8a33-228a782c2dd0
* mehHenry Sudhof2008-10-012-0/+0
| | | | git-svn-id: file:///svn/phpbb/trunk@8966 89ea8834-ac86-4346-8a33-228a782c2dd0
* and why not this as well?Henry Sudhof2008-10-013-0/+902
| | | | git-svn-id: file:///svn/phpbb/trunk@8965 89ea8834-ac86-4346-8a33-228a782c2dd0
* merge r8956, r8957 and r8960Meik Sievertsen2008-09-305-13/+17
| | | | git-svn-id: file:///svn/phpbb/trunk@8961 89ea8834-ac86-4346-8a33-228a782c2dd0
* #34815Henry Sudhof2008-09-301-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@8959 89ea8834-ac86-4346-8a33-228a782c2dd0
* revert r8893 - there were massive problems with the display and select all codeMeik Sievertsen2008-09-284-5/+10
| | | | git-svn-id: file:///svn/phpbb/trunk@8954 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge in r8940, r8941, r8942, r8945, r8946, r8947, r8949, r8950, r8951Chris Smith2008-09-2714-27/+40
| | | | git-svn-id: file:///svn/phpbb/trunk@8952 89ea8834-ac86-4346-8a33-228a782c2dd0
* tiny typo #34345Chris Smith2008-09-261-1/+1
| | | | git-svn-id: file:///svn/phpbb/trunk@8948 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge in r8924, r8925, r8926, r8936, r8938Chris Smith2008-09-266-7/+17
| | | | git-svn-id: file:///svn/phpbb/trunk@8939 89ea8834-ac86-4346-8a33-228a782c2dd0
* Fix typosMarek A. R2008-09-252-2/+2
| | | | git-svn-id: file:///svn/phpbb/trunk@8937 89ea8834-ac86-4346-8a33-228a782c2dd0
* Merge in r8934Chris Smith2008-09-241-3/+0
| | | | git-svn-id: file:///svn/phpbb/trunk@8935 89ea8834-ac86-4346-8a33-228a782c2dd0
generated by cgit v1.2.1 (git 2.21.0) at 2025-11-12 15:46:22 +0000